Make GetPluginsForInterface private

Author: Jack251970

Flow.Launcher.Core/Plugin/PluginManager.cs

@@ -28,6 +28,8 @@ public static class PluginManager
 
         private static IEnumerable<PluginPair> _contextMenuPlugins;
         private static IEnumerable<PluginPair> _homePlugins;
+        private static IEnumerable<PluginPair> _resultUpdatePlugin;
+        private static IEnumerable<PluginPair> _translationPlugins;
         private static IEnumerable<PluginPair> _hotkeyPlugins;
 
         public static List<PluginPair> AllPlugins { get; private set; }
@@ -257,6 +259,8 @@ public static async Task InitializePluginsAsync()
 
             _contextMenuPlugins = GetPluginsForInterface<IContextMenu>();
             _homePlugins = GetPluginsForInterface<IAsyncHomeQuery>();
+            _resultUpdatePlugin = GetPluginsForInterface<IResultUpdated>();
+            _translationPlugins = GetPluginsForInterface<IPluginI18n>();
             _hotkeyPlugins = GetPluginsForInterface<IPluginHotkey>();
             var pluginHotkeyInfo = GetPluginHotkeyInfo();
             Settings.UpdatePluginHotkeyInfo(pluginHotkeyInfo);
@@ -420,7 +424,7 @@ public static PluginPair GetPluginForId(string id)
             return AllPlugins.FirstOrDefault(o => o.Metadata.ID == id);
         }
 
-        public static IEnumerable<PluginPair> GetPluginsForInterface<T>() where T : IFeatures
+        private static IEnumerable<PluginPair> GetPluginsForInterface<T>() where T : IFeatures
         {
             // Handle scenario where this is called before all plugins are instantiated, e.g. language change on startup
             return AllPlugins?.Where(p => p.Plugin is T) ?? Array.Empty<PluginPair>();
@@ -460,6 +464,17 @@ public static bool IsHomePlugin(string id)
             return _homePlugins.Any(p => p.Metadata.ID == id);
         }
 
+        public static IList<PluginPair> GetResultUpdatePlugin()
+        {
+            return _resultUpdatePlugin.Where(p => !PluginModified(p.Metadata.ID)).ToList();
+        }
+
+        public static IList<PluginPair> GetTranslationPlugins()
+        {
+            // Here we still return the modified plugins to update the possible string resources
+            return _translationPlugins.ToList();
+        }
+
         public static Dictionary<PluginPair, List<BasePluginHotkey>> GetPluginHotkeyInfo()
         {
             var hotkeyPluginInfos = new Dictionary<PluginPair, List<BasePluginHotkey>>();

Flow.Launcher.Core/Resource/Internationalization.cs

@@ -74,7 +74,7 @@ public static void InitSystemLanguageCode()
 
         private void AddPluginLanguageDirectories()
         {
-            foreach (var plugin in PluginManager.GetPluginsForInterface<IPluginI18n>())
+            foreach (var plugin in PluginManager.GetTranslationPlugins())
             {
                 var location = Assembly.GetAssembly(plugin.Plugin.GetType()).Location;
                 var dir = Path.GetDirectoryName(location);
@@ -278,7 +278,7 @@ public static string GetTranslation(string key)
 
         private void UpdatePluginMetadataTranslations()
         {
-            foreach (var p in PluginManager.GetPluginsForInterface<IPluginI18n>())
+            foreach (var p in PluginManager.GetTranslationPlugins())
             {
                 if (p.Plugin is not IPluginI18n pluginI18N) return;
                 try

Flow.Launcher/ViewModel/MainViewModel.cs

@@ -260,7 +260,7 @@ void continueAction(Task t)
 
         public void RegisterResultsUpdatedEvent()
         {
-            foreach (var pair in PluginManager.GetPluginsForInterface<IResultUpdated>())
+            foreach (var pair in PluginManager.GetResultUpdatePlugin())
             {
                 var plugin = (IResultUpdated)pair.Plugin;
                 plugin.ResultsUpdated += (s, e) =>