use ResultViewModel to hold constructed suggestion text instead

Author: jjw24

Flow.Launcher/Converters/QuerySuggestionBoxConverter.cs

@@ -46,7 +46,7 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
                 // construct autocomplete with suggestion
                 string _suggestion = queryText + selectedResultPossibleSuggestion.Substring(queryText.Length);
                 if (string.IsNullOrEmpty(selectedResult.AutoCompleteText))
-                    selectedItem.Result.AutoCompleteText = _suggestion;
+                    selectedItem.QuerySuggestionText = _suggestion;
 
                 // When user typed lower case and result title is uppercase, we still want to display suggestion
                 return queryText + selectedResultPossibleSuggestion.Substring(queryText.Length);

Flow.Launcher/ViewModel/MainViewModel.cs

@@ -233,14 +233,24 @@ private void InitializeKeyCommands()
                 var result = SelectedResults.SelectedItem?.Result;
                 if (result != null) // SelectedItem returns null if selection is empty.
                 {
-                    string _newText = String.IsNullOrEmpty(result.AutoCompleteText) ? result.Title : result.AutoCompleteText;
+                    var autoCompleteText = result.Title;
+
+                    if (!string.IsNullOrEmpty(result.AutoCompleteText))
+                    {
+                        autoCompleteText = result.AutoCompleteText;
+                    }
+                    else if (!string.IsNullOrEmpty(SelectedResults.SelectedItem?.QuerySuggestionText))
+                    {
+                        autoCompleteText = SelectedResults.SelectedItem.QuerySuggestionText;
+                    }
 
                     var SpecialKeyState = GlobalHotkey.Instance.CheckModifiers();
                     if (SpecialKeyState.ShiftPressed)
                     {
-                        _newText = result.SubTitle;
+                        autoCompleteText = result.SubTitle;
                     }
-                    ChangeQueryText(_newText);
+
+                    ChangeQueryText(autoCompleteText);
                 }
             });
 

Flow.Launcher/ViewModel/ResultViewModel.cs

@@ -142,6 +142,8 @@ private async ValueTask LoadImageAsync()
 
         public Result Result { get; }
 
+        public string QuerySuggestionText { get; set; }
+
         public override bool Equals(object obj)
         {
             return obj is ResultViewModel r && Result.Equals(r.Result);