Support plugin directory update & validate

Author: Jack251970

Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs

@@ -116,9 +116,6 @@ private IEnumerable<PluginPair> SetPathForPluginPairs(string filePath, string la
                 if (metadata.Language.Equals(languageToSet, StringComparison.OrdinalIgnoreCase))
                 {
                     metadata.AssemblyName = string.Empty;
-                    metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, metadata.Name);
-                    metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, metadata.Name);
-
                     pluginPairs.Add(CreatePluginPair(filePath, metadata));
                 }
             }

Flow.Launcher.Core/Plugin/PluginManager.cs

@@ -32,7 +32,7 @@ public static class PluginManager
 
         private static PluginsSettings Settings;
         private static List<PluginMetadata> _metadatas;
-        private static List<string> _modifiedPlugins = new List<string>();
+        private static List<string> _modifiedPlugins = new();
 
         /// <summary>
         /// Directories that will hold Flow Launcher plugin directory
@@ -152,6 +152,27 @@ public static void LoadPlugins(PluginsSettings settings)
             Settings = settings;
             Settings.UpdatePluginSettings(_metadatas);
             AllPlugins = PluginsLoader.Plugins(_metadatas, Settings);
+            UpdateAndValidatePluginDirectory(_metadatas);
+        }
+
+        private static void UpdateAndValidatePluginDirectory(List<PluginMetadata> metadatas)
+        {
+            foreach (var metadata in metadatas)
+            {
+                if (AllowedLanguage.IsDotNet(metadata.Language))
+                {
+                    metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, metadata.AssemblyName);
+                    metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, metadata.AssemblyName);
+                }
+                else
+                {
+                    metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, metadata.Name);
+                    metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, metadata.Name);
+                }
+
+                Helper.ValidateDirectory(metadata.PluginSettingsDirectoryPath);
+                Helper.ValidateDirectory(metadata.PluginCacheDirectoryPath);
+            }
         }
 
         /// <summary>
@@ -226,11 +247,9 @@ public static ICollection<PluginPair> ValidPluginsForQuery(Query query)
             if (query is null)
                 return Array.Empty<PluginPair>();
 
-            if (!NonGlobalPlugins.ContainsKey(query.ActionKeyword))
+            if (!NonGlobalPlugins.TryGetValue(query.ActionKeyword, out var plugin))
                 return GlobalPlugins;
 
-
-            var plugin = NonGlobalPlugins[query.ActionKeyword];
             return new List<PluginPair>
             {
                 plugin

Flow.Launcher.Core/Plugin/PluginsLoader.cs

@@ -75,11 +75,7 @@ public static IEnumerable<PluginPair> DotNetPlugins(List<PluginMetadata> source)
 
                             plugin = Activator.CreateInstance(type) as IAsyncPlugin;
 
-                            // Same as PluginJsonStorage.cs constructor
-                            var assemblyName = assembly.GetName().Name;
-                            metadata.AssemblyName = assemblyName;
-                            metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, assemblyName);
-                            metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, assemblyName);
+                            metadata.AssemblyName = assembly.GetName().Name;
                         }
 #if DEBUG
                         catch (Exception)
@@ -149,8 +145,6 @@ public static IEnumerable<PluginPair> ExecutablePlugins(IEnumerable<PluginMetada
                     };
 
                     plugin.Metadata.AssemblyName = string.Empty;
-                    plugin.Metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, plugin.Metadata.Name);
-                    plugin.Metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, plugin.Metadata.Name);
 
                     return plugin;
                 });
@@ -169,8 +163,6 @@ public static IEnumerable<PluginPair> ExecutableV2Plugins(IEnumerable<PluginMeta
                     };
 
                     plugin.Metadata.AssemblyName = string.Empty;
-                    plugin.Metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, plugin.Metadata.Name);
-                    plugin.Metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, plugin.Metadata.Name);
 
                     return plugin;
                 });

Flow.Launcher.Infrastructure/Logger/Log.cs

@@ -18,7 +18,7 @@ public static class Log
 
         static Log()
         {
-            CurrentLogDirectory = Path.Combine(DataLocation.DataDirectory(), DirectoryName, Constant.Version);
+            CurrentLogDirectory = DataLocation.VersionLogDirectory;
             if (!Directory.Exists(CurrentLogDirectory))
             {
                 Directory.CreateDirectory(CurrentLogDirectory);