clear obsolete code from Flow.Launcher.Plugin

Author: JohnTheGr8

Flow.Launcher.Core/Plugin/QueryBuilder.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using Flow.Launcher.Plugin;
 
@@ -33,9 +33,13 @@ public static Query Build(string text, Dictionary<string, PluginPair> nonGlobalP
                 searchTerms = terms;
             }
 
-            var query = new Query(rawQuery, search,terms, searchTerms, actionKeyword);
-
-            return query;
+            return new Query ()
+            {
+                Search = search,
+                RawQuery = rawQuery,
+                SearchTerms = searchTerms,
+                ActionKeyword = actionKeyword
+            };
         }
     }
 }

Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs

@@ -133,13 +133,6 @@ public interface IPublicAPI
         /// <returns></returns>
         List<PluginPair> GetAllPlugins();
 
-        /// <summary>
-        /// Fired after global keyboard events
-        /// if you want to hook something like Ctrl+R, you should use this event
-        /// </summary>
-        [Obsolete("Unable to Retrieve correct return value")]
-        event FlowLauncherGlobalKeyboardEventHandler GlobalKeyboardEvent;
-        
         /// <summary>
         /// Register a callback for Global Keyboard Event
         /// </summary>

Flow.Launcher.Plugin/Query.cs

@@ -6,16 +6,11 @@ public class Query
     {
         public Query() { }
 
-        /// <summary>
-        /// to allow unit tests for plug ins
-        /// </summary>
+        [Obsolete("Use the default Query constructor.")]
         public Query(string rawQuery, string search, string[] terms, string[] searchTerms, string actionKeyword = "")
         {
             Search = search;
             RawQuery = rawQuery;
-#pragma warning disable CS0618
-            Terms = terms;
-#pragma warning restore CS0618
             SearchTerms = searchTerms;
             ActionKeyword = actionKeyword;
         }
@@ -47,28 +42,16 @@ public Query(string rawQuery, string search, string[] terms, string[] searchTerm
         /// </summary>
         public string[] SearchTerms { get; init; }
 
-        /// <summary>
-        /// The raw query split into a string array
-        /// </summary>
-        [Obsolete("It may or may not include action keyword, which can be confusing. Use SearchTerms instead")]
-        public string[] Terms { get; init; }
-
         /// <summary>
         /// Query can be splited into multiple terms by whitespace
         /// </summary>
         public const string TermSeparator = " ";
 
-        [Obsolete("Typo")]
-        public const string TermSeperater = TermSeparator;
-
         /// <summary>
         /// User can set multiple action keywords seperated by ';'
         /// </summary>
         public const string ActionKeywordSeparator = ";";
 
-        [Obsolete("Typo")]
-        public const string ActionKeywordSeperater = ActionKeywordSeparator;
-
 
         /// <summary>
         /// Wildcard action keyword. Plugins using this value will be queried on every search.

Flow.Launcher.Plugin/Result.cs

@@ -133,12 +133,6 @@ public string IcoPath
         /// </summary>
         public IList<int> TitleHighlightData { get; set; }
 
-        /// <summary>
-        /// Deprecated as of Flow Launcher v1.9.1. Subtitle highlighting is no longer offered
-        /// </summary>
-        [Obsolete("Deprecated as of Flow Launcher v1.9.1. Subtitle highlighting is no longer offered")]
-        public IList<int> SubTitleHighlightData { get; set; }
-
         /// <summary>
         /// Query information associated with the result
         /// </summary>

Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs

@@ -1,4 +1,4 @@
-using Microsoft.Win32;
+using Microsoft.Win32;
 using System;
 using System.Diagnostics;
 using System.IO;
@@ -71,12 +71,6 @@ public static void OpenInBrowserWindow(this string url, string browserPath = "",
             }
         }
 
-        [Obsolete("This is provided for backwards compatibility after 1.9.0 release, e.g. GitHub plugin. Use the new method instead")]
-        public static void NewBrowserWindow(this string url, string browserPath = "")
-        {
-            OpenInBrowserWindow(url, browserPath);
-        }
-
         /// <summary> 
         /// Opens search as a tab in the default browser chosen in Windows settings.
         /// </summary>
@@ -111,11 +105,5 @@ public static void OpenInBrowserTab(this string url, string browserPath = "", bo
                 });
             }
         }
-
-        [Obsolete("This is provided for backwards compatibility after 1.9.0 release, e.g. GitHub plugin. Use the new method instead")]
-        public static void NewTabInBrowser(this string url, string browserPath = "")
-        {
-            OpenInBrowserTab(url, browserPath);
-        }
     }
 }

Flow.Launcher/PublicAPIInstance.cs

@@ -69,9 +69,6 @@ public void RestartApp()
             UpdateManager.RestartApp(Constant.ApplicationFileName);
         }
 
-        [Obsolete("Typo")]
-        public void RestarApp() => RestartApp();
-
         public void ShowMainWindow() => _mainVM.Show();
 
         public void HideMainWindow() => _mainVM.Hide();
@@ -295,8 +292,6 @@ public void OpenAppUri(Uri appUri)
             OpenUri(appUri);
         }
 
-        public event FlowLauncherGlobalKeyboardEventHandler GlobalKeyboardEvent;
-
         private readonly List<Func<int, int, SpecialKeyState, bool>> _globalKeyboardHandlers = new();
 
         public void RegisterGlobalKeyboardCallback(Func<int, int, SpecialKeyState, bool> callback) => _globalKeyboardHandlers.Add(callback);
@@ -309,10 +304,6 @@ public void OpenAppUri(Uri appUri)
         private bool KListener_hookedKeyboardCallback(KeyEvent keyevent, int vkcode, SpecialKeyState state)
         {
             var continueHook = true;
-            if (GlobalKeyboardEvent != null)
-            {
-                continueHook = GlobalKeyboardEvent((int)keyevent, vkcode, state);
-            }
             foreach (var x in _globalKeyboardHandlers)
             {
                 continueHook &= x((int)keyevent, vkcode, state);