review feedback, nit

dcog989 · dcog989 · commit 43934c477ba8 · 2025-09-26T15:05:40.000+01:00
diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/FaviconService.cs b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/FaviconService.cs
@@ -121,17 +121,24 @@ await Parallel.ForEachAsync(bookmarks, options, async (bookmark, token) =>
             var localData = await _localExtractor.GetFaviconDataAsync(bookmark, token);
             if (localData != null)
             {
-                var (pngData, _) = await _imageConverter.ToPngAsync(new MemoryStream(localData), token);
+                using var ms = new MemoryStream(localData, writable: false);
+                var (pngData, _) = await _imageConverter.ToPngAsync(ms, token);
                 if (pngData != null)
                 {
                     var path = hostCachePath;
+                    var tmp = path + "." + Guid.NewGuid().ToString("N") + ".tmp";
                     try
                     {
-                        await File.WriteAllBytesAsync(path, pngData, token);
+                        await File.WriteAllBytesAsync(tmp, pngData, token);
+                        try { File.Move(tmp, path, overwrite: false); }
+                        catch (IOException)
+                        {
+                            // Another thread may have created it concurrently.
+                        }
                     }
-                    catch (IOException)
+                    finally
                     {
-                        // Another thread may have created it concurrently.
+                        try { if (File.Exists(tmp)) File.Delete(tmp); } catch { /* best effort */ }
                     }
                     if (File.Exists(path))
                     {

Original file line number	Diff line number	Diff line change
`@@ -121,17 +121,24 @@ await Parallel.ForEachAsync(bookmarks, options, async (bookmark, token) =>`
`121`	`121`	`var localData = await _localExtractor.GetFaviconDataAsync(bookmark, token);`
`122`	`122`	`if (localData != null)`
`123`	`123`	`{`
`124`		`- var (pngData, _) = await _imageConverter.ToPngAsync(new MemoryStream(localData), token);`
	`124`	`+ using var ms = new MemoryStream(localData, writable: false);`
	`125`	`+ var (pngData, _) = await _imageConverter.ToPngAsync(ms, token);`
`125`	`126`	`if (pngData != null)`
`126`	`127`	`{`
`127`	`128`	`var path = hostCachePath;`
	`129`	`+ var tmp = path + "." + Guid.NewGuid().ToString("N") + ".tmp";`
`128`	`130`	`try`
`129`	`131`	`{`
`130`		`- await File.WriteAllBytesAsync(path, pngData, token);`
	`132`	`+ await File.WriteAllBytesAsync(tmp, pngData, token);`
	`133`	`+ try { File.Move(tmp, path, overwrite: false); }`
	`134`	`+ catch (IOException)`
	`135`	`+ {`
	`136`	`+ // Another thread may have created it concurrently.`
	`137`	`+ }`
`131`	`138`	`}`
`132`		`- catch (IOException)`
	`139`	`+ finally`
`133`	`140`	`{`
`134`		`- // Another thread may have created it concurrently.`
	`141`	`+ try { if (File.Exists(tmp)) File.Delete(tmp); } catch { /* best effort */ }`
`135`	`142`	`}`
`136`	`143`	`if (File.Exists(path))`
`137`	`144`	`{`