Merge pull request #2559 from Flow-Launcher/fix-settings-not-loading

VictoriousRaptor · web-flow · commit 492771c1bbe9 · 2024-02-11T15:51:07.000+08:00
Remove short circuit check for empty Settings
diff --git a/Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs b/Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs
@@ -37,7 +37,7 @@ public async Task InitializeAsync()
             _storage = new JsonStorage<ConcurrentDictionary<string, object>>(SettingPath);
             Settings = await _storage.LoadAsync();
 
-            if (Settings != null || Configuration == null)
+            if (Configuration == null)
             {
                 return;
             }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public async Task InitializeAsync()`
`37`	`37`	`_storage = new JsonStorage<ConcurrentDictionary<string, object>>(SettingPath);`
`38`	`38`	`Settings = await _storage.LoadAsync();`
`39`	`39`
`40`		`- if (Settings != null \|\| Configuration == null)`
	`40`	`+ if (Configuration == null)`
`41`	`41`	`{`
`42`	`42`	`return;`
`43`	`43`	`}`