Skip to content

Commit 51df66e

Browse files
authored
Merge pull request #3976 from dcog989/logging-enhanced
Enhanced logging
2 parents 0e0ef0e + c2fcf64 commit 51df66e

File tree

3 files changed

+22
-22
lines changed

3 files changed

+22
-22
lines changed

Flow.Launcher.Infrastructure/Logger/Log.cs

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ static Log()
3434

3535
var fileTarget = new FileTarget
3636
{
37-
FileName = CurrentLogDirectory.Replace(@"\", "/") + "/${shortdate}.txt",
37+
FileName = CurrentLogDirectory.Replace(@"\", "/") + "/Flow.Launcher.${date:format=yyyy-MM-dd}.log",
3838
Layout = layout
3939
};
4040

@@ -65,26 +65,22 @@ static Log()
6565

6666
public static void SetLogLevel(LOGLEVEL level)
6767
{
68-
switch (level)
68+
var rule = LogManager.Configuration.FindRuleByName("file");
69+
70+
var nlogLevel = level switch
6971
{
70-
case LOGLEVEL.DEBUG:
71-
UseDebugLogLevel();
72-
break;
73-
default:
74-
UseInfoLogLevel();
75-
break;
76-
}
77-
Info(nameof(Logger), $"Using log level: {level}.");
78-
}
72+
LOGLEVEL.NONE => LogLevel.Off,
73+
LOGLEVEL.ERROR => LogLevel.Error,
74+
LOGLEVEL.DEBUG => LogLevel.Debug,
75+
_ => LogLevel.Info
76+
};
7977

80-
private static void UseDebugLogLevel()
81-
{
82-
LogManager.Configuration.FindRuleByName("file").SetLoggingLevels(LogLevel.Debug, LogLevel.Fatal);
83-
}
78+
rule.SetLoggingLevels(nlogLevel, LogLevel.Fatal);
8479

85-
private static void UseInfoLogLevel()
86-
{
87-
LogManager.Configuration.FindRuleByName("file").SetLoggingLevels(LogLevel.Info, LogLevel.Fatal);
80+
LogManager.ReconfigExistingLoggers();
81+
82+
// We can't log Info when level is set to Error or None, so we use Debug
83+
Debug(nameof(Logger), $"Using log level: {level}.");
8884
}
8985

9086
private static void LogFaultyFormat(string message)
@@ -169,7 +165,9 @@ public static void Warn(string className, string message, [CallerMemberName] str
169165

170166
public enum LOGLEVEL
171167
{
172-
DEBUG,
173-
INFO
168+
NONE,
169+
ERROR,
170+
INFO,
171+
DEBUG
174172
}
175173
}

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System.Collections.Generic;
1+
using System.Collections.Generic;
22
using System.Collections.ObjectModel;
33
using System.Text.Json.Serialization;
44
using System.Windows;

Flow.Launcher/Languages/en.xaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,8 +462,10 @@
462462
<system:String x:Key="userdatapathButton">Open Folder</system:String>
463463
<system:String x:Key="advanced">Advanced</system:String>
464464
<system:String x:Key="logLevel">Log Level</system:String>
465-
<system:String x:Key="LogLevelDEBUG">Debug</system:String>
465+
<system:String x:Key="LogLevelNONE">Silent</system:String>
466+
<system:String x:Key="LogLevelERROR">Error</system:String>
466467
<system:String x:Key="LogLevelINFO">Info</system:String>
468+
<system:String x:Key="LogLevelDEBUG">Debug</system:String>
467469
<system:String x:Key="settingWindowFontTitle">Setting Window Font</system:String>
468470

469471
<!-- Release Notes Window -->

0 commit comments

Comments
 (0)