Only dispose in dispose function

Jack251970 · Jack251970 · commit 53b3b7fe908d · 2025-06-28T12:47:07.000+08:00
diff --git a/Flow.Launcher.Infrastructure/QuickSwitch/QuickSwitch.cs b/Flow.Launcher.Infrastructure/QuickSwitch/QuickSwitch.cs
@@ -175,7 +175,6 @@ public static void SetupQuickSwitch(bool enabled)
                 // Remove explorer windows
                 foreach (var explorer in _quickSwitchExplorers.Keys)
                 {
-                    _quickSwitchExplorers[explorer]?.Dispose();
                     _quickSwitchExplorers[explorer] = null;
                 }
 
@@ -191,7 +190,6 @@ public static void SetupQuickSwitch(bool enabled)
                 {
                     if (_dialogWindow != null)
                     {
-                        _dialogWindow.Dispose();
                         _dialogWindow = null;
                         dialogWindowExists = true;
                     }
@@ -247,7 +245,6 @@ private static bool RefreshLastExplorer()
                         var explorerWindow = explorer.CheckExplorerWindow(hWnd);
                         if (explorerWindow != null)
                         {
-                            _quickSwitchExplorers[explorer]?.Dispose();
                             _quickSwitchExplorers[explorer] = explorerWindow;
                             _lastExplorer = explorer;
                             found = true;
@@ -503,7 +500,6 @@ uint dwmsEventTime
                                 if (explorerWindow != null)
                                 {
                                     Log.Debug(ClassName, $"Explorer window: {hwnd}");
-                                    _quickSwitchExplorers[explorer]?.Dispose();
                                     _quickSwitchExplorers[explorer] = explorerWindow;
                                     _lastExplorer = explorer;
                                     break;

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,6 @@ public static void SetupQuickSwitch(bool enabled)`
`175`	`175`	`// Remove explorer windows`
`176`	`176`	`foreach (var explorer in _quickSwitchExplorers.Keys)`
`177`	`177`	`{`
`178`		`- _quickSwitchExplorers[explorer]?.Dispose();`
`179`	`178`	`_quickSwitchExplorers[explorer] = null;`
`180`	`179`	`}`
`181`	`180`
`@@ -191,7 +190,6 @@ public static void SetupQuickSwitch(bool enabled)`
`191`	`190`	`{`
`192`	`191`	`if (_dialogWindow != null)`
`193`	`192`	`{`
`194`		`- _dialogWindow.Dispose();`
`195`	`193`	`_dialogWindow = null;`
`196`	`194`	`dialogWindowExists = true;`
`197`	`195`	`}`
`@@ -247,7 +245,6 @@ private static bool RefreshLastExplorer()`
`247`	`245`	`var explorerWindow = explorer.CheckExplorerWindow(hWnd);`
`248`	`246`	`if (explorerWindow != null)`
`249`	`247`	`{`
`250`		`- _quickSwitchExplorers[explorer]?.Dispose();`
`251`	`248`	`_quickSwitchExplorers[explorer] = explorerWindow;`
`252`	`249`	`_lastExplorer = explorer;`
`253`	`250`	`found = true;`
`@@ -503,7 +500,6 @@ uint dwmsEventTime`
`503`	`500`	`if (explorerWindow != null)`
`504`	`501`	`{`
`505`	`502`	`Log.Debug(ClassName, $"Explorer window: {hwnd}");`
`506`		`- _quickSwitchExplorers[explorer]?.Dispose();`
`507`	`503`	`_quickSwitchExplorers[explorer] = explorerWindow;`
`508`	`504`	`_lastExplorer = explorer;`
`509`	`505`	`break;`