Merge pull request #1635 from VictoriousRaptor/FixOpenWithEditorSpace

Fix Opening file path containing blanks with editor

Author: VictoriousRaptor

Plugins/Flow.Launcher.Plugin.Explorer/ContextMenu.cs

@@ -322,12 +322,17 @@ private Result CreateOpenWithEditorResult(SearchResult record)
                 {
                     try
                     {
-                        Process.Start(editorPath, record.FullPath);
+                        Process.Start(new ProcessStartInfo()
+                        {
+                            FileName = editorPath,
+                            ArgumentList = { record.FullPath }
+                        });
                         return true;
                     }
                     catch (Exception e)
                     {
-                        var message = $"Failed to open editor for file at {record.FullPath} with Editor {Path.GetFileNameWithoutExtension(editorPath)} at {editorPath}";
+                        var raw_message = Context.API.GetTranslation("plugin_explorer_openwitheditor_error");
+                        var message = string.Format(raw_message, record.FullPath, Path.GetFileNameWithoutExtension(editorPath), editorPath);
                         LogException(message, e);
                         Context.API.ShowMsgError(message);
                         return false;
@@ -358,7 +363,8 @@ private Result CreateOpenWithShellResult(SearchResult record)
                     }
                     catch (Exception e)
                     {
-                        var message = $"Failed to open editor for file at {record.FullPath} with Shell {Path.GetFileNameWithoutExtension(shellPath)} at {shellPath}";
+                        var raw_message = Context.API.GetTranslation("plugin_explorer_openwithshell_error");
+                        var message = string.Format(raw_message, record.FullPath, Path.GetFileNameWithoutExtension(shellPath), shellPath);
                         LogException(message, e);
                         Context.API.ShowMsgError(message);
                         return false;

Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml

@@ -71,7 +71,9 @@
     <system:String x:Key="plugin_explorer_opencontainingfolder">Open containing folder</system:String>
     <system:String x:Key="plugin_explorer_opencontainingfolder_subtitle">Opens the location that contains the file or folder</system:String>
     <system:String x:Key="plugin_explorer_openwitheditor">Open With Editor:</system:String>
+    <system:String x:Key="plugin_explorer_openwitheditor_error">Failed to open file at {0} with Editor {1} at {2}</system:String>
     <system:String x:Key="plugin_explorer_openwithshell">Open With Shell:</system:String>
+    <system:String x:Key="plugin_explorer_openwithshell_error">Failed to open folder {0} with Shell {1} at {2}</system:String>
     <system:String x:Key="plugin_explorer_excludefromindexsearch">Exclude current and sub-directories from Index Search</system:String>
     <system:String x:Key="plugin_explorer_excludedfromindexsearch_msg">Excluded from Index Search</system:String>
     <system:String x:Key="plugin_explorer_openindexingoptions">Open Windows Indexing Options</system:String>
@@ -88,7 +90,7 @@
     <system:String x:Key="plugin_explorer_remove_from_quickaccess_title">Remove from Quick Access</system:String>
     <system:String x:Key="plugin_explorer_remove_from_quickaccess_subtitle">Remove the current {0} from Quick Access</system:String>
     <system:String x:Key="plugin_explorer_show_contextmenu_title">Show Windows Context Menu</system:String>
-
+    
     <!--  Everything  -->
     <system:String x:Key="flowlauncher_plugin_everything_sdk_issue">Everything SDK Loaded Fail</system:String>
     <system:String x:Key="flowlauncher_plugin_everything_is_not_running">Warning: Everything service is not running</system:String>

Plugins/Flow.Launcher.Plugin.Explorer/plugin.json

@@ -10,7 +10,7 @@
   "Name": "Explorer",
   "Description": "Search and manage files and folders. Explorer utilises Windows Index Search",
   "Author": "Jeremy Wu",
-  "Version": "2.0.0",
+  "Version": "2.0.1",
   "Language": "csharp",
   "Website": "https://github.com/Flow-Launcher/Flow.Launcher",
   "ExecuteFileName": "Flow.Launcher.Plugin.Explorer.dll",