Have QuerySuggection converter handle suggestions

Author: Garulf

Flow.Launcher/Converters/QuerySuggestionBoxConverter.cs

@@ -44,6 +44,12 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
                     return string.Empty;
 
                 // When user typed lower case and result title is uppercase, we still want to display suggestion
+
+                string _suggestion = queryText + selectedResultPossibleSuggestion.Substring(queryText.Length);
+                if (String.IsNullOrEmpty(selectedResult.SuggestionText))
+                {
+                    selectedItem.Result.SuggestionText = _suggestion;
+                }
                 return queryText + selectedResultPossibleSuggestion.Substring(queryText.Length);
             }
             catch (Exception e)

Flow.Launcher/MainWindow.xaml

@@ -41,6 +41,13 @@
         <KeyBinding Key="Escape" Command="{Binding EscCommand}" />
         <KeyBinding Key="F1" Command="{Binding StartHelpCommand}" />
         <KeyBinding Key="F5" Command="{Binding ReloadPluginDataCommand}" />
+        <KeyBinding
+            Key="Tab"
+            Command="{Binding InsertSuggestion}"/>
+        <KeyBinding
+            Key="Tab"
+            Command="{Binding InsertSuggestion}"
+            Modifiers="Shift" />
         <KeyBinding
             Key="I"
             Command="{Binding OpenSettingCommand}"

Flow.Launcher/MainWindow.xaml.cs

@@ -469,10 +469,6 @@ private void OnKeyDown(object sender, KeyEventArgs e)
                         e.Handled = true;
                     }
                     break;
-                case Key.Tab:
-                    _viewModel.InsertSuggestion(QueryTextSuggestionBox.Text);
-                    e.Handled = true;
-                    break;
                 default:
                     break;
 

Flow.Launcher/ViewModel/MainViewModel.cs

@@ -228,6 +228,24 @@ private void InitializeKeyCommands()
                 }
             });
 
+            InsertSuggestion = new RelayCommand(_ =>
+            {
+                var results = SelectedResults;
+
+                var result = results.SelectedItem?.Result;
+                if (result != null) // SelectedItem returns null if selection is empty.
+                {
+                    string _newText = String.IsNullOrEmpty(result.SuggestionText) ? result.Title : result.SuggestionText;
+
+                    var SpecialKeyState = GlobalHotkey.Instance.CheckModifiers();
+                    if (SpecialKeyState.ShiftPressed)
+                    {
+                        _newText = result.SubTitle;
+                    }
+                    ChangeQueryText(_newText);
+                }
+            });
+
             LoadContextMenuCommand = new RelayCommand(_ =>
             {
                 if (SelectedIsFromQueryResults())
@@ -315,24 +333,7 @@ public void ChangeQueryText(string queryText, bool reQuery = false)
             }
             QueryTextCursorMovedToEnd = true;
         }
-        public void InsertSuggestion(string suggestion)
-        {
-            var results = SelectedResults;
-
-            var result = results.SelectedItem?.Result;
-            if (result != null) // SelectedItem returns null if selection is empty.
-            {
-                suggestion = String.IsNullOrEmpty(suggestion) ? result.Title : suggestion;
-                string _newText = String.IsNullOrEmpty(result.SuggestionText) ? suggestion : result.SuggestionText;
 
-                var SpecialKeyState = GlobalHotkey.Instance.CheckModifiers();
-                if (SpecialKeyState.ShiftPressed)
-                {
-                    _newText = result.SubTitle;
-                }
-                ChangeQueryText(_newText);
-            }
-        }
         public bool LastQuerySelected { get; set; }
 
         // This is not a reliable indicator of the cursor's position, it is manually set for a specific purpose.
@@ -399,7 +400,7 @@ private ResultsViewModel SelectedResults
         public ICommand OpenSettingCommand { get; set; }
         public ICommand ReloadPluginDataCommand { get; set; }
         public ICommand ClearQueryCommand { get; private set; }
-        public ICommand ReplaceQueryWithResult { get; set; }
+        public ICommand InsertSuggestion { get; set; }
 
         public string OpenResultCommandModifiers { get; private set; }