Skip to content

Commit 5f8d47c

Browse files
authored
Merge pull request #2730 from Flow-Launcher/fix-localization-for-toggleswitch-in-settings-general-pane
Fix ToggleSwitch localization in settings
2 parents aad9fdc + cc9656c commit 5f8d47c

File tree

3 files changed

+51
-16
lines changed

3 files changed

+51
-16
lines changed

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Lines changed: 42 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,31 @@
3030
TextAlignment="left" />
3131

3232
<cc:Card Title="{DynamicResource startFlowLauncherOnSystemStartup}" Icon="&#xe8fc;">
33-
<ui:ToggleSwitch IsOn="{Binding StartFlowLauncherOnSystemStartup}" />
33+
<ui:ToggleSwitch
34+
IsOn="{Binding StartFlowLauncherOnSystemStartup}"
35+
OffContent="{DynamicResource disable}"
36+
OnContent="{DynamicResource enable}" />
3437
</cc:Card>
3538

3639
<cc:Card Title="{DynamicResource hideOnStartup}" Icon="&#xed1a;">
37-
<ui:ToggleSwitch IsOn="{Binding Settings.HideOnStartup}" />
40+
<ui:ToggleSwitch
41+
IsOn="{Binding Settings.HideOnStartup}"
42+
OffContent="{DynamicResource disable}"
43+
OnContent="{DynamicResource enable}" />
3844
</cc:Card>
3945

4046
<cc:Card Title="{DynamicResource hideFlowLauncherWhenLoseFocus}" Margin="0 30 0 0">
41-
<ui:ToggleSwitch IsOn="{Binding Settings.HideWhenDeactivated}" />
47+
<ui:ToggleSwitch
48+
IsOn="{Binding Settings.HideWhenDeactivated}"
49+
OffContent="{DynamicResource disable}"
50+
OnContent="{DynamicResource enable}" />
4251
</cc:Card>
4352

4453
<cc:Card Title="{DynamicResource hideNotifyIcon}" Sub="{DynamicResource hideNotifyIconToolTip}">
45-
<ui:ToggleSwitch IsOn="{Binding Settings.HideNotifyIcon}" />
54+
<ui:ToggleSwitch
55+
IsOn="{Binding Settings.HideNotifyIcon}"
56+
OffContent="{DynamicResource disable}"
57+
OnContent="{DynamicResource enable}" />
4658
</cc:Card>
4759

4860
<cc:CardGroup Margin="0 30 0 0">
@@ -107,29 +119,42 @@
107119
Title="{DynamicResource ignoreHotkeysOnFullscreen}"
108120
Icon="&#xe7fc;"
109121
Sub="{DynamicResource ignoreHotkeysOnFullscreenToolTip}">
110-
<ui:ToggleSwitch IsOn="{Binding Settings.IgnoreHotkeysOnFullscreen}" />
122+
<ui:ToggleSwitch
123+
IsOn="{Binding Settings.IgnoreHotkeysOnFullscreen}"
124+
OffContent="{DynamicResource disable}"
125+
OnContent="{DynamicResource enable}" />
111126
</cc:Card>
112127

113128
<cc:Card
114129
Title="{DynamicResource AlwaysPreview}"
115130
Margin="0 30 0 0"
116131
Icon="&#xe8a1;"
117132
Sub="{DynamicResource AlwaysPreviewToolTip}">
118-
<ui:ToggleSwitch IsOn="{Binding Settings.AlwaysPreview}" ToolTip="{Binding AlwaysPreviewToolTip}" />
133+
<ui:ToggleSwitch
134+
IsOn="{Binding Settings.AlwaysPreview}"
135+
OffContent="{DynamicResource disable}"
136+
OnContent="{DynamicResource enable}"
137+
ToolTip="{Binding AlwaysPreviewToolTip}" />
119138
</cc:Card>
120139

121140
<cc:Card
122141
Title="{DynamicResource autoUpdates}"
123142
Margin="0 30 0 0"
124143
Icon="&#xecc5;">
125-
<ui:ToggleSwitch IsOn="{Binding AutoUpdates}" />
144+
<ui:ToggleSwitch
145+
IsOn="{Binding AutoUpdates}"
146+
OffContent="{DynamicResource disable}"
147+
OnContent="{DynamicResource enable}" />
126148
</cc:Card>
127149

128150
<cc:Card
129151
Title="{DynamicResource portableMode}"
130152
Icon="&#xe88e;"
131153
Sub="{DynamicResource portableModeToolTIp}">
132-
<ui:ToggleSwitch IsOn="{Binding PortableMode}" />
154+
<ui:ToggleSwitch
155+
IsOn="{Binding PortableMode}"
156+
OffContent="{DynamicResource disable}"
157+
OnContent="{DynamicResource enable}" />
133158
</cc:Card>
134159

135160
<cc:CardGroup Margin="0 30 0 0">
@@ -216,15 +241,21 @@
216241
Margin="0 30 0 0"
217242
Icon="&#xe8d3;"
218243
Sub="{DynamicResource typingStartEnTooltip}">
219-
<ui:ToggleSwitch IsOn="{Binding Settings.AlwaysStartEn}" />
244+
<ui:ToggleSwitch
245+
IsOn="{Binding Settings.AlwaysStartEn}"
246+
OffContent="{DynamicResource disable}"
247+
OnContent="{DynamicResource enable}" />
220248
</cc:Card>
221249

222250
<cc:Card
223251
Title="{DynamicResource ShouldUsePinyin}"
224252
Icon="&#xe98a;"
225253
Sub="{DynamicResource ShouldUsePinyinToolTip}">
226-
<ui:ToggleSwitch IsOn="{Binding Settings.ShouldUsePinyin}"
227-
ToolTip="{DynamicResource ShouldUsePinyinToolTip}" />
254+
<ui:ToggleSwitch
255+
IsOn="{Binding Settings.ShouldUsePinyin}"
256+
OffContent="{DynamicResource disable}"
257+
OnContent="{DynamicResource enable}"
258+
ToolTip="{DynamicResource ShouldUsePinyinToolTip}" />
228259
</cc:Card>
229260

230261
<cc:Card

Flow.Launcher/SettingPages/Views/SettingsPaneHotkey.xaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,11 @@
6363
SelectedValue="{Binding Settings.OpenResultModifiers}" />
6464
</cc:Card>
6565

66-
<cc:Card
67-
Title="{DynamicResource showOpenResultHotkey}"
68-
Sub="{DynamicResource showOpenResultHotkeyToolTip}">
69-
<ui:ToggleSwitch IsOn="{Binding Settings.ShowOpenResultHotkey}" />
66+
<cc:Card Title="{DynamicResource showOpenResultHotkey}" Sub="{DynamicResource showOpenResultHotkeyToolTip}">
67+
<ui:ToggleSwitch
68+
IsOn="{Binding Settings.ShowOpenResultHotkey}"
69+
OffContent="{DynamicResource disable}"
70+
OnContent="{DynamicResource enable}" />
7071
</cc:Card>
7172
</cc:CardGroup>
7273

Flow.Launcher/SettingPages/Views/SettingsPaneProxy.xaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@
3333

3434
<cc:CardGroup>
3535
<cc:Card Title="{DynamicResource enableProxy}">
36-
<ui:ToggleSwitch IsOn="{Binding Settings.Proxy.Enabled}" />
36+
<ui:ToggleSwitch
37+
IsOn="{Binding Settings.Proxy.Enabled}"
38+
OffContent="{DynamicResource disable}"
39+
OnContent="{DynamicResource enable}" />
3740
</cc:Card>
3841

3942
<cc:Card Title="{DynamicResource server}">

0 commit comments

Comments
 (0)