add abstract create plugin pair method to handle each plugin type

Author: jjw24

Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs

@@ -112,20 +112,16 @@ private void EnsureLatestInstalled(string expectedPath, string currentPath, stri
 
         }
 
+        internal abstract PluginPair CreatePluginPair(string filePath, PluginMetadata metadata);
+
         private IEnumerable<PluginPair> SetPathForPluginPairs(string filePath, string languageToSet)
         {
             var pluginPairs = new List<PluginPair>();
 
             foreach (var metadata in PluginMetadataList)
             {
                 if (metadata.Language.Equals(languageToSet, StringComparison.OrdinalIgnoreCase))
-                {
-                    pluginPairs.Add(new PluginPair
-                    {
-                        Plugin = new PythonPlugin(filePath),
-                        Metadata = metadata
-                    });
-                }
+                    pluginPairs.Add(CreatePluginPair(filePath, metadata));
             }
 
             return pluginPairs;

Flow.Launcher.Core/ExternalPlugins/Environments/PythonEnvironment.cs

@@ -1,4 +1,5 @@
 using Droplex;
+using Flow.Launcher.Core.Plugin;
 using Flow.Launcher.Infrastructure.UserSettings;
 using Flow.Launcher.Plugin;
 using Flow.Launcher.Plugin.SharedCommands;
@@ -34,5 +35,14 @@ internal override void InstallEnvironment()
 
             PluginsSettingsFilePath = ExecutablePath;
         }
+
+        internal override PluginPair CreatePluginPair(string filePath, PluginMetadata metadata)
+        {
+            return new PluginPair
+            {
+                Plugin = new PythonPlugin(filePath),
+                Metadata = metadata
+            };
+        }
     }
 }

Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptEnvironment.cs

@@ -4,6 +4,7 @@
 using Flow.Launcher.Plugin.SharedCommands;
 using Flow.Launcher.Plugin;
 using System.IO;
+using Flow.Launcher.Core.Plugin;
 
 namespace Flow.Launcher.Core.ExternalPlugins.Environments
 {
@@ -30,5 +31,14 @@ internal override void InstallEnvironment()
 
             PluginsSettingsFilePath = ExecutablePath;
         }
+
+        internal override PluginPair CreatePluginPair(string filePath, PluginMetadata metadata)
+        {
+            return new PluginPair
+            {
+                Plugin = new NodePlugin(filePath),
+                Metadata = metadata
+            };
+        }
     }
 }

Flow.Launcher.Core/Plugin/NodePlugin.cs

@@ -17,7 +17,6 @@ internal class NodePlugin : JsonRPCPlugin
     {
         private readonly ProcessStartInfo _startInfo;
 
-        // TODO: Remove all, not used
         public override string SupportedLanguage { get; set; } = AllowedLanguage.Executable;
 
         public NodePlugin(string filename)
@@ -39,9 +38,7 @@ protected override Task<Stream> RequestAsync(JsonRPCRequestModel request, Cancel
         }
 
         protected override string Request(JsonRPCRequestModel rpcRequest, CancellationToken token = default)
-        { 
-            // CONTEXT MENU NOT WORKING ??
-            
+        {
             // since this is not static, request strings will build up in ArgumentList if index is not specified
             _startInfo.ArgumentList[1] = rpcRequest.ToString();
             return Execute(_startInfo);