Use ValueTask as return value to suppress potential image error

taooceros · taooceros · commit 710d2a89a2f8 · 2021-07-31T16:15:49.000+08:00
diff --git a/Flow.Launcher/ViewModel/ResultViewModel.cs b/Flow.Launcher/ViewModel/ResultViewModel.cs
@@ -35,7 +35,7 @@ public ResultViewModel(Result result, Settings settings)
                                                 ? Result.SubTitle
                                                 : Result.SubTitleToolTip;
 
-        private bool ImageLoaded;
+        private volatile bool ImageLoaded;
 
         private ImageSource image = ImageLoader.DefaultImage;
 
@@ -46,13 +46,13 @@ public ImageSource Image
                 if (!ImageLoaded)
                 {
                     ImageLoaded = true;
-                    LoadImage();
+                    _ = LoadImageAsync();
                 }
                 return image;
             }
             private set => image = value;
         }
-        private async void LoadImage()
+        private async ValueTask LoadImageAsync()
         {
             var imagePath = Result.IcoPath;
             if (string.IsNullOrEmpty(imagePath) && Result.Icon != null)

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public ResultViewModel(Result result, Settings settings)`
`35`	`35`	`? Result.SubTitle`
`36`	`36`	`: Result.SubTitleToolTip;`
`37`	`37`
`38`		`- private bool ImageLoaded;`
	`38`	`+ private volatile bool ImageLoaded;`
`39`	`39`
`40`	`40`	`private ImageSource image = ImageLoader.DefaultImage;`
`41`	`41`
`@@ -46,13 +46,13 @@ public ImageSource Image`
`46`	`46`	`if (!ImageLoaded)`
`47`	`47`	`{`
`48`	`48`	`ImageLoaded = true;`
`49`		`- LoadImage();`
	`49`	`+ _ = LoadImageAsync();`
`50`	`50`	`}`
`51`	`51`	`return image;`
`52`	`52`	`}`
`53`	`53`	`private set => image = value;`
`54`	`54`	`}`
`55`		`- private async void LoadImage()`
	`55`	`+ private async ValueTask LoadImageAsync()`
`56`	`56`	`{`
`57`	`57`	`var imagePath = Result.IcoPath;`
`58`	`58`	`if (string.IsNullOrEmpty(imagePath) && Result.Icon != null)`