Use System.Version to compare versions

Peter de Vroom · Peter de Vroom · commit 770eec529658 · 2025-07-07T14:07:47.000+10:00
Add error checking
diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -550,8 +550,12 @@ private static string GetContainingFolderPathAfterUnzip(string unzippedParentFol
         private static bool SameOrLesserPluginVersionExists(string metadataPath)
         {
             var newMetadata = JsonSerializer.Deserialize<PluginMetadata>(File.ReadAllText(metadataPath));
+            if (!Version.TryParse(newMetadata.Version, out var newVersion))
+                throw new InvalidOperationException($"A plugin with the same ID and version already exists, or the version is greater than this downloaded plugin {plugin.Name}");
+
             return AllPlugins.Any(x => x.Metadata.ID == newMetadata.ID
-                          && newMetadata.Version.CompareTo(x.Metadata.Version) <= 0);
+                                       && Version.TryParse(x.Metadata.Version, out var version)
+                                       && newVersion <= version);
         }
 
         #region Public functions

Original file line number	Diff line number	Diff line change
`@@ -550,8 +550,12 @@ private static string GetContainingFolderPathAfterUnzip(string unzippedParentFol`
`550`	`550`	`private static bool SameOrLesserPluginVersionExists(string metadataPath)`
`551`	`551`	`{`
`552`	`552`	`var newMetadata = JsonSerializer.Deserialize<PluginMetadata>(File.ReadAllText(metadataPath));`
	`553`	`+ if (!Version.TryParse(newMetadata.Version, out var newVersion))`
	`554`	`+ throw new InvalidOperationException($"A plugin with the same ID and version already exists, or the version is greater than this downloaded plugin {plugin.Name}");`
	`555`	`+`
`553`	`556`	`return AllPlugins.Any(x => x.Metadata.ID == newMetadata.ID`
`554`		`- && newMetadata.Version.CompareTo(x.Metadata.Version) <= 0);`
	`557`	`+ && Version.TryParse(x.Metadata.Version, out var version)`
	`558`	`+ && newVersion <= version);`
`555`	`559`	`}`
`556`	`560`
`557`	`561`	`#region Public functions`