Skip to content

Commit 78f3008

Browse files
authored
Merge pull request #951 from Flow-Launcher/fix_browser_l10n_warnings
Fix incorrect text for "New Tab" and "New Window" buttons
2 parents 8d71b43 + 21775c7 commit 78f3008

File tree

9 files changed

+15
-15
lines changed

9 files changed

+15
-15
lines changed

Flow.Launcher/Languages/en.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@
176176
<system:String x:Key="defaultBrowser_name">Browser</system:String>
177177
<system:String x:Key="defaultBrowser_profile_name">Browser Name</system:String>
178178
<system:String x:Key="defaultBrowser_path">Browser Path</system:String>
179-
<system:String x:Key="defaultBrowser_newtab">New Window</system:String>
180-
<system:String x:Key="defaultBrowser_newWindow">New Tab</system:String>
179+
<system:String x:Key="defaultBrowser_newWindow">New Window</system:String>
180+
<system:String x:Key="defaultBrowser_newTab">New Tab</system:String>
181181
<system:String x:Key="defaultBrowser_parameter">Private Mode</system:String>
182182

183183
<!-- Priority Setting Dialog -->

Flow.Launcher/Languages/ko.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@
175175
<system:String x:Key="defaultBrowser_name">브라우저</system:String>
176176
<system:String x:Key="defaultBrowser_profile_name">브라우저 이름</system:String>
177177
<system:String x:Key="defaultBrowser_path">브라우저 경로</system:String>
178-
<system:String x:Key="defaultBrowser_newtab">새 창</system:String>
179-
<system:String x:Key="defaultBrowser_newWindow">새 탭</system:String>
178+
<system:String x:Key="defaultBrowser_newWindow">새 창</system:String>
179+
<system:String x:Key="defaultBrowser_newTab">새 탭</system:String>
180180
<system:String x:Key="defaultBrowser_parameter">프라이빗 모드</system:String>
181181

182182
<!-- Priority Setting Dialog -->

Flow.Launcher/Languages/pt-pt.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@
176176
<system:String x:Key="defaultBrowser_name">Navegador</system:String>
177177
<system:String x:Key="defaultBrowser_profile_name">Nome do navegador</system:String>
178178
<system:String x:Key="defaultBrowser_path">Caminho do navegador</system:String>
179-
<system:String x:Key="defaultBrowser_newtab">Nova janela</system:String>
180-
<system:String x:Key="defaultBrowser_newWindow">Novo separador</system:String>
179+
<system:String x:Key="defaultBrowser_newWindow">Nova janela</system:String>
180+
<system:String x:Key="defaultBrowser_newTab">Novo separador</system:String>
181181
<system:String x:Key="defaultBrowser_parameter">Modo privado</system:String>
182182

183183
<!-- Priority Setting Dialog -->

Flow.Launcher/Languages/sk.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,8 @@
174174
<system:String x:Key="defaultBrowser_name">Prehliadač</system:String>
175175
<system:String x:Key="defaultBrowser_profile_name">Názov prehliadača</system:String>
176176
<system:String x:Key="defaultBrowser_path">Cesta k prehliadaču</system:String>
177-
<system:String x:Key="defaultBrowser_newtab">Nové okno</system:String>
178-
<system:String x:Key="defaultBrowser_newWindow">Nová karta</system:String>
177+
<system:String x:Key="defaultBrowser_newWindow">Nové okno</system:String>
178+
<system:String x:Key="defaultBrowser_newTab">Nová karta</system:String>
179179
<system:String x:Key="defaultBrowser_parameter">Privátny režim</system:String>
180180

181181
<!-- Priority Setting Dialog -->

Flow.Launcher/ReportWindow.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ private Paragraph Hyperlink(string textBeforeUrl, string url)
5252
var link = new Hyperlink { IsEnabled = true };
5353
link.Inlines.Add(url);
5454
link.NavigateUri = new Uri(url);
55-
link.RequestNavigate += (s, e) => SearchWeb.NewTabInBrowser(e.Uri.ToString());
56-
link.Click += (s, e) => SearchWeb.NewTabInBrowser(url);
55+
link.RequestNavigate += (s, e) => SearchWeb.OpenInBrowserTab(e.Uri.ToString());
56+
link.Click += (s, e) => SearchWeb.OpenInBrowserTab(url);
5757

5858
paragraph.Inlines.Add(textBeforeUrl);
5959
paragraph.Inlines.Add(link);

Flow.Launcher/SelectBrowserWindow.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@
196196
VerticalAlignment="Center"
197197
Orientation="Horizontal">
198198
<RadioButton IsChecked="{Binding OpenInTab}"
199-
Content="{DynamicResource defaultBrowser_newWindow}"></RadioButton>
199+
Content="{DynamicResource defaultBrowser_newTab}"></RadioButton>
200200
<RadioButton IsChecked="{Binding OpenInNewWindow, Mode=OneTime}"
201201
Content="{DynamicResource defaultBrowser_newWindow}"></RadioButton>
202202
</StackPanel>

Flow.Launcher/SettingWindow.xaml.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ private void OnPluginNameClick(object sender, MouseButtonEventArgs e)
232232
var uri = new Uri(website);
233233
if (Uri.CheckSchemeName(uri.Scheme))
234234
{
235-
website.NewTabInBrowser();
235+
website.OpenInBrowserTab();
236236
}
237237
}
238238
}

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ internal List<Result> InstallFromWeb(string url)
333333
{
334334
if (e.SpecialKeyState.CtrlPressed)
335335
{
336-
SearchWeb.NewTabInBrowser(plugin.UrlDownload);
336+
SearchWeb.OpenInBrowserTab(plugin.UrlDownload);
337337
return ShouldHideWindow;
338338
}
339339

@@ -397,7 +397,7 @@ internal async ValueTask<List<Result>> RequestInstallOrUpdate(string searchName,
397397
{
398398
if (e.SpecialKeyState.CtrlPressed)
399399
{
400-
SearchWeb.NewTabInBrowser(x.Website);
400+
SearchWeb.OpenInBrowserTab(x.Website);
401401
return ShouldHideWindow;
402402
}
403403

Plugins/Flow.Launcher.Plugin.PluginsManager/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"Name": "Plugins Manager",
77
"Description": "Management of installing, uninstalling or updating Flow Launcher plugins",
88
"Author": "Jeremy Wu",
9-
"Version": "1.11.1",
9+
"Version": "1.11.2",
1010
"Language": "csharp",
1111
"Website": "https://github.com/Flow-Launcher/Flow.Launcher",
1212
"ExecuteFileName": "Flow.Launcher.Plugin.PluginsManager.dll",

0 commit comments

Comments
 (0)