Merge pull request #2599 from Phoenix-/dev

Fix opera bookmarks

Author: VictoriousRaptor

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -33,20 +33,32 @@ protected List<Bookmark> LoadBookmarks(string browserDataPath, string name)
 
         protected List<Bookmark> LoadBookmarksFromFile(string path, string source)
         {
+            var bookmarks = new List<Bookmark>();
+
             if (!File.Exists(path))
-                return new List<Bookmark>();
+                return bookmarks;
 
-            var bookmarks = new List<Bookmark>();
             using var jsonDocument = JsonDocument.Parse(File.ReadAllText(path));
             if (!jsonDocument.RootElement.TryGetProperty("roots", out var rootElement))
-                return new List<Bookmark>();
+                return bookmarks;
+            EnumerateRoot(rootElement, bookmarks, source);
+            return bookmarks;
+        }
+
+        private void EnumerateRoot(JsonElement rootElement, ICollection<Bookmark> bookmarks, string source)
+        {
             foreach (var folder in rootElement.EnumerateObject())
             {
-                if (folder.Value.ValueKind == JsonValueKind.Object)
+                if (folder.Value.ValueKind != JsonValueKind.Object)
+                    continue;
+
+                // Fix for Opera. It stores bookmarks slightly different than chrome. See PR and bug report for this change for details.
+                // If various exceptions start to build up here consider splitting this Loader into multiple separate ones.
+                if (folder.Name == "custom_root") 
+                    EnumerateRoot(folder.Value, bookmarks, source);
+                else
                     EnumerateFolderBookmark(folder.Value, bookmarks, source);
             }
-
-            return bookmarks;
         }
 
         private void EnumerateFolderBookmark(JsonElement folderElement, ICollection<Bookmark> bookmarks,