Refactor Bookmark plugin

Author: taooceros

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Bookmark.cs

@@ -7,50 +7,19 @@
 
 namespace Flow.Launcher.Plugin.BrowserBookmark
 {
-    public class Bookmark : IEquatable<Bookmark>, IEqualityComparer<Bookmark>
+    // Source may be important in the future
+    public record Bookmark(string Name, string Url, string Source = "")
     {
-        private string m_Name;
-        public string Name
-        {
-            get
-            {
-                return m_Name;
-            }
-            set
-            {
-                m_Name = value;
-            }
-        }
-        public string Url { get; set; }
-        public string Source { get; set; }
-        public int Score { get; set; }
-
-        /* TODO: since Source maybe unimportant, we just need to compare Name and Url */
-        public bool Equals(Bookmark other)
-        {
-            return Equals(this, other);
-        }
-
-        public bool Equals(Bookmark x, Bookmark y)
-        {
-            if (Object.ReferenceEquals(x, y)) return true;
-            if (Object.ReferenceEquals(x, null) || Object.ReferenceEquals(y, null))
-                return false;
-
-            return x.Name == y.Name && x.Url == y.Url;
-        }
-
-        public int GetHashCode(Bookmark bookmark)
+        public override int GetHashCode()
         {
-            if (Object.ReferenceEquals(bookmark, null)) return 0;
-            int hashName = bookmark.Name == null ? 0 : bookmark.Name.GetHashCode();
-            int hashUrl = bookmark.Url == null ? 0 : bookmark.Url.GetHashCode();
+            var hashName = Name?.GetHashCode() ?? 0;
+            var hashUrl = Url?.GetHashCode() ?? 0;
             return hashName ^ hashUrl;
         }
 
-        public override int GetHashCode()
+        public virtual bool Equals(Bookmark other)
         {
-            return GetHashCode(this);
+            return other != null && Name == other.Name && Url == other.Url;
         }
     }
-}
+}

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromeBookmarkLoader.cs

@@ -0,0 +1,26 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text.RegularExpressions;
+
+namespace Flow.Launcher.Plugin.BrowserBookmark
+{
+    public class ChromeBookmarkLoader : ChromiumBookmarkLoader
+    {
+        public override List<Bookmark> GetBookmarks()
+        {
+            return LoadChromeBookmarks();
+        }
+
+        private List<Bookmark> LoadChromeBookmarks()
+        {
+            var bookmarks = new List<Bookmark>();
+            String platformPath = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData);
+            bookmarks.AddRange(LoadBookmarks(Path.Combine(platformPath, @"Google\Chrome\User Data"), "Google Chrome"));
+            bookmarks.AddRange(LoadBookmarks(Path.Combine(platformPath, @"Google\Chrome SxS\User Data"), "Google Chrome Canary"));
+            bookmarks.AddRange(LoadBookmarks(Path.Combine(platformPath, @"Chromium\User Data"), "Chromium"));
+            return bookmarks;
+        }
+    }
+}

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromeBookmarks.cs

@@ -0,0 +1,62 @@
+using Microsoft.AspNetCore.Authentication;
+using System.Collections.Generic;
+using System.IO;
+using System.Text.Json;
+
+namespace Flow.Launcher.Plugin.BrowserBookmark
+{
+    public abstract class ChromiumBookmarkLoader : IBookmarkLoader
+    {
+        public abstract List<Bookmark> GetBookmarks();
+        protected List<Bookmark> LoadBookmarks(string browserDataPath, string name)
+        {
+            var bookmarks = new List<Bookmark>();
+            if (!Directory.Exists(browserDataPath)) return bookmarks;
+            var paths = Directory.GetDirectories(browserDataPath);
+
+            foreach (var profile in paths)
+            {
+                var bookmarkPath = Path.Combine(profile, "Bookmarks");
+                if (!File.Exists(bookmarkPath))
+                    continue;
+
+                var source = name + (Path.GetFileName(profile) == "Default" ? "" : $" ({Path.GetFileName(profile)})");
+                bookmarks.AddRange(LoadBookmarksFromFile(bookmarkPath, source));
+            }
+            return bookmarks;
+        }
+        
+        protected List<Bookmark> LoadBookmarksFromFile(string path, string source)
+        {
+            var bookmarks = new List<Bookmark>();
+            using var jsonDocument = JsonDocument.Parse(File.ReadAllText(path));
+            if (!jsonDocument.RootElement.TryGetProperty("roots", out var rootElement))
+                return new();
+            foreach (var folder in rootElement.EnumerateObject())
+            {
+                EnumerateFolderBookmark(folder.Value, bookmarks, source);
+            }
+            return bookmarks;
+        }
+
+        private void EnumerateFolderBookmark(JsonElement folderElement, List<Bookmark> bookmarks, string source)
+        {
+            foreach (var subElement in folderElement.GetProperty("children").EnumerateArray())
+            {
+                switch (subElement.GetProperty("type").GetString())
+                {
+                    case "folder":
+                        EnumerateFolderBookmark(subElement, bookmarks, source);
+                        break;
+                    default:
+                        bookmarks.Add(new Bookmark(
+                            subElement.GetProperty("name").GetString(),
+                            subElement.GetProperty("url").GetString(),
+                            source));
+                        break;
+                }
+            }
+
+        }
+    }
+}

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -20,9 +20,9 @@ internal static List<Bookmark> LoadAllBookmarks()
         {
             var allbookmarks = new List<Bookmark>();
 
-            var chromeBookmarks = new ChromeBookmarks();
-            var mozBookmarks = new FirefoxBookmarks();
-            var edgeBookmarks = new EdgeBookmarks();
+            var chromeBookmarks = new ChromeBookmarkLoader();
+            var mozBookmarks = new FirefoxBookmarkLoader();
+            var edgeBookmarks = new EdgeBookmarkLoader();
 
             //TODO: Let the user select which browser's bookmarks are displayed
             // Add Firefox bookmarks

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Commands/Bookmarks.cs

@@ -0,0 +1,30 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text.Json;
+using System.Text.RegularExpressions;
+
+namespace Flow.Launcher.Plugin.BrowserBookmark
+{
+    public class EdgeBookmarkLoader : ChromiumBookmarkLoader
+    {
+
+        private readonly List<Bookmark> _bookmarks = new();
+
+        private void LoadEdgeBookmarks()
+        {
+            var platformPath = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData);
+            LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge\User Data"), "Microsoft Edge");
+            LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge Dev\User Data"), "Microsoft Edge Dev");
+            LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge SxS\User Data"), "Microsoft Edge Canary");
+        }
+        
+        public override List<Bookmark> GetBookmarks()
+        {
+            _bookmarks.Clear();
+            LoadEdgeBookmarks();
+            return _bookmarks;
+        }
+    }
+}