Skip to content

Commit 88feed0

Browse files
authored
Merge pull request #1878 from VictoriousRaptor/PluginInstallNotification1
Show plugin names in download success notification
2 parents aa4f3a9 + 0c96304 commit 88feed0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
<!-- Dialogues -->
77
<system:String x:Key="plugin_pluginsmanager_downloading_plugin">Downloading plugin</system:String>
8-
<system:String x:Key="plugin_pluginsmanager_download_success">Successfully downloaded</system:String>
8+
<system:String x:Key="plugin_pluginsmanager_download_success">Successfully downloaded {0}</system:String>
99
<system:String x:Key="plugin_pluginsmanager_download_error">Error: Unable to download the plugin</system:String>
1010
<system:String x:Key="plugin_pluginsmanager_uninstall_prompt">{0} by {1} {2}{3}Would you like to uninstall this plugin? After the uninstallation Flow will automatically restart.</system:String>
1111
<system:String x:Key="plugin_pluginsmanager_install_prompt">{0} by {1} {2}{3}Would you like to install this plugin? After the installation Flow will automatically restart.</system:String>
1212
<system:String x:Key="plugin_pluginsmanager_install_title">Plugin Install</system:String>
1313
<system:String x:Key="plugin_pluginsmanager_installing_plugin">Installing Plugin</system:String>
1414
<system:String x:Key="plugin_pluginsmanager_install_from_web">Download and install {0}</system:String>
1515
<system:String x:Key="plugin_pluginsmanager_uninstall_title">Plugin Uninstall</system:String>
16-
<system:String x:Key="plugin_pluginsmanager_install_success_restart">Plugin successfully installed. Restarting Flow, please wait...</system:String>
16+
<system:String x:Key="plugin_pluginsmanager_install_success_restart">Plugin {0} successfully installed. Restarting Flow, please wait...</system:String>
1717
<system:String x:Key="plugin_pluginsmanager_install_errormetadatafile">Unable to find the plugin.json metadata file from the extracted zip file.</system:String>
1818
<system:String x:Key="plugin_pluginsmanager_install_error_duplicate">Error: A plugin which has the same or greater version with {0} already exists.</system:String>
1919
<system:String x:Key="plugin_pluginsmanager_install_error_title">Error installing plugin</system:String>

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
157157
await Http.DownloadAsync(plugin.UrlDownload, filePath).ConfigureAwait(false);
158158

159159
Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"),
160-
Context.API.GetTranslation("plugin_pluginsmanager_download_success"));
160+
string.Format(Context.API.GetTranslation("plugin_pluginsmanager_download_success"), plugin.Name));
161161

162162
Install(plugin, filePath);
163163
}
@@ -177,7 +177,7 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
177177
}
178178

179179
Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_installing_plugin"),
180-
Context.API.GetTranslation("plugin_pluginsmanager_install_success_restart"));
180+
string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_success_restart"), plugin.Name));
181181

182182
Context.API.RestartApp();
183183
}
@@ -245,7 +245,7 @@ await Http.DownloadAsync(x.PluginNewUserPlugin.UrlDownload, downloadToFilePath)
245245

246246
Context.API.ShowMsg(
247247
Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"),
248-
Context.API.GetTranslation("plugin_pluginsmanager_download_success"));
248+
string.Format(Context.API.GetTranslation("plugin_pluginsmanager_download_success"), x.Name));
249249

250250
Install(x.PluginNewUserPlugin, downloadToFilePath);
251251

0 commit comments

Comments
 (0)