Improve function names for code quality

Jack251970 · Jack251970 · commit 96305166e834 · 2025-02-24T19:55:48.000+08:00
diff --git a/Flow.Launcher/App.xaml.cs b/Flow.Launcher/App.xaml.cs
@@ -119,7 +119,14 @@ private void AutoStartup()
             {
                 try
                 {
-                    Helper.AutoStartup.Enable(_settings.UseLogonTaskForStartup);
+                    if (_settings.UseLogonTaskForStartup)
+                    {
+                        Helper.AutoStartup.EnableViaLogonTask();
+                    }
+                    else
+                    {
+                        Helper.AutoStartup.EnableViaRegistry();
+                    }
                 }
                 catch (Exception e)
                 {
diff --git a/Flow.Launcher/Helper/AutoStartup.cs b/Flow.Launcher/Helper/AutoStartup.cs
@@ -68,7 +68,35 @@ private static bool CheckLogonTask()
         return false;
     }
 
-    public static void Disable(bool logonTask)
+    public static void DisableViaLogonTaskAndRegistry()
+    {
+        Disable(true);
+        Disable(false);
+    }
+
+    public static void EnableViaLogonTask()
+    {
+        Enable(true);
+    }
+
+    public static void EnableViaRegistry()
+    {
+        Enable(false);
+    }
+
+    public static void ChangeToViaLogonTask()
+    {
+        Disable(false);
+        Enable(true);
+    }
+
+    public static void ChangeToViaRegistry()
+    {
+        Disable(true);
+        Enable(false);
+    }
+
+    private static void Disable(bool logonTask)
     {
         try
         {
@@ -89,7 +117,7 @@ public static void Disable(bool logonTask)
         }
     }
 
-    internal static void Enable(bool logonTask)
+    private static void Enable(bool logonTask)
     {
         try
         {
diff --git a/Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs b/Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs
@@ -43,14 +43,18 @@ public bool StartFlowLauncherOnSystemStartup
             {
                 if (value)
                 {
-                    // Enable either registry or task scheduler
-                    AutoStartup.Enable(UseLogonTaskForStartup);
+                    if (UseLogonTaskForStartup)
+                    {
+                        AutoStartup.EnableViaLogonTask();
+                    }
+                    else
+                    {
+                        AutoStartup.EnableViaRegistry();
+                    }
                 }
                 else
                 {
-                    // Disable both registry and task scheduler
-                    AutoStartup.Disable(true);
-                    AutoStartup.Disable(false);
+                    AutoStartup.DisableViaLogonTaskAndRegistry();
                 }  
             }
             catch (Exception e)
@@ -72,9 +76,14 @@ public bool UseLogonTaskForStartup
             {
                 try
                 {
-                    // Disable and enable to update the startup method
-                    AutoStartup.Disable(!UseLogonTaskForStartup);
-                    AutoStartup.Enable(UseLogonTaskForStartup);
+                    if (UseLogonTaskForStartup)
+                    {
+                        AutoStartup.ChangeToViaLogonTask();
+                    }
+                    else
+                    {
+                        AutoStartup.ChangeToViaRegistry();
+                    }
                 }
                 catch (Exception e)
                 {

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,14 @@ private void AutoStartup()`
`119`	`119`	`{`
`120`	`120`	`try`
`121`	`121`	`{`
`122`		`- Helper.AutoStartup.Enable(_settings.UseLogonTaskForStartup);`
	`122`	`+ if (_settings.UseLogonTaskForStartup)`
	`123`	`+ {`
	`124`	`+ Helper.AutoStartup.EnableViaLogonTask();`
	`125`	`+ }`
	`126`	`+ else`
	`127`	`+ {`
	`128`	`+ Helper.AutoStartup.EnableViaRegistry();`
	`129`	`+ }`
`123`	`130`	`}`
`124`	`131`	`catch (Exception e)`
`125`	`132`	`{`
Original file line number	Diff line number	Diff line change
`@@ -43,14 +43,18 @@ public bool StartFlowLauncherOnSystemStartup`
`43`	`43`	`{`
`44`	`44`	`if (value)`
`45`	`45`	`{`
`46`		`- // Enable either registry or task scheduler`
`47`		`- AutoStartup.Enable(UseLogonTaskForStartup);`
	`46`	`+ if (UseLogonTaskForStartup)`
	`47`	`+ {`
	`48`	`+ AutoStartup.EnableViaLogonTask();`
	`49`	`+ }`
	`50`	`+ else`
	`51`	`+ {`
	`52`	`+ AutoStartup.EnableViaRegistry();`
	`53`	`+ }`
`48`	`54`	`}`
`49`	`55`	`else`
`50`	`56`	`{`
`51`		`- // Disable both registry and task scheduler`
`52`		`- AutoStartup.Disable(true);`
`53`		`- AutoStartup.Disable(false);`
	`57`	`+ AutoStartup.DisableViaLogonTaskAndRegistry();`
`54`	`58`	`}`
`55`	`59`	`}`
`56`	`60`	`catch (Exception e)`
`@@ -72,9 +76,14 @@ public bool UseLogonTaskForStartup`
`72`	`76`	`{`
`73`	`77`	`try`
`74`	`78`	`{`
`75`		`- // Disable and enable to update the startup method`
`76`		`- AutoStartup.Disable(!UseLogonTaskForStartup);`
`77`		`- AutoStartup.Enable(UseLogonTaskForStartup);`
	`79`	`+ if (UseLogonTaskForStartup)`
	`80`	`+ {`
	`81`	`+ AutoStartup.ChangeToViaLogonTask();`
	`82`	`+ }`
	`83`	`+ else`
	`84`	`+ {`
	`85`	`+ AutoStartup.ChangeToViaRegistry();`
	`86`	`+ }`
`78`	`87`	`}`
`79`	`88`	`catch (Exception e)`
`80`	`89`	`{`