Skip to content

Commit a0773a6

Browse files
committed
Merge branch 'dev' into add_pluginsmanager_contextmenu
2 parents 88af302 + f61a727 commit a0773a6

File tree

3 files changed

+11
-21
lines changed

3 files changed

+11
-21
lines changed

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,11 @@
66
<system:String x:Key="plugin_pluginsmanager_downloading_plugin">Downloading plugin</system:String>
77
<system:String x:Key="plugin_pluginsmanager_please_wait">Please wait...</system:String>
88
<system:String x:Key="plugin_pluginsmanager_download_success">Successfully downloaded</system:String>
9-
<system:String x:Key="plugin_pluginsmanager_uninstall_prompt">Do you want to uninstall the following plugin?{0}{1}{2} by {3}</system:String>
10-
<system:String x:Key="plugin_pluginsmanager_install_prompt">Do you want to install the following plugin?{0}{1}{2} by {3}</system:String>
9+
<system:String x:Key="plugin_pluginsmanager_uninstall_prompt">{0} by {1} {2}{3}Would you like to uninstall this plugin? After the uninstallation Flow will automatically restart.</system:String>
10+
<system:String x:Key="plugin_pluginsmanager_install_prompt">{0} by {1} {2}{3}Would you like to install this plugin? After the installation Flow will automatically restart.</system:String>
1111
<system:String x:Key="plugin_pluginsmanager_install_title">Plugin Install</system:String>
1212
<system:String x:Key="plugin_pluginsmanager_uninstall_title">Plugin Uninstall</system:String>
1313
<system:String x:Key="plugin_pluginsmanager_install_errormetadatafile">Install failed: unable to find the plugin.json metadata file from the new plugin</system:String>
14-
<system:String x:Key="plugin_pluginsmanager_install_successandrestart">You have installed plugin {0} successfully.{1}Would you like to restart Flow Launcher to take effect?</system:String>
15-
<system:String x:Key="plugin_pluginsmanager_uninstall_successandrestart">You have uninstalled plugin {0} successfully.{1}Would you like to restart Flow Launcher to take effect?</system:String>
1614
<!--Controls-->
1715

1816
<!--Plugin Infos-->

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ internal void InstallOrUpdate(UserPlugin plugin)
3636
}
3737

3838
var message = string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_prompt"),
39-
Environment.NewLine, Environment.NewLine,
40-
plugin.Name, plugin.Author);
39+
plugin.Name, plugin.Author,
40+
Environment.NewLine, Environment.NewLine);
4141

4242
if (MessageBox.Show(message, Context.API.GetTranslation("plugin_pluginsmanager_install_title"), MessageBoxButton.YesNo) == MessageBoxResult.No)
4343
return;
@@ -157,12 +157,8 @@ private void Install(UserPlugin plugin, string downloadedFilePath)
157157
string newPluginPath = Path.Combine(DataLocation.PluginsDirectory, $"{plugin.Name}{plugin.ID}");
158158

159159
Directory.Move(pluginFolderPath, newPluginPath);
160-
161-
if (MessageBox.Show(string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_successandrestart"),
162-
plugin.Name, Environment.NewLine),
163-
Context.API.GetTranslation("plugin_pluginsmanager_install_title"),
164-
MessageBoxButton.YesNo, MessageBoxImage.Question) == MessageBoxResult.Yes)
165-
Context.API.RestartApp();
160+
161+
Context.API.RestartApp();
166162
}
167163

168164
internal List<Result> RequestUninstall(string search)
@@ -217,19 +213,15 @@ internal List<Result> RequestUninstall(string search)
217213
private void Uninstall(PluginMetadata plugin)
218214
{
219215
string message = string.Format(Context.API.GetTranslation("plugin_pluginsmanager_uninstall_prompt"),
220-
Environment.NewLine, Environment.NewLine,
221-
plugin.Name, plugin.Author);
216+
plugin.Name, plugin.Author,
217+
Environment.NewLine, Environment.NewLine);
222218

223219
if (MessageBox.Show(message, Context.API.GetTranslation("plugin_pluginsmanager_uninstall_title"),
224220
MessageBoxButton.YesNo) == MessageBoxResult.Yes)
225221
{
226222
using var _ = File.CreateText(Path.Combine(plugin.PluginDirectory, "NeedDelete.txt"));
227-
228-
if (MessageBox.Show(string.Format(Context.API.GetTranslation("plugin_pluginsmanager_uninstall_successandrestart"),
229-
plugin.Name, Environment.NewLine),
230-
Context.API.GetTranslation("plugin_pluginsmanager_uninstall_title"),
231-
MessageBoxButton.YesNo, MessageBoxImage.Question) == MessageBoxResult.Yes)
232-
Context.API.RestartApp();
223+
224+
Context.API.RestartApp();
233225
}
234226
}
235227
}

Plugins/Flow.Launcher.Plugin.PluginsManager/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"Name": "Plugins Manager",
77
"Description": "Management of installing, uninstalling or updating Flow Launcher plugins",
88
"Author": "Jeremy Wu",
9-
"Version": "1.0.0",
9+
"Version": "1.1.0",
1010
"Language": "csharp",
1111
"Website": "https://github.com/Flow-Launcher/Flow.Launcher",
1212
"ExecuteFileName": "Flow.Launcher.Plugin.PluginsManager.dll",

0 commit comments

Comments
 (0)