Move Old HttpWebRequest to HttpClient Instance (solve connection timeout)

Author: taooceros

Flow.Launcher.Core/Updater.cs

@@ -139,7 +139,7 @@ private async Task<UpdateManager> GitHubUpdateManager(string repository)
             var latest = releases.Where(r => !r.Prerelease).OrderByDescending(r => r.PublishedAt).First();
             var latestUrl = latest.HtmlUrl.Replace("/tag/", "/download/");
 
-            var client = new WebClient { Proxy = Http.WebProxy() };
+            var client = new WebClient { Proxy = Http.WebProxy };
             var downloader = new FileDownloader(client);
 
             var manager = new UpdateManager(latestUrl, urlDownloader: downloader);

Flow.Launcher.Infrastructure/Http/Http.cs

@@ -6,77 +6,95 @@
 using JetBrains.Annotations;
 using Flow.Launcher.Infrastructure.Logger;
 using Flow.Launcher.Infrastructure.UserSettings;
+using System;
 
 namespace Flow.Launcher.Infrastructure.Http
 {
     public static class Http
     {
         private const string UserAgent = @"Mozilla/5.0 (Trident/7.0; rv:11.0) like Gecko";
 
+        private static HttpClient client;
+        private static SocketsHttpHandler socketsHttpHandler = new SocketsHttpHandler()
+        {
+            UseProxy = true,
+            Proxy = WebProxy
+        };
+
         static Http()
         {
             // need to be added so it would work on a win10 machine
             ServicePointManager.Expect100Continue = true;
             ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls
                                                     | SecurityProtocolType.Tls11
                                                     | SecurityProtocolType.Tls12;
+
+            client.DefaultRequestHeaders.Add("User-Agent", UserAgent);
+
+        }
+        private static HttpProxy proxy;
+        public static HttpProxy Proxy
+        {
+            private get
+            {
+                return proxy;
+            }
+            set
+            {
+                proxy = value;
+                UpdateProxy();
+            }
         }
 
-        public static HttpProxy Proxy { private get; set; }
-        public static IWebProxy WebProxy()
+        public static WebProxy WebProxy { get; private set; }
+
+        /// <summary>
+        /// Update the Address of the Proxy to modify the client Proxy
+        /// </summary>
+        public static void UpdateProxy()
+        // TODO: need test with a proxy
         {
             if (Proxy != null && Proxy.Enabled && !string.IsNullOrEmpty(Proxy.Server))
             {
                 if (string.IsNullOrEmpty(Proxy.UserName) || string.IsNullOrEmpty(Proxy.Password))
                 {
-                    var webProxy = new WebProxy(Proxy.Server, Proxy.Port);
-                    return webProxy;
+                    WebProxy.Address = new Uri($"http://{Proxy.Server}:{Proxy.Port}");
+                    WebProxy.Credentials = null;
                 }
                 else
                 {
-                    var webProxy = new WebProxy(Proxy.Server, Proxy.Port)
-                    {
-                        Credentials = new NetworkCredential(Proxy.UserName, Proxy.Password)
-                    };
-                    return webProxy;
+                    WebProxy.Address = new Uri($"http://{Proxy.Server}:{Proxy.Port}");
+                    WebProxy.Credentials = new NetworkCredential(Proxy.UserName, Proxy.Password);
                 }
             }
             else
             {
-                return WebRequest.GetSystemWebProxy();
+                WebProxy.Address = new WebProxy().Address;
+                WebProxy.Credentials = null;
             }
         }
 
         public static void Download([NotNull] string url, [NotNull] string filePath)
         {
-            var client = new WebClient { Proxy = WebProxy() };
+            var client = new WebClient { Proxy = WebProxy };
             client.Headers.Add("user-agent", UserAgent);
             client.DownloadFile(url, filePath);
         }
 
         public static async Task<string> Get([NotNull] string url, string encoding = "UTF-8")
         {
             Log.Debug($"|Http.Get|Url <{url}>");
-            var request = WebRequest.CreateHttp(url);
-            request.Method = "GET";
-            request.Timeout = 1000;
-            request.Proxy = WebProxy();
-            request.UserAgent = UserAgent;
-            var response = await request.GetResponseAsync() as HttpWebResponse;
-            response = response.NonNull();
-            var stream = response.GetResponseStream().NonNull();
-
-            using (var reader = new StreamReader(stream, Encoding.GetEncoding(encoding)))
+            var response = await client.GetAsync(url);
+            using var stream = await response.Content.ReadAsStreamAsync();
+            using var reader = new StreamReader(stream, Encoding.GetEncoding(encoding));
+            var content = await reader.ReadToEndAsync();
+            if (response.StatusCode == HttpStatusCode.OK)
             {
-                var content = await reader.ReadToEndAsync();
-                if (response.StatusCode == HttpStatusCode.OK)
-                {
-                    return content;
-                }
-                else
-                {
-                    throw new HttpRequestException($"Error code <{response.StatusCode}> with content <{content}> returned from <{url}>");
-                }
+                return content;
+            }
+            else
+            {
+                throw new HttpRequestException($"Error code <{response.StatusCode}> with content <{content}> returned from <{url}>");
             }
         }
     }