Use Flow.Launcher.Localization to improve code quality

Author: Jack251970

Plugins/Flow.Launcher.Plugin.Calculator/Main.cs

@@ -26,7 +26,7 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider
     private const string IcoPath = "Images/calculator.png";
     private static readonly List<Result> EmptyResults = [];
 
-    internal static PluginInitContext Context { get; set; } = null!;
+    internal static PluginInitContext Context { get; private set; } = null!;
 
     private Settings _settings;
     private SettingsViewModel _viewModel;

Plugins/Flow.Launcher.Plugin.ProcessKiller/Flow.Launcher.Plugin.ProcessKiller.csproj

@@ -35,6 +35,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <Prefer32Bit>false</Prefer32Bit>
+    <NoWarn>$(NoWarn);FLSG0007</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
@@ -52,6 +53,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Flow.Launcher.Localization" Version="0.0.6" />
     <PackageReference Include="Microsoft.Windows.CsWin32" Version="0.3.205">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Plugins/Flow.Launcher.Plugin.ProcessKiller/Main.cs

@@ -11,7 +11,7 @@ public class Main : IPlugin, IPluginI18n, IContextMenu, ISettingProvider
 {
     internal static PluginInitContext Context { get; private set; }
 
-    internal static Settings Settings { get; private set; }
+    private Settings _settings;
 
     private readonly ProcessHelper processHelper = new();
 
@@ -20,8 +20,8 @@ public class Main : IPlugin, IPluginI18n, IContextMenu, ISettingProvider
     public void Init(PluginInitContext context)
     {
         Context = context;
-        Settings = context.API.LoadSettingJsonStorage<Settings>();
-        _viewModel = new SettingsViewModel(Settings);
+        _settings = context.API.LoadSettingJsonStorage<Settings>();
+        _viewModel = new SettingsViewModel(_settings);
     }
 
     public List<Result> Query(Query query)
@@ -31,12 +31,12 @@ public List<Result> Query(Query query)
 
     public string GetTranslatedPluginTitle()
     {
-        return Context.API.GetTranslation("flowlauncher_plugin_processkiller_plugin_name");
+        return Localize.flowlauncher_plugin_processkiller_plugin_name();
     }
 
     public string GetTranslatedPluginDescription()
     {
-        return Context.API.GetTranslation("flowlauncher_plugin_processkiller_plugin_description");
+        return Localize.flowlauncher_plugin_processkiller_plugin_description();
     }
 
     public List<Result> LoadContextMenus(Result result)
@@ -51,7 +51,7 @@ public List<Result> LoadContextMenus(Result result)
         {
             menuOptions.Add(new Result
             {
-                Title = Context.API.GetTranslation("flowlauncher_plugin_processkiller_kill_instances"),
+                Title = Localize.flowlauncher_plugin_processkiller_kill_instances(),
                 SubTitle = processPath,
                 Action = _ =>
                 {
@@ -73,7 +73,7 @@ private List<Result> CreateResultsFromQuery(Query query)
     {
         // Get all non-system processes
         var allPocessList = processHelper.GetMatchingProcesses();
-        if (!allPocessList.Any())
+        if (allPocessList.Count == 0)
         {
             return null;
         }
@@ -82,9 +82,9 @@ private List<Result> CreateResultsFromQuery(Query query)
         var searchTerm = query.Search;
         var processlist = new List<ProcessResult>();
         var processWindowTitle =
-            Settings.ShowWindowTitle || Settings.PutVisibleWindowProcessesTop ?
+            _settings.ShowWindowTitle || _settings.PutVisibleWindowProcessesTop ?
             ProcessHelper.GetProcessesWithNonEmptyWindowTitle() :
-            new Dictionary<int, string>();
+            [];
         if (string.IsNullOrWhiteSpace(searchTerm))
         {
             foreach (var p in allPocessList)
@@ -97,8 +97,8 @@ private List<Result> CreateResultsFromQuery(Query query)
                     // Use window title for those processes if enabled
                     processlist.Add(new ProcessResult(
                         p,
-                        Settings.PutVisibleWindowProcessesTop ? 200 : 0,
-                        Settings.ShowWindowTitle ? windowTitle : progressNameIdTitle,
+                        _settings.PutVisibleWindowProcessesTop ? 200 : 0,
+                        _settings.ShowWindowTitle ? windowTitle : progressNameIdTitle,
                         null,
                         progressNameIdTitle));
                 }
@@ -129,14 +129,14 @@ private List<Result> CreateResultsFromQuery(Query query)
                     {
                         // Add score to prioritize processes with visible windows
                         // Use window title for those processes
-                        if (Settings.PutVisibleWindowProcessesTop)
+                        if (_settings.PutVisibleWindowProcessesTop)
                         {
                             score += 200;
                         }
                         processlist.Add(new ProcessResult(
                             p,
                             score,
-                            Settings.ShowWindowTitle ? windowTitle : progressNameIdTitle,
+                            _settings.ShowWindowTitle ? windowTitle : progressNameIdTitle,
                             score == windowTitleMatch.Score ? windowTitleMatch : null,
                             progressNameIdTitle));
                     }
@@ -194,8 +194,8 @@ private List<Result> CreateResultsFromQuery(Query query)
             sortedResults.Insert(1, new Result()
             {
                 IcoPath = firstResult?.IcoPath,
-                Title = string.Format(Context.API.GetTranslation("flowlauncher_plugin_processkiller_kill_all"), firstResult?.ContextData),
-                SubTitle = string.Format(Context.API.GetTranslation("flowlauncher_plugin_processkiller_kill_all_count"), processlist.Count),
+                Title = Localize.flowlauncher_plugin_processkiller_kill_all(firstResult?.ContextData),
+                SubTitle = Localize.flowlauncher_plugin_processkiller_kill_all_count(processlist.Count),
                 Score = 200,
                 Action = (c) =>
                 {