@@ -542,8 +542,8 @@ public static bool PluginModified(string id)
542542
543543 public static async Task UpdatePluginAsync ( PluginMetadata existingVersion , UserPlugin newVersion , string zipFilePath )
544544 {
545- var success = InstallPlugin ( newVersion , zipFilePath , checkModified : false ) ;
546- if ( ! success ) return ;
545+ var installSuccess = InstallPlugin ( newVersion , zipFilePath , checkModified : false ) ;
546+ if ( ! installSuccess ) return ;
547547 await UninstallPluginAsync ( existingVersion , removePluginFromSettings : false , removePluginSettings : false , checkModified : false ) ;
548548 _modifiedPlugins . Add ( existingVersion . ID ) ;
549549 }
@@ -643,13 +643,13 @@ internal static bool InstallPlugin(UserPlugin plugin, string zipFilePath, bool c
643643 return true ;
644644 }
645645
646- internal static async Task UninstallPluginAsync ( PluginMetadata plugin , bool removePluginFromSettings , bool removePluginSettings , bool checkModified )
646+ internal static async Task < bool > UninstallPluginAsync ( PluginMetadata plugin , bool removePluginFromSettings , bool removePluginSettings , bool checkModified )
647647 {
648648 if ( checkModified && PluginModified ( plugin . ID ) )
649649 {
650650 API . ShowMsgError ( string . Format ( API . GetTranslation ( "failedToUninstallPluginTitle" ) , plugin . Name ) ,
651651 API . GetTranslation ( "pluginModifiedAlreadyMessage" ) ) ;
652- return ;
652+ return false ;
653653 }
654654
655655 if ( removePluginSettings || removePluginFromSettings )
@@ -713,7 +713,7 @@ internal static async Task UninstallPluginAsync(PluginMetadata plugin, bool remo
713713 _modifiedPlugins . Add ( plugin . ID ) ;
714714 }
715715
716- return ;
716+ return true ;
717717 }
718718
719719 #endregion
0 commit comments