@@ -542,8 +542,8 @@ public static bool PluginModified(string id)
542
542
543
543
public static async Task UpdatePluginAsync ( PluginMetadata existingVersion , UserPlugin newVersion , string zipFilePath )
544
544
{
545
- var success = InstallPlugin ( newVersion , zipFilePath , checkModified : false ) ;
546
- if ( ! success ) return ;
545
+ var installSuccess = InstallPlugin ( newVersion , zipFilePath , checkModified : false ) ;
546
+ if ( ! installSuccess ) return ;
547
547
await UninstallPluginAsync ( existingVersion , removePluginFromSettings : false , removePluginSettings : false , checkModified : false ) ;
548
548
_modifiedPlugins . Add ( existingVersion . ID ) ;
549
549
}
@@ -643,13 +643,13 @@ internal static bool InstallPlugin(UserPlugin plugin, string zipFilePath, bool c
643
643
return true ;
644
644
}
645
645
646
- internal static async Task UninstallPluginAsync ( PluginMetadata plugin , bool removePluginFromSettings , bool removePluginSettings , bool checkModified )
646
+ internal static async Task < bool > UninstallPluginAsync ( PluginMetadata plugin , bool removePluginFromSettings , bool removePluginSettings , bool checkModified )
647
647
{
648
648
if ( checkModified && PluginModified ( plugin . ID ) )
649
649
{
650
650
API . ShowMsgError ( string . Format ( API . GetTranslation ( "failedToUninstallPluginTitle" ) , plugin . Name ) ,
651
651
API . GetTranslation ( "pluginModifiedAlreadyMessage" ) ) ;
652
- return ;
652
+ return false ;
653
653
}
654
654
655
655
if ( removePluginSettings || removePluginFromSettings )
@@ -713,7 +713,7 @@ internal static async Task UninstallPluginAsync(PluginMetadata plugin, bool remo
713
713
_modifiedPlugins . Add ( plugin . ID ) ;
714
714
}
715
715
716
- return ;
716
+ return true ;
717
717
}
718
718
719
719
#endregion
0 commit comments