Merge pull request #1736 from VictoriousRaptor/LocalizedLnkName

Use localized name for shell link programs

Author: VictoriousRaptor

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs

@@ -3,6 +3,7 @@
 using System.Runtime.InteropServices;
 using Accessibility;
 using System.Runtime.InteropServices.ComTypes;
+using Flow.Launcher.Plugin.Program.Logger;
 
 namespace Flow.Launcher.Plugin.Program.Programs
 {
@@ -119,9 +120,19 @@ public string retrieveTargetPath(string path)
             // To set the app description
             if (!String.IsNullOrEmpty(target))
             {
-                buffer = new StringBuilder(MAX_PATH);
-                ((IShellLinkW)link).GetDescription(buffer, MAX_PATH);
-                description = buffer.ToString();
+                try
+                {
+                    buffer = new StringBuilder(MAX_PATH);
+                    ((IShellLinkW)link).GetDescription(buffer, MAX_PATH);
+                    description = buffer.ToString();
+                }
+                catch (COMException e)
+                {
+                    // C:\\ProgramData\\Microsoft\\Windows\\Start Menu\\Programs\\MiracastView.lnk always cause exception
+                    ProgramLogger.LogException($"|IShellLinkW|retrieveTargetPath|{path}" +
+                                               "|Error caused likely due to trying to get the description of the program",
+                        e);
+                }
 
                 buffer.Clear();
                 ((IShellLinkW)link).GetArguments(buffer, MAX_PATH);

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLocalization.cs

@@ -0,0 +1,92 @@
+using System;
+using System.IO;
+using System.Runtime.InteropServices;
+using System.Text;
+
+
+namespace Flow.Launcher.Plugin.Program.Programs
+{
+    // From PT Run
+    /// <summary>
+    /// Class to get localized name of shell items like 'My computer'. The localization is based on the 'windows display language'.
+    /// Reused code from https://stackoverflow.com/questions/41423491/how-to-get-localized-name-of-known-folder for the method <see cref="GetLocalizedName"/>
+    /// </summary>
+    public static class ShellLocalization
+    {
+        internal const uint DONTRESOLVEDLLREFERENCES = 0x00000001;
+        internal const uint LOADLIBRARYASDATAFILE = 0x00000002;
+
+        [DllImport("shell32.dll", CallingConvention = CallingConvention.Winapi, CharSet = CharSet.Unicode)]
+        internal static extern int SHGetLocalizedName(string pszPath, StringBuilder pszResModule, ref int cch, out int pidsRes);
+
+        [DllImport("user32.dll", EntryPoint = "LoadStringW", CallingConvention = CallingConvention.Winapi, CharSet = CharSet.Unicode)]
+        internal static extern int LoadString(IntPtr hModule, int resourceID, StringBuilder resourceValue, int len);
+
+        [DllImport("kernel32.dll", CharSet = CharSet.Unicode, ExactSpelling = true, EntryPoint = "LoadLibraryExW")]
+        internal static extern IntPtr LoadLibraryEx(string lpFileName, IntPtr hFile, uint dwFlags);
+
+        [DllImport("kernel32.dll", ExactSpelling = true)]
+        internal static extern int FreeLibrary(IntPtr hModule);
+
+        [DllImport("kernel32.dll", EntryPoint = "ExpandEnvironmentStringsW", CharSet = CharSet.Unicode, ExactSpelling = true)]
+        internal static extern uint ExpandEnvironmentStrings(string lpSrc, StringBuilder lpDst, int nSize);
+
+        /// <summary>
+        /// Returns the localized name of a shell item.
+        /// </summary>
+        /// <param name="path">Path to the shell item (e. g. shortcut 'File Explorer.lnk').</param>
+        /// <returns>The localized name as string or <see cref="string.Empty"/>.</returns>
+        public static string GetLocalizedName(string path)
+        {
+            StringBuilder resourcePath = new StringBuilder(1024);
+            StringBuilder localizedName = new StringBuilder(1024);
+            int len, id;
+            len = resourcePath.Capacity;
+
+            // If there is no resource to localize a file name the method returns a non zero value.
+            if (SHGetLocalizedName(path, resourcePath, ref len, out id) == 0)
+            {
+                _ = ExpandEnvironmentStrings(resourcePath.ToString(), resourcePath, resourcePath.Capacity);
+                IntPtr hMod = LoadLibraryEx(resourcePath.ToString(), IntPtr.Zero, DONTRESOLVEDLLREFERENCES | LOADLIBRARYASDATAFILE);
+                if (hMod != IntPtr.Zero)
+                {
+                    if (LoadString(hMod, id, localizedName, localizedName.Capacity) != 0)
+                    {
+                        string lString = localizedName.ToString();
+                        _ = FreeLibrary(hMod);
+                        return lString;
+                    }
+
+                    _ = FreeLibrary(hMod);
+                }
+            }
+
+            return string.Empty;
+        }
+
+        /// <summary>
+        /// This method returns the localized path to a shell item (folder or file)
+        /// </summary>
+        /// <param name="path">The path to localize</param>
+        /// <returns>The localized path or the original path if localized version is not available</returns>
+        public static string GetLocalizedPath(string path)
+        {
+            path = Environment.ExpandEnvironmentVariables(path);
+            string ext = Path.GetExtension(path);
+            var pathParts = path.Split("\\");
+            string[] locPath = new string[pathParts.Length];
+
+            for (int i = 0; i < pathParts.Length; i++)
+            {
+                int iElements = i + 1;
+                string lName = GetLocalizedName(string.Join("\\", pathParts[..iElements]));
+                locPath[i] = !string.IsNullOrEmpty(lName) ? lName : pathParts[i];
+            }
+
+            string newPath = string.Join("\\", locPath);
+            newPath = !newPath.EndsWith(ext, StringComparison.InvariantCultureIgnoreCase) ? newPath + ext : newPath;
+
+            return newPath;
+        }
+    }
+}

Plugins/Flow.Launcher.Plugin.Program/Programs/UWP.cs

@@ -249,24 +249,24 @@ public static bool SupportUWP()
 
         private static IEnumerable<Package> CurrentUserPackages()
         {
-            var u = WindowsIdentity.GetCurrent().User;
+            var user = WindowsIdentity.GetCurrent().User;
 
-            if (u != null)
+            if (user != null)
             {
-                var id = u.Value;
-                PackageManager m;
+                var userId = user.Value;
+                PackageManager packageManager;
                 try
                 {
-                    m = new PackageManager();
+                    packageManager = new PackageManager();
                 }
                 catch
                 {
                     // Bug from https://github.com/microsoft/CsWinRT, using Microsoft.Windows.SDK.NET.Ref 10.0.19041.0.
                     // Only happens on the first time, so a try catch can fix it.
-                    m = new PackageManager();
+                    packageManager = new PackageManager();
                 }
-                var ps = m.FindPackagesForUser(id);
-                ps = ps.Where(p =>
+                var packages = packageManager.FindPackagesForUser(userId);
+                packages = packages.Where(p =>
                 {
                     try
                     {
@@ -277,12 +277,12 @@ private static IEnumerable<Package> CurrentUserPackages()
                     }
                     catch (Exception e)
                     {
-                        ProgramLogger.LogException("UWP", "CurrentUserPackages", $"{id}", "An unexpected error occurred and "
+                        ProgramLogger.LogException("UWP", "CurrentUserPackages", $"{p.Id.FullName}", "An unexpected error occurred and "
                                                                                         + $"unable to verify if package is valid", e);
                         return false;
                     }
                 });
-                return ps;
+                return packages;
             }
             else
             {