Remove command parameter

Author: Jack251970

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

@@ -328,37 +328,36 @@ public void AppendLink(string containerName, AccessLink link)
             container.Add(link);
         }
 
-
         [RelayCommand]
-        private void EditIndexSearchExcludePaths(object commandParameter)
+        private void EditIndexSearchExcludePaths()
         {
-
+            var selectedLink = SelectedIndexSearchExcludedPath;
             var collection = Settings.IndexSearchExcludedSubdirectoryPaths;
 
-            if (SelectedIndexSearchExcludedPath is null)
+            if (selectedLink is null)
             {
                 ShowUnselectedMessage();
                 return;
             }
 
-            var path = PromptUserSelectPath(SelectedIndexSearchExcludedPath.Type,
-                SelectedIndexSearchExcludedPath.Type == ResultType.Folder
-                    ? SelectedIndexSearchExcludedPath.Path
-                    : Path.GetDirectoryName(SelectedIndexSearchExcludedPath.Path));
+            var path = PromptUserSelectPath(selectedLink.Type,
+                selectedLink.Type == ResultType.Folder
+                    ? selectedLink.Path
+                    : Path.GetDirectoryName(selectedLink.Path));
 
             if (path is null)
                 return;
 
-            var selectedType = SelectedIndexSearchExcludedPath.Type;
-            collection.Remove(SelectedIndexSearchExcludedPath);
+            var selectedType = selectedLink.Type;
+            collection.Remove(selectedLink);
             collection.Add(new AccessLink
             {
                 Path = path, Type = selectedType, Name = path.GetPathName()
             });
         }
 
         [RelayCommand]
-        private void AddIndexSearchExcludePaths(object commandParameter)
+        private void AddIndexSearchExcludePaths()
         {
             var container = Settings.IndexSearchExcludedSubdirectoryPaths;
 
@@ -378,30 +377,37 @@ private void AddIndexSearchExcludePaths(object commandParameter)
         }
 
         [RelayCommand]
-        private void EditQuickAccessLink(object commandParameter)
+        private void EditQuickAccessLink()
         {
-            if (SelectedQuickAccessLink is null)
+            var selectedLink = SelectedQuickAccessLink;
+            var collection = Settings.QuickAccessLinks;
+
+            if (selectedLink is null)
             {
                 ShowUnselectedMessage();
                 return;
             }
-            var quickAccessLinkSettings = new QuickAccessLinkSettings(Settings.QuickAccessLinks,SelectedQuickAccessLink);
-            if (quickAccessLinkSettings.ShowDialog() == true) Save();
+            var quickAccessLinkSettings = new QuickAccessLinkSettings(collection, SelectedQuickAccessLink);
+            if (quickAccessLinkSettings.ShowDialog() == true)
+            {
+                Save();
+            }
         }
 
         [RelayCommand]
-        private void AddQuickAccessLink(object commandParameter)
+        private void AddQuickAccessLink()
         {
             var quickAccessLinkSettings = new QuickAccessLinkSettings(Settings.QuickAccessLinks);
-            if (quickAccessLinkSettings.ShowDialog() == true) Save();
+            if (quickAccessLinkSettings.ShowDialog() == true)
+            {
+                Save();
+            }
         }
-        
-        
 
         [RelayCommand]
-        private void RemoveLink(object obj)
+        private void RemoveLink(object commandParameter)
         {
-            if (obj is not string container) return;
+            if (commandParameter is not string container) return;
 
             switch (container)
             {

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml

@@ -785,13 +785,11 @@
                         MinWidth="100"
                         Margin="{StaticResource SettingPanelItemLeftMargin}"
                         Command="{Binding EditQuickAccessLinkCommand}"
-                        CommandParameter="QuickAccessLink"
                         Content="{DynamicResource plugin_explorer_edit}" />
                     <Button
                         MinWidth="100"
                         Margin="{StaticResource SettingPanelItemLeftMargin}"
                         Command="{Binding AddQuickAccessLinkCommand}"
-                        CommandParameter="QuickAccessLink"
                         Content="{DynamicResource plugin_explorer_add}" />
                 </StackPanel>
             </Grid>
@@ -852,13 +850,11 @@
                         MinWidth="100"
                         Margin="{StaticResource SettingPanelItemLeftMargin}"
                         Command="{Binding EditIndexSearchExcludePathsCommand}"
-                        CommandParameter="IndexSearchExcludedPaths"
                         Content="{DynamicResource plugin_explorer_edit}" />
                     <Button
                         MinWidth="100"
                         Margin="{StaticResource SettingPanelItemLeftMargin}"
                         Command="{Binding AddIndexSearchExcludePathsCommand}"
-                        CommandParameter="IndexSearchExcludedPaths"
                         Content="{DynamicResource plugin_explorer_add}" />
                 </StackPanel>
             </Grid>