Hook delegates can be garbage‑collected

Author: Jack251970

Flow.Launcher.Infrastructure/QuickSwitch/QuickSwitch.cs

@@ -59,6 +59,10 @@ public static class QuickSwitch
         private static HWINEVENTHOOK _locationChangeHook = HWINEVENTHOOK.Null;
         private static HWINEVENTHOOK _destroyChangeHook = HWINEVENTHOOK.Null;
 
+        private static readonly WINEVENTPROC _fgProc = ForegroundChangeCallback;
+        private static readonly WINEVENTPROC _locProc = LocationChangeCallback;
+        private static readonly WINEVENTPROC _desProc = DestroyChangeCallback;
+
         private static DispatcherTimer _dragMoveTimer = null;
 
         // A list of all file dialog windows that are auto switched already
@@ -68,7 +72,8 @@ public static class QuickSwitch
         // Note: Here we do not start & stop the timer beacause when there are many dialog windows
         // Unhooking and hooking will take too much time which can make window position weird
         // So we start & stop the timer when we find a file dialog window
-        /*private static HWINEVENTHOOK _moveSizeHook = HWINEVENTHOOK.Null;*/
+        /*private static HWINEVENTHOOK _moveSizeHook = HWINEVENTHOOK.Null;
+        private static HWINEVENTHOOK _moveProc = MoveSizeCallBack;*/
 
         private static readonly SemaphoreSlim _navigationLock = new(1, 1);
 
@@ -151,23 +156,23 @@ public static void SetupQuickSwitch(bool enabled)
                     PInvoke.EVENT_SYSTEM_FOREGROUND,
                     PInvoke.EVENT_SYSTEM_FOREGROUND,
                     PInvoke.GetModuleHandle((PCWSTR)null),
-                    ForegroundChangeCallback,
+                    _fgProc,
                     0,
                     0,
                     PInvoke.WINEVENT_OUTOFCONTEXT);
                 _locationChangeHook = PInvoke.SetWinEventHook(
                     PInvoke.EVENT_OBJECT_LOCATIONCHANGE,
                     PInvoke.EVENT_OBJECT_LOCATIONCHANGE,
                     PInvoke.GetModuleHandle((PCWSTR)null),
-                    LocationChangeCallback,
+                    _locProc,
                     0,
                     0,
                     PInvoke.WINEVENT_OUTOFCONTEXT);
                 _destroyChangeHook = PInvoke.SetWinEventHook(
                     PInvoke.EVENT_OBJECT_DESTROY,
                     PInvoke.EVENT_OBJECT_DESTROY,
                     PInvoke.GetModuleHandle((PCWSTR)null),
-                    DestroyChangeCallback,
+                    _desProc,
                     0,
                     0,
                     PInvoke.WINEVENT_OUTOFCONTEXT);
@@ -268,14 +273,14 @@ private static unsafe void InvokeShowQuickSwitchWindow(bool dialogWindowChanged)
                             _moveSizeHook = HWINEVENTHOOK.Null;
                         }
 
-                        // Call MoveSizeCallBack when the window is moved or resized
+                        // Call _moveProc when the window is moved or resized
                         uint processId;
                         var threadId = PInvoke.GetWindowThreadProcessId(_dialogWindow.Handle, &processId);
                         _moveSizeHook = PInvoke.SetWinEventHook(
                             PInvoke.EVENT_SYSTEM_MOVESIZESTART,
                             PInvoke.EVENT_SYSTEM_MOVESIZEEND,
                             PInvoke.GetModuleHandle((PCWSTR)null),
-                            MoveSizeCallBack,
+                            _moveProc,
                             processId,
                             threadId,
                             PInvoke.WINEVENT_OUTOFCONTEXT);