Skip to content

Commit ae76c41

Browse files
authored
Merge pull request #3584 from Flow-Launcher/null_for_error_plugins
Fix argument null exception when updating plugin directories for erroneous plugins
2 parents dd2560e + 50780db commit ae76c41

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

Flow.Launcher.Core/Plugin/PluginManager.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,11 +187,21 @@ private static void UpdatePluginDirectory(List<PluginMetadata> metadatas)
187187
{
188188
if (AllowedLanguage.IsDotNet(metadata.Language))
189189
{
190+
if (string.IsNullOrEmpty(metadata.AssemblyName))
191+
{
192+
API.LogWarn(ClassName, $"AssemblyName is empty for plugin with metadata: {metadata.Name}");
193+
continue; // Skip if AssemblyName is not set, which can happen for erroneous plugins
194+
}
190195
metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, metadata.AssemblyName);
191196
metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, metadata.AssemblyName);
192197
}
193198
else
194199
{
200+
if (string.IsNullOrEmpty(metadata.Name))
201+
{
202+
API.LogWarn(ClassName, $"Name is empty for plugin with metadata: {metadata.Name}");
203+
continue; // Skip if Name is not set, which can happen for erroneous plugins
204+
}
195205
metadata.PluginSettingsDirectoryPath = Path.Combine(DataLocation.PluginSettingsDirectory, metadata.Name);
196206
metadata.PluginCacheDirectoryPath = Path.Combine(DataLocation.PluginCacheDirectory, metadata.Name);
197207
}

0 commit comments

Comments
 (0)