Use OSVersion.Version.Build to reduce registry access

VictoriousRaptor · VictoriousRaptor · commit b74ea0071de7 · 2023-04-20T20:25:39.000+08:00
diff --git a/Flow.Launcher.Infrastructure/Exception/ExceptionFormatter.cs b/Flow.Launcher.Infrastructure/Exception/ExceptionFormatter.cs
@@ -177,12 +177,9 @@ public static string GetWindowsFullVersionFromRegistry()
         {
             try
             {
-                using (RegistryKey registryKey = Registry.LocalMachine.OpenSubKey(@"SOFTWARE\Microsoft\Windows NT\CurrentVersion\"))
-                {
-                    var buildRevision = GetWindowsRevisionFromRegistry();
-                    var currentBuild = registryKey.GetValue("CurrentBuild").ToString();
-                    return currentBuild + "." + buildRevision;
-                }
+                var buildRevision = GetWindowsRevisionFromRegistry();
+                var currentBuild = Environment.OSVersion.Version.Build;
+                return currentBuild.ToString() + "." + buildRevision;
             }
             catch
             {

Original file line number	Diff line number	Diff line change
`@@ -177,12 +177,9 @@ public static string GetWindowsFullVersionFromRegistry()`
`177`	`177`	`{`
`178`	`178`	`try`
`179`	`179`	`{`
`180`		`- using (RegistryKey registryKey = Registry.LocalMachine.OpenSubKey(@"SOFTWARE\Microsoft\Windows NT\CurrentVersion\"))`
`181`		`- {`
`182`		`- var buildRevision = GetWindowsRevisionFromRegistry();`
`183`		`- var currentBuild = registryKey.GetValue("CurrentBuild").ToString();`
`184`		`- return currentBuild + "." + buildRevision;`
`185`		`- }`
	`180`	`+ var buildRevision = GetWindowsRevisionFromRegistry();`
	`181`	`+ var currentBuild = Environment.OSVersion.Version.Build;`
	`182`	`+ return currentBuild.ToString() + "." + buildRevision;`
`186`	`183`	`}`
`187`	`184`	`catch`
`188`	`185`	`{`