Throw exception when zip not found

VictoriousRaptor · VictoriousRaptor · commit b7a78362bf38 · 2023-11-11T10:25:45.000+08:00
diff --git a/Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs b/Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs
@@ -267,7 +267,7 @@ await Http.DownloadAsync(x.PluginNewUserPlugin.UrlDownload, downloadToFilePath)
                                 }).ContinueWith(t =>
                                 {
                                     Log.Exception("PluginsManager", $"Update failed for {x.Name}",
-                                        t.Exception.InnerException, "RequestUpdate");
+                                        t.Exception.InnerException);
                                     Context.API.ShowMsg(
                                         Context.API.GetTranslation("plugin_pluginsmanager_install_error_title"),
                                         string.Format(
@@ -410,7 +410,7 @@ internal async ValueTask<List<Result>> RequestInstallOrUpdate(string search, Can
         private void Install(UserPlugin plugin, string downloadedFilePath)
         {
             if (!File.Exists(downloadedFilePath))
-                return;
+                throw new FileNotFoundException($"Plugin {plugin.ID} zip file not found at {downloadedFilePath}", downloadedFilePath);
             try
             {
                 PluginManager.Install(plugin, downloadedFilePath);

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ await Http.DownloadAsync(x.PluginNewUserPlugin.UrlDownload, downloadToFilePath)`
`267`	`267`	`}).ContinueWith(t =>`
`268`	`268`	`{`
`269`	`269`	`Log.Exception("PluginsManager", $"Update failed for {x.Name}",`
`270`		`- t.Exception.InnerException, "RequestUpdate");`
	`270`	`+ t.Exception.InnerException);`
`271`	`271`	`Context.API.ShowMsg(`
`272`	`272`	`Context.API.GetTranslation("plugin_pluginsmanager_install_error_title"),`
`273`	`273`	`string.Format(`
`@@ -410,7 +410,7 @@ internal async ValueTask<List<Result>> RequestInstallOrUpdate(string search, Can`
`410`	`410`	`private void Install(UserPlugin plugin, string downloadedFilePath)`
`411`	`411`	`{`
`412`	`412`	`if (!File.Exists(downloadedFilePath))`
`413`		`- return;`
	`413`	`+ throw new FileNotFoundException($"Plugin {plugin.ID} zip file not found at {downloadedFilePath}", downloadedFilePath);`
`414`	`414`	`try`
`415`	`415`	`{`
`416`	`416`	`PluginManager.Install(plugin, downloadedFilePath);`