Add translations & Use ShowMsgError

Jack251970 · Jack251970 · commit ba0a113cc9d4 · 2025-07-20T12:28:55.000+08:00
diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -719,7 +719,7 @@ internal static async Task<bool> UninstallPluginAsync(PluginMetadata plugin, boo
                 catch (Exception e)
                 {
                     API.LogException(ClassName, $"Failed to delete plugin settings folder for {plugin.Name}", e);
-                    API.ShowMsg(API.GetTranslation("failedToRemovePluginSettingsTitle"),
+                    API.ShowMsgError(API.GetTranslation("failedToRemovePluginSettingsTitle"),
                         string.Format(API.GetTranslation("failedToRemovePluginSettingsMessage"), plugin.Name));
                 }
             }
@@ -735,7 +735,7 @@ internal static async Task<bool> UninstallPluginAsync(PluginMetadata plugin, boo
                 catch (Exception e)
                 {
                     API.LogException(ClassName, $"Failed to delete plugin cache folder for {plugin.Name}", e);
-                    API.ShowMsg(API.GetTranslation("failedToRemovePluginCacheTitle"),
+                    API.ShowMsgError(API.GetTranslation("failedToRemovePluginCacheTitle"),
                         string.Format(API.GetTranslation("failedToRemovePluginCacheMessage"), plugin.Name));
                 }
                 Settings.RemovePluginSettings(plugin.ID);
diff --git a/Flow.Launcher.Core/Updater.cs b/Flow.Launcher.Core/Updater.cs
@@ -111,7 +111,7 @@ public async Task UpdateAppAsync(bool silentUpdate = true)
                 }
 
                 if (!silentUpdate)
-                    _api.ShowMsg(_api.GetTranslation("update_flowlauncher_fail"),
+                    _api.ShowMsgError(_api.GetTranslation("update_flowlauncher_fail"),
                         _api.GetTranslation("update_flowlauncher_check_connection"));
             }
             finally
diff --git a/Flow.Launcher.Infrastructure/Http/Http.cs b/Flow.Launcher.Infrastructure/Http/Http.cs
@@ -82,7 +82,7 @@ var userName when string.IsNullOrEmpty(userName) =>
             }
             catch (UriFormatException e)
             {
-                API.ShowMsg(API.GetTranslation("pleaseTryAgain"), API.GetTranslation("parseProxyFailed"));
+                API.ShowMsgError(API.GetTranslation("pleaseTryAgain"), API.GetTranslation("parseProxyFailed"));
                 Log.Exception(ClassName, "Unable to parse Uri", e);
             }
         }
diff --git a/Flow.Launcher/App.xaml.cs b/Flow.Launcher/App.xaml.cs
@@ -267,7 +267,7 @@ private static void AutoStartup()
                     // but if it fails (permissions, etc) then don't keep retrying
                     // this also gives the user a visual indication in the Settings widget
                     _settings.StartFlowLauncherOnSystemStartup = false;
-                    API.ShowMsg(API.GetTranslation("setAutoStartFailed"), e.Message);
+                    API.ShowMsgError(API.GetTranslation("setAutoStartFailed"), e.Message);
                 }
             }
         }
diff --git a/Flow.Launcher/Resources/Pages/WelcomePage5.xaml.cs b/Flow.Launcher/Resources/Pages/WelcomePage5.xaml.cs
@@ -59,7 +59,7 @@ private void ChangeAutoStartup(bool value)
             }
             catch (Exception e)
             {
-                App.API.ShowMsg(App.API.GetTranslation("setAutoStartFailed"), e.Message);
+                App.API.ShowMsgError(App.API.GetTranslation("setAutoStartFailed"), e.Message);
             }
         }
 
diff --git a/Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs b/Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs
@@ -64,7 +64,7 @@ public bool StartFlowLauncherOnSystemStartup
             }
             catch (Exception e)
             {
-                App.API.ShowMsg(App.API.GetTranslation("setAutoStartFailed"), e.Message);
+                App.API.ShowMsgError(App.API.GetTranslation("setAutoStartFailed"), e.Message);
             }
         }
     }
@@ -91,7 +91,7 @@ public bool UseLogonTaskForStartup
                 }
                 catch (Exception e)
                 {
-                    App.API.ShowMsg(App.API.GetTranslation("setAutoStartFailed"), e.Message);
+                    App.API.ShowMsgError(App.API.GetTranslation("setAutoStartFailed"), e.Message);
                 }
             } 
         }
@@ -217,7 +217,7 @@ public bool LegacyKoreanIMEEnabled
             else
             {
                 // Since this is rarely seen text, language support is not provided.
-                App.API.ShowMsg(App.API.GetTranslation("KoreanImeSettingChangeFailTitle"), App.API.GetTranslation("KoreanImeSettingChangeFailSubTitle"));
+                App.API.ShowMsgError(App.API.GetTranslation("KoreanImeSettingChangeFailTitle"), App.API.GetTranslation("KoreanImeSettingChangeFailSubTitle"));
             }
         }
     }
diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Languages/en.xaml b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Languages/en.xaml
@@ -7,6 +7,9 @@
     <system:String x:Key="flowlauncher_plugin_browserbookmark_plugin_name">Browser Bookmarks</system:String>
     <system:String x:Key="flowlauncher_plugin_browserbookmark_plugin_description">Search your browser bookmarks</system:String>
 
+    <!--  Main  -->
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    "
     <!--  Settings  -->
     <system:String x:Key="flowlauncher_plugin_browserbookmark_bookmarkDataSetting">Bookmark Data</system:String>
     <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_openBookmarks">Open bookmarks in:</system:String>
diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs
@@ -223,11 +223,8 @@ public List<Result> LoadContextMenus(Result selectedResult)
                     }
                     catch (Exception e)
                     {
-                        var message = "Failed to set url in clipboard";
-                        _context.API.LogException(ClassName, message, e);
-
-                        _context.API.ShowMsg(message);
-
+                        _context.API.LogException(ClassName, "Failed to set url in clipboard", e);
+                        _context.API.ShowMsgError(_context.API.GetTranslation("flowlauncher_plugin_browserbookmark_copy_failed"));
                         return false;
                     }
                 },
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/ContextMenu.cs b/Plugins/Flow.Launcher.Plugin.Explorer/ContextMenu.cs
@@ -132,9 +132,8 @@ public List<Result> LoadContextMenus(Result selectedResult)
                         }
                         catch (Exception e)
                         {
-                            var message = "Fail to set text in clipboard";
-                            LogException(message, e);
-                            Context.API.ShowMsg(message);
+                            LogException("Fail to set text in clipboard", e);
+                            Context.API.ShowMsgError(Context.API.GetTranslation("plugin_explorer_fail_to_set_text"));
                             return false;
                         }
                     },
@@ -155,9 +154,8 @@ public List<Result> LoadContextMenus(Result selectedResult)
                         }
                         catch (Exception e)
                         {
-                            var message = "Fail to set text in clipboard";
-                            LogException(message, e);
-                            Context.API.ShowMsg(message);
+                            LogException("Fail to set text in clipboard", e);
+                            Context.API.ShowMsgError(Context.API.GetTranslation("plugin_explorer_fail_to_set_text"));
                             return false;
                         }
                     },
@@ -178,9 +176,8 @@ public List<Result> LoadContextMenus(Result selectedResult)
                         }
                         catch (Exception e)
                         {
-                            var message = $"Fail to set file/folder in clipboard";
-                            LogException(message, e);
-                            Context.API.ShowMsg(message);
+                            LogException($"Fail to set file/folder in clipboard", e);
+                            Context.API.ShowMsgError(Context.API.GetTranslation("plugin_explorer_fail_to_set_files"));
                             return false;
                         }
 
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml b/Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml
@@ -135,6 +135,8 @@
     <system:String x:Key="plugin_explorer_fail_to_delete">Fail to delete {0}</system:String>
     <system:String x:Key="plugin_explorer_file_not_found">File not found: {0}</system:String>
     <system:String x:Key="plugin_explorer_fail_to_open">Fail to open {0}</system:String>
+    <system:String x:Key="plugin_explorer_fail_to_set_text">Fail to set text in clipboard</system:String>
+    <system:String x:Key="plugin_explorer_fail_to_set_files">Fail to set files/folders in clipboard</system:String>
 
     <!--  Special Results  -->
     <system:String x:Key="plugin_explorer_diskfreespace">{0} free of {1}</system:String>
diff --git a/Plugins/Flow.Launcher.Plugin.Program/Main.cs b/Plugins/Flow.Launcher.Plugin.Program/Main.cs
@@ -446,7 +446,7 @@ public static void StartProcess(Func<ProcessStartInfo, Process> runProcess, Proc
                 var title = Context.API.GetTranslation("flowlauncher_plugin_program_disable_dlgtitle_error");
                 var message = string.Format(Context.API.GetTranslation("flowlauncher_plugin_program_run_failed"),
                     info.FileName);
-                Context.API.ShowMsg(title, string.Format(message, info.FileName), string.Empty);
+                Context.API.ShowMsgError(title, string.Format(message, info.FileName));
             }
         }
 
diff --git a/Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs b/Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs
@@ -462,7 +462,7 @@ public Result Result(string query, IPublicAPI api)
                         var message =
                             api.GetTranslation(
                                 "flowlauncher_plugin_program_run_as_administrator_not_supported_message");
-                        api.ShowMsg(title, message, string.Empty);
+                        api.ShowMsgError(title, message);
                     }
 
                     return true;
diff --git a/Plugins/Flow.Launcher.Plugin.Shell/Languages/en.xaml b/Plugins/Flow.Launcher.Plugin.Shell/Languages/en.xaml
@@ -1,6 +1,7 @@
-<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
-                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-                    xmlns:system="clr-namespace:System;assembly=mscorlib">
+<ResourceDictionary
+    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+    xmlns:system="clr-namespace:System;assembly=mscorlib">
 
     <system:String x:Key="flowlauncher_plugin_cmd_relace_winr">Replace Win+R</system:String>
     <system:String x:Key="flowlauncher_plugin_cmd_close_cmd_after_press">Close Command Prompt after pressing any key</system:String>
@@ -16,4 +17,6 @@
     <system:String x:Key="flowlauncher_plugin_cmd_run_as_administrator">Run As Administrator</system:String>
     <system:String x:Key="flowlauncher_plugin_cmd_copy">Copy the command</system:String>
     <system:String x:Key="flowlauncher_plugin_cmd_history">Only show number of most used commands:</system:String>
+    <system:String x:Key="flowlauncher_plugin_cmd_command_not_found">Command not found: {0}</system:String>
+    <system:String x:Key="flowlauncher_plugin_cmd_error_running_command">Error running the command: {0}"</system:String>
 </ResourceDictionary>
diff --git a/Plugins/Flow.Launcher.Plugin.Shell/Main.cs b/Plugins/Flow.Launcher.Plugin.Shell/Main.cs
@@ -335,15 +335,17 @@ private void Execute(Func<ProcessStartInfo, Process> startProcess, ProcessStartI
             }
             catch (FileNotFoundException e)
             {
-                var name = "Plugin: Shell";
-                var message = $"Command not found: {e.Message}";
-                Context.API.ShowMsg(name, message);
+                Context.API.ShowMsgError(GetTranslatedPluginTitle(),
+                    string.Format(Context.API.GetTranslation("flowlauncher_plugin_cmd_command_not_found"), e.Message));
             }
             catch (Win32Exception e)
             {
-                var name = "Plugin: Shell";
-                var message = $"Error running the command: {e.Message}";
-                Context.API.ShowMsg(name, message);
+                Context.API.ShowMsgError(GetTranslatedPluginTitle(),
+                    string.Format(Context.API.GetTranslation("flowlauncher_plugin_cmd_error_running_command"), e.Message));
+            }
+            catch (Exception e)
+            {
+                Context.API.LogException(ClassName, $"Error executing command: {info.FileName} {string.Join(" ", info.ArgumentList)}", e);
             }
         }
 
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -70,7 +70,7 @@ public List<Result> Query(Query query)
                             }
                             catch(Exception)
                             {
-                                context.API.ShowMsg(string.Format(context.API.GetTranslation("flowlauncher_plugin_url_cannot_open_url"), raw));
+                                context.API.ShowMsgError(string.Format(context.API.GetTranslation("flowlauncher_plugin_url_cannot_open_url"), raw));
                                 return false;
                             }
                         }

Original file line number	Diff line number	Diff line change
`@@ -719,7 +719,7 @@ internal static async Task<bool> UninstallPluginAsync(PluginMetadata plugin, boo`
`719`	`719`	`catch (Exception e)`
`720`	`720`	`{`
`721`	`721`	`API.LogException(ClassName, $"Failed to delete plugin settings folder for {plugin.Name}", e);`
`722`		`- API.ShowMsg(API.GetTranslation("failedToRemovePluginSettingsTitle"),`
	`722`	`+ API.ShowMsgError(API.GetTranslation("failedToRemovePluginSettingsTitle"),`
`723`	`723`	`string.Format(API.GetTranslation("failedToRemovePluginSettingsMessage"), plugin.Name));`
`724`	`724`	`}`
`725`	`725`	`}`
`@@ -735,7 +735,7 @@ internal static async Task<bool> UninstallPluginAsync(PluginMetadata plugin, boo`
`735`	`735`	`catch (Exception e)`
`736`	`736`	`{`
`737`	`737`	`API.LogException(ClassName, $"Failed to delete plugin cache folder for {plugin.Name}", e);`
`738`		`- API.ShowMsg(API.GetTranslation("failedToRemovePluginCacheTitle"),`
	`738`	`+ API.ShowMsgError(API.GetTranslation("failedToRemovePluginCacheTitle"),`
`739`	`739`	`string.Format(API.GetTranslation("failedToRemovePluginCacheMessage"), plugin.Name));`
`740`	`740`	`}`
`741`	`741`	`Settings.RemovePluginSettings(plugin.ID);`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public async Task UpdateAppAsync(bool silentUpdate = true)`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`if (!silentUpdate)`
`114`		`- _api.ShowMsg(_api.GetTranslation("update_flowlauncher_fail"),`
	`114`	`+ _api.ShowMsgError(_api.GetTranslation("update_flowlauncher_fail"),`
`115`	`115`	`_api.GetTranslation("update_flowlauncher_check_connection"));`
`116`	`116`	`}`
`117`	`117`	`finally`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ var userName when string.IsNullOrEmpty(userName) =>`
`82`	`82`	`}`
`83`	`83`	`catch (UriFormatException e)`
`84`	`84`	`{`
`85`		`- API.ShowMsg(API.GetTranslation("pleaseTryAgain"), API.GetTranslation("parseProxyFailed"));`
	`85`	`+ API.ShowMsgError(API.GetTranslation("pleaseTryAgain"), API.GetTranslation("parseProxyFailed"));`
`86`	`86`	`Log.Exception(ClassName, "Unable to parse Uri", e);`
`87`	`87`	`}`
`88`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ private static void AutoStartup()`
`267`	`267`	`// but if it fails (permissions, etc) then don't keep retrying`
`268`	`268`	`// this also gives the user a visual indication in the Settings widget`
`269`	`269`	`_settings.StartFlowLauncherOnSystemStartup = false;`
`270`		`- API.ShowMsg(API.GetTranslation("setAutoStartFailed"), e.Message);`
	`270`	`+ API.ShowMsgError(API.GetTranslation("setAutoStartFailed"), e.Message);`
`271`	`271`	`}`
`272`	`272`	`}`
`273`	`273`	`}`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ private void ChangeAutoStartup(bool value)`
`59`	`59`	`}`
`60`	`60`	`catch (Exception e)`
`61`	`61`	`{`
`62`		`- App.API.ShowMsg(App.API.GetTranslation("setAutoStartFailed"), e.Message);`
	`62`	`+ App.API.ShowMsgError(App.API.GetTranslation("setAutoStartFailed"), e.Message);`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public bool StartFlowLauncherOnSystemStartup`
`64`	`64`	`}`
`65`	`65`	`catch (Exception e)`
`66`	`66`	`{`
`67`		`- App.API.ShowMsg(App.API.GetTranslation("setAutoStartFailed"), e.Message);`
	`67`	`+ App.API.ShowMsgError(App.API.GetTranslation("setAutoStartFailed"), e.Message);`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`	`}`
`@@ -91,7 +91,7 @@ public bool UseLogonTaskForStartup`
`91`	`91`	`}`
`92`	`92`	`catch (Exception e)`
`93`	`93`	`{`
`94`		`- App.API.ShowMsg(App.API.GetTranslation("setAutoStartFailed"), e.Message);`
	`94`	`+ App.API.ShowMsgError(App.API.GetTranslation("setAutoStartFailed"), e.Message);`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`	`}`
`@@ -217,7 +217,7 @@ public bool LegacyKoreanIMEEnabled`
`217`	`217`	`else`
`218`	`218`	`{`
`219`	`219`	`// Since this is rarely seen text, language support is not provided.`
`220`		`- App.API.ShowMsg(App.API.GetTranslation("KoreanImeSettingChangeFailTitle"), App.API.GetTranslation("KoreanImeSettingChangeFailSubTitle"));`
	`220`	`+ App.API.ShowMsgError(App.API.GetTranslation("KoreanImeSettingChangeFailTitle"), App.API.GetTranslation("KoreanImeSettingChangeFailSubTitle"));`
`221`	`221`	`}`
`222`	`222`	`}`
`223`	`223`	`}`
Original file line number	Diff line number	Diff line change
`@@ -223,11 +223,8 @@ public List<Result> LoadContextMenus(Result selectedResult)`
`223`	`223`	`}`
`224`	`224`	`catch (Exception e)`
`225`	`225`	`{`
`226`		`- var message = "Failed to set url in clipboard";`
`227`		`- _context.API.LogException(ClassName, message, e);`
`228`		`-`
`229`		`- _context.API.ShowMsg(message);`
`230`		`-`
	`226`	`+ _context.API.LogException(ClassName, "Failed to set url in clipboard", e);`
	`227`	`+ _context.API.ShowMsgError(_context.API.GetTranslation("flowlauncher_plugin_browserbookmark_copy_failed"));`
`231`	`228`	`return false;`
`232`	`229`	`}`
`233`	`230`	`},`
Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,8 @@ public List<Result> LoadContextMenus(Result selectedResult)`
`132`	`132`	`}`
`133`	`133`	`catch (Exception e)`
`134`	`134`	`{`
`135`		`- var message = "Fail to set text in clipboard";`
`136`		`- LogException(message, e);`
`137`		`- Context.API.ShowMsg(message);`
	`135`	`+ LogException("Fail to set text in clipboard", e);`
	`136`	`+ Context.API.ShowMsgError(Context.API.GetTranslation("plugin_explorer_fail_to_set_text"));`
`138`	`137`	`return false;`
`139`	`138`	`}`
`140`	`139`	`},`
`@@ -155,9 +154,8 @@ public List<Result> LoadContextMenus(Result selectedResult)`
`155`	`154`	`}`
`156`	`155`	`catch (Exception e)`
`157`	`156`	`{`
`158`		`- var message = "Fail to set text in clipboard";`
`159`		`- LogException(message, e);`
`160`		`- Context.API.ShowMsg(message);`
	`157`	`+ LogException("Fail to set text in clipboard", e);`
	`158`	`+ Context.API.ShowMsgError(Context.API.GetTranslation("plugin_explorer_fail_to_set_text"));`
`161`	`159`	`return false;`
`162`	`160`	`}`
`163`	`161`	`},`
`@@ -178,9 +176,8 @@ public List<Result> LoadContextMenus(Result selectedResult)`
`178`	`176`	`}`
`179`	`177`	`catch (Exception e)`
`180`	`178`	`{`
`181`		`- var message = $"Fail to set file/folder in clipboard";`
`182`		`- LogException(message, e);`
`183`		`- Context.API.ShowMsg(message);`
	`179`	`+ LogException($"Fail to set file/folder in clipboard", e);`
	`180`	`+ Context.API.ShowMsgError(Context.API.GetTranslation("plugin_explorer_fail_to_set_files"));`
`184`	`181`	`return false;`
`185`	`182`	`}`
`186`	`183`