Support enable & disable quick switch

Author: Jack251970

Flow.Launcher.Infrastructure/QuickSwitch/QuickSwitch.cs

@@ -67,91 +67,137 @@ public static class QuickSwitch
         private static HWND _hookedDialogWindowHandle = HWND.Null;
         private static readonly object _hookedDialogWindowHandleLock = new();*/
 
-        private static bool _isInitialized = false;
+        private static bool _initialized = false;
+        private static bool _enabled = false;
 
         #endregion
 
-        #region Initialization
+        #region Initialize & Setup
 
-        public static void Initialize()
+        public static void InitializeQuickSwitch()
         {
-            if (_isInitialized) return;
+            if (_initialized) return;
 
-            // Check all foreground windows and check if there are explorer windows
-            lock (_lastExplorerViewLock)
+            // Initialize main window handle
+            _mainWindowHandle = Win32Helper.GetMainWindowHandle();
+
+            // Initialize timer
+            _dragMoveTimer = new DispatcherTimer { Interval = TimeSpan.FromMilliseconds(10) };
+            _dragMoveTimer.Tick += (s, e) => InvokeUpdateQuickSwitchWindow();
+
+            _initialized = true;
+        }
+
+        public static void SetupQuickSwitch(bool enabled)
+        {
+            if (enabled == _enabled) return;
+
+            if (enabled)
             {
-                var explorerInitialized = false;
-                EnumerateShellWindows((shellWindow) =>
+                // Check all foreground windows and check if there are explorer windows
+                lock (_lastExplorerViewLock)
                 {
-                    if (shellWindow is not IWebBrowser2 explorer)
+                    var explorerInitialized = false;
+                    EnumerateShellWindows((shellWindow) =>
                     {
-                        return;
-                    }
+                        if (shellWindow is not IWebBrowser2 explorer)
+                        {
+                            return;
+                        }
 
-                    // Initialize one explorer window even if it is not foreground
-                    if (!explorerInitialized)
-                    {
-                        _lastExplorerView = explorer;
+                        // Initialize one explorer window even if it is not foreground
+                        if (!explorerInitialized)
+                        {
+                            _lastExplorerView = explorer;
 
-                        Log.Debug(ClassName, $"Explorer Window: {explorer.HWND.Value}");
-                    }
-                    // Force update explorer window if it is foreground
-                    else if (Win32Helper.IsForegroundWindow(explorer.HWND.Value))
-                    {
-                        _lastExplorerView = explorer;
+                            Log.Debug(ClassName, $"Explorer Window: {explorer.HWND.Value}");
+                        }
 
-                        Log.Debug(ClassName, $"Explorer Window: {explorer.HWND.Value}");
-                    }
-                });
-            }
+                        // Force update explorer window if it is foreground
+                        else if (Win32Helper.IsForegroundWindow(explorer.HWND.Value))
+                        {
+                            _lastExplorerView = explorer;
 
-            // Call ForegroundChange when the foreground window changes
-            _foregroundChangeHook = PInvoke.SetWinEventHook(
-                PInvoke.EVENT_SYSTEM_FOREGROUND,
-                PInvoke.EVENT_SYSTEM_FOREGROUND,
-                PInvoke.GetModuleHandle((PCWSTR)null),
-                ForegroundChangeCallback,
-                0,
-                0,
-                PInvoke.WINEVENT_OUTOFCONTEXT);
-
-            // Call LocationChange when the location of the window changes
-            _locationChangeHook = PInvoke.SetWinEventHook(
-                PInvoke.EVENT_OBJECT_LOCATIONCHANGE,
-                PInvoke.EVENT_OBJECT_LOCATIONCHANGE,
-                PInvoke.GetModuleHandle((PCWSTR)null),
-                LocationChangeCallback,
-                0,
-                0,
-                PInvoke.WINEVENT_OUTOFCONTEXT);
-
-            // Call DestroyChange when the window is destroyed
-            _destroyChangeHook = PInvoke.SetWinEventHook(
-                PInvoke.EVENT_OBJECT_DESTROY,
-                PInvoke.EVENT_OBJECT_DESTROY,
-                PInvoke.GetModuleHandle((PCWSTR)null),
-                DestroyChangeCallback,
-                0,
-                0,
-                PInvoke.WINEVENT_OUTOFCONTEXT);
-
-            if (_foregroundChangeHook.IsNull ||
-                _locationChangeHook.IsNull ||
-                _destroyChangeHook.IsNull)
-            {
-                Log.Error(ClassName, "Failed to initialize QuickSwitch");
-                return;
-            }
+                            Log.Debug(ClassName, $"Explorer Window: {explorer.HWND.Value}");
+                        }
+                    });
+                }
 
-            // Initialize main window handle
-            _mainWindowHandle = Win32Helper.GetMainWindowHandle();
+                // Unhook events
+                if (!_foregroundChangeHook.IsNull)
+                {
+                    PInvoke.UnhookWinEvent(_foregroundChangeHook);
+                    _foregroundChangeHook = HWINEVENTHOOK.Null;
+                }
+                if (!_locationChangeHook.IsNull)
+                {
+                    PInvoke.UnhookWinEvent(_locationChangeHook);
+                    _locationChangeHook = HWINEVENTHOOK.Null;
+                }
+                if (!_destroyChangeHook.IsNull)
+                {
+                    PInvoke.UnhookWinEvent(_destroyChangeHook);
+                    _destroyChangeHook = HWINEVENTHOOK.Null;
+                }
 
-            // Initialize timer
-            _dragMoveTimer = new DispatcherTimer { Interval = TimeSpan.FromMilliseconds(10) };
-            _dragMoveTimer.Tick += (s, e) => InvokeUpdateQuickSwitchWindow();
+                // Hook events
+                _foregroundChangeHook = PInvoke.SetWinEventHook(
+                    PInvoke.EVENT_SYSTEM_FOREGROUND,
+                    PInvoke.EVENT_SYSTEM_FOREGROUND,
+                    PInvoke.GetModuleHandle((PCWSTR)null),
+                    ForegroundChangeCallback,
+                    0,
+                    0,
+                    PInvoke.WINEVENT_OUTOFCONTEXT);
+                _locationChangeHook = PInvoke.SetWinEventHook(
+                    PInvoke.EVENT_OBJECT_LOCATIONCHANGE,
+                    PInvoke.EVENT_OBJECT_LOCATIONCHANGE,
+                    PInvoke.GetModuleHandle((PCWSTR)null),
+                    LocationChangeCallback,
+                    0,
+                    0,
+                    PInvoke.WINEVENT_OUTOFCONTEXT);
+                _destroyChangeHook = PInvoke.SetWinEventHook(
+                    PInvoke.EVENT_OBJECT_DESTROY,
+                    PInvoke.EVENT_OBJECT_DESTROY,
+                    PInvoke.GetModuleHandle((PCWSTR)null),
+                    DestroyChangeCallback,
+                    0,
+                    0,
+                    PInvoke.WINEVENT_OUTOFCONTEXT);
+
+                if (_foregroundChangeHook.IsNull ||
+                    _locationChangeHook.IsNull ||
+                    _destroyChangeHook.IsNull)
+                {
+                    Log.Error(ClassName, "Failed to enable QuickSwitch");
+                    return;
+                }
+            }
+            else
+            {
+                // Unhook events
+                if (!_foregroundChangeHook.IsNull)
+                {
+                    PInvoke.UnhookWinEvent(_foregroundChangeHook);
+                    _foregroundChangeHook = HWINEVENTHOOK.Null;
+                }
+                if (!_locationChangeHook.IsNull)
+                {
+                    PInvoke.UnhookWinEvent(_locationChangeHook);
+                    _locationChangeHook = HWINEVENTHOOK.Null;
+                }
+                if (!_destroyChangeHook.IsNull)
+                {
+                    PInvoke.UnhookWinEvent(_destroyChangeHook);
+                    _destroyChangeHook = HWINEVENTHOOK.Null;
+                }
 
-            _isInitialized = true;
-            return;
+                // Stop drag move timer
+                _dragMoveTimer?.Stop();
+            }
+
+            _enabled = enabled;
         }
 
         #endregion
@@ -243,10 +289,7 @@ private static void InvokeHideQuickSwitchWindow()
 
         public static void OnToggleHotkey(object sender, HotkeyEventArgs args)
         {
-            if (_isInitialized)
-            {
-                NavigateDialogPath(Win32Helper.GetForegroundWindowHWND());
-            }
+            NavigateDialogPath(Win32Helper.GetForegroundWindowHWND());
         }
 
         #endregion
@@ -620,10 +663,11 @@ private static unsafe void EnumerateShellWindows(Action<object> action)
 
         public static void Dispose()
         {
-            // Reset initialize flag
-            _isInitialized = false;
+            // Reset flags
+            _enabled = false;
+            _initialized = false;
 
-            // Dispose handle
+            // Unhook events
             if (!_foregroundChangeHook.IsNull)
             {
                 PInvoke.UnhookWinEvent(_foregroundChangeHook);
@@ -646,9 +690,16 @@ public static void Dispose()
             }
 
             // Release ComObjects
-            if (_lastExplorerView != null)
+            try
+            {
+                if (_lastExplorerView != null)
+                {
+                    Marshal.ReleaseComObject(_lastExplorerView);
+                    _lastExplorerView = null;
+                }
+            }
+            catch (COMException)
             {
-                Marshal.ReleaseComObject(_lastExplorerView);
                 _lastExplorerView = null;
             }
 

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -232,7 +232,7 @@ public CustomBrowserViewModel CustomBrowser
 
         public bool EnableQuickSwitch { get; set; } = true;
 
-        // TODO: Due to many issues, this option is removed from FL
+        // TODO: TODO: Due to many issues, this option is removed from FL (see https://github.com/Flow-Launcher/Flow.Launcher/pull/1018)
         public bool AutoQuickSwitch { get; set; } = false;
 
         public bool ShowQuickSwitchWindow { get; set; } = true;

Flow.Launcher/App.xaml.cs

@@ -185,7 +185,8 @@ await API.StopwatchLogInfoAsync(ClassName, "Startup cost", async () =>
                 // main windows needs initialized before theme change because of blur settings
                 Ioc.Default.GetRequiredService<Theme>().ChangeTheme();
 
-                QuickSwitch.Initialize();
+                QuickSwitch.InitializeQuickSwitch();
+                QuickSwitch.SetupQuickSwitch(_settings.EnableQuickSwitch);
 
                 Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
 

Flow.Launcher/Helper/HotKeyMapper.cs

@@ -23,7 +23,10 @@ internal static void Initialize()
         _settings = Ioc.Default.GetService<Settings>();
 
         SetHotkey(_settings.Hotkey, OnToggleHotkey);
-        SetHotkey(_settings.QuickSwitchHotkey, QuickSwitch.OnToggleHotkey);
+        if (_settings.EnableQuickSwitch)
+        {
+            SetHotkey(_settings.QuickSwitchHotkey, QuickSwitch.OnToggleHotkey);
+        }
         LoadCustomPluginHotkey();
     }
 

Flow.Launcher/Languages/en.xaml

@@ -308,6 +308,8 @@
     <system:String x:Key="showBadgesGlobalOnlyToolTip">Show badges for global query results only</system:String>
     <system:String x:Key="quickSwitchHotkey">Quick Switch</system:String>
     <system:String x:Key="quickSwitchHotkeyToolTip">Enter shortcut to quickly navigate the path of a file dialog to the path of the current Explorer.</system:String>
+    <system:String x:Key="quickSwitch">Quick Switch</system:String>
+    <system:String x:Key="quickSwitchToolTip">Quickly navigate to the path of the current Explorer when a file dialog is opened.</system:String>
     <system:String x:Key="autoQuickSwitch">Quick Switch Automatically</system:String>
     <system:String x:Key="autoQuickSwitchToolTip">Quick switch automatically navigate to the path of the current Explorer when a file dialog is opened.</system:String>
     <system:String x:Key="showQuickSwitchWindow">Show Quick Switch Window</system:String>

Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs

@@ -8,6 +8,7 @@
 using Flow.Launcher.Core.Resource;
 using Flow.Launcher.Helper;
 using Flow.Launcher.Infrastructure;
+using Flow.Launcher.Infrastructure.QuickSwitch;
 using Flow.Launcher.Infrastructure.UserSettings;
 using Flow.Launcher.Plugin;
 using Flow.Launcher.Plugin.SharedModels;
@@ -144,6 +145,27 @@ public bool PortableMode
     public List<LastQueryModeData> LastQueryModes { get; } =
         DropdownDataGeneric<LastQueryMode>.GetValues<LastQueryModeData>("LastQuery");
 
+    public bool EnableQuickSwitch
+    {
+        get => Settings.EnableQuickSwitch;
+        set
+        {
+            if (Settings.EnableQuickSwitch != value)
+            {
+                Settings.EnableQuickSwitch = value;
+                QuickSwitch.SetupQuickSwitch(value);
+                if (Settings.EnableQuickSwitch)
+                {
+                    HotKeyMapper.SetHotkey(new(Settings.QuickSwitchHotkey), QuickSwitch.OnToggleHotkey);
+                }
+                else
+                {
+                    HotKeyMapper.RemoveHotkey(Settings.QuickSwitchHotkey);
+                }
+            }
+        }
+    }
+
     public int SearchDelayTimeValue
     {
         get => Settings.SearchDelayTime;

Flow.Launcher/SettingPages/ViewModels/SettingsPaneHotkeyViewModel.cs

@@ -38,7 +38,10 @@ private void SetTogglingHotkey(HotkeyModel hotkey)
     [RelayCommand]
     private void SetQuickSwitchHotkey(HotkeyModel hotkey)
     {
-        HotKeyMapper.SetHotkey(hotkey, QuickSwitch.OnToggleHotkey);
+        if (Settings.EnableQuickSwitch)
+        {
+            HotKeyMapper.SetHotkey(hotkey, QuickSwitch.OnToggleHotkey);
+        }
     }
 
     [RelayCommand]

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

@@ -202,6 +202,40 @@
                 </cc:Card>
             </cc:CardGroup>
 
+            <cc:ExCard
+                Title="{DynamicResource quickSwitch}"
+                Margin="0 14 0 0"
+                Icon="&#xE8AB;"
+                Sub="{DynamicResource quickSwitchToolTip}">
+                <cc:ExCard.SideContent>
+                    <ui:ToggleSwitch
+                        IsOn="{Binding EnableQuickSwitch}"
+                        OffContent="{DynamicResource disable}"
+                        OnContent="{DynamicResource enable}" />
+                </cc:ExCard.SideContent>
+
+                <!--  TODO: Due to many issues, this option is removed from FL (see https://github.com/Flow-Launcher/Flow.Launcher/pull/1018)  -->
+                <!--<cc:Card
+                    Title="{DynamicResource autoQuickSwitch}"
+                    Sub="{DynamicResource autoQuickSwitchToolTip}"
+                    Type="InsideFit">
+                    <ui:ToggleSwitch
+                        IsOn="{Binding Settings.AutoQuickSwitch}"
+                        OffContent="{DynamicResource disable}"
+                        OnContent="{DynamicResource enable}" />
+                </cc:Card>-->
+
+                <cc:Card
+                    Title="{DynamicResource showQuickSwitchWindow}"
+                    Sub="{DynamicResource showQuickSwitchWindowToolTip}"
+                    Type="InsideFit">
+                    <ui:ToggleSwitch
+                        IsOn="{Binding Settings.ShowQuickSwitchWindow}"
+                        OffContent="{DynamicResource disable}"
+                        OnContent="{DynamicResource enable}" />
+                </cc:Card>
+            </cc:ExCard>
+
             <cc:ExCard
                 Title="{DynamicResource searchDelay}"
                 Margin="0 14 0 0"