Skip to content

Commit c142a50

Browse files
committed
update unit test naming, no logic changes
1 parent c363b9a commit c142a50

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

Flow.Launcher.Test/FuzzyMatcherTest.cs

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void MatchTest()
7777
}
7878

7979
[TestCase("Chrome")]
80-
public void WhenGivenNotAllCharactersFoundInSearchStringThenShouldReturnZeroScore(string searchString)
80+
public void WhenNotAllCharactersFoundInSearchString_ThenShouldReturnZeroScore(string searchString)
8181
{
8282
var compareString = "Can have rum only in my glass";
8383
var matcher = new StringMatcher();
@@ -92,7 +92,7 @@ public void WhenGivenNotAllCharactersFoundInSearchStringThenShouldReturnZeroScor
9292
[TestCase("cand")]
9393
[TestCase("cpywa")]
9494
[TestCase("ccs")]
95-
public void WhenGivenStringsAndAppliedPrecisionFilteringThenShouldReturnGreaterThanPrecisionScoreResults(string searchTerm)
95+
public void GivenQueryString_WhenAppliedPrecisionFiltering_ThenShouldReturnGreaterThanPrecisionScoreResults(string searchTerm)
9696
{
9797
var results = new List<Result>();
9898
var matcher = new StringMatcher();
@@ -107,7 +107,10 @@ public void WhenGivenStringsAndAppliedPrecisionFilteringThenShouldReturnGreaterT
107107

108108
foreach (var precisionScore in GetPrecisionScores())
109109
{
110-
var filteredResult = results.Where(result => result.Score >= precisionScore).Select(result => result).OrderByDescending(x => x.Score).ToList();
110+
var filteredResult = results.Where(result => result.Score >= precisionScore)
111+
.Select(result => result)
112+
.OrderByDescending(x => x.Score)
113+
.ToList();
111114

112115
Debug.WriteLine("");
113116
Debug.WriteLine("###############################################");
@@ -130,14 +133,16 @@ public void WhenGivenStringsAndAppliedPrecisionFilteringThenShouldReturnGreaterT
130133
[TestCase(Chrome, CandyCrushSagaFromKing, 0)]
131134
[TestCase("sql", MicrosoftSqlServerManagementStudio, 110)]
132135
[TestCase("sql manag", MicrosoftSqlServerManagementStudio, 121)]//double spacing intended
133-
public void WhenGivenQueryStringThenShouldReturnCurrentScoring(string queryString, string compareString, int expectedScore)
136+
public void WhenGivenQueryString_ThenShouldReturn_TheDesiredScoring(
137+
string queryString, string compareString, int expectedScore)
134138
{
135139
// When, Given
136140
var matcher = new StringMatcher();
137141
var rawScore = matcher.FuzzyMatch(queryString, compareString).RawScore;
138142

139143
// Should
140-
Assert.AreEqual(expectedScore, rawScore, $"Expected score for compare string '{compareString}': {expectedScore}, Actual: {rawScore}");
144+
Assert.AreEqual(expectedScore, rawScore,
145+
$"Expected score for compare string '{compareString}': {expectedScore}, Actual: {rawScore}");
141146
}
142147

143148
[TestCase("goo", "Google Chrome", StringMatcher.SearchPrecisionScore.Regular, true)]
@@ -150,7 +155,7 @@ public void WhenGivenQueryStringThenShouldReturnCurrentScoring(string queryStrin
150155
[TestCase("ccs", "Candy Crush Saga from King", StringMatcher.SearchPrecisionScore.Low, true)]
151156
[TestCase("cand", "Candy Crush Saga from King",StringMatcher.SearchPrecisionScore.Regular, true)]
152157
[TestCase("cand", "Help cure hope raise on mind entity Chrome", StringMatcher.SearchPrecisionScore.Regular, false)]
153-
public void WhenGivenDesiredPrecisionThenShouldReturnAllResultsGreaterOrEqual(
158+
public void WhenGivenDesiredPrecision_ThenShouldReturn_AllResultsGreaterOrEqual(
154159
string queryString,
155160
string compareString,
156161
StringMatcher.SearchPrecisionScore expectedPrecisionScore,
@@ -199,7 +204,7 @@ public void WhenGivenDesiredPrecisionThenShouldReturnAllResultsGreaterOrEqual(
199204
[TestCase("cod", VisualStudioCode, StringMatcher.SearchPrecisionScore.Regular, true)]
200205
[TestCase("code", VisualStudioCode, StringMatcher.SearchPrecisionScore.Regular, true)]
201206
[TestCase("codes", "Visual Studio Codes", StringMatcher.SearchPrecisionScore.Regular, true)]
202-
public void WhenGivenQueryShouldReturnResultsContainingAllQuerySubstrings(
207+
public void WhenGivenQuery_ShouldReturnResults_ContainingAllQuerySubstrings(
203208
string queryString,
204209
string compareString,
205210
StringMatcher.SearchPrecisionScore expectedPrecisionScore,
@@ -229,7 +234,8 @@ public void WhenGivenQueryShouldReturnResultsContainingAllQuerySubstrings(
229234
[TestCase("man", "Task Manager", "eManual")]
230235
[TestCase("term", "Windows Terminal", "Character Map")]
231236
[TestCase("winterm", "Windows Terminal", "Cygwin64 Terminal")]
232-
public void WhenGivenAQueryResultsShouldGiveMoreScoreWeightToStartOfNewWord(string queryString, string compareString1, string compareString2)
237+
public void WhenGivenAQuery_Scoring_ShouldGiveMoreWeightToStartOfNewWord(
238+
string queryString, string compareString1, string compareString2)
233239
{
234240
// When
235241
var matcher = new StringMatcher { UserSettingSearchPrecision = StringMatcher.SearchPrecisionScore.Regular };

0 commit comments

Comments
 (0)