add translation method for messages

Author: jjw24

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml

@@ -6,7 +6,13 @@
     <system:String x:Key="plugin_pluginsmanager_downloading_plugin">Downloading plugin</system:String>
     <system:String x:Key="plugin_pluginsmanager_please_wait">Please wait...</system:String>
     <system:String x:Key="plugin_pluginsmanager_download_success">Successfully downloaded</system:String>
-    <system:String x:Key="plugin_pluginsmanager_uninstall_prompt">Do you want to uninstall the following plugin?</system:String>
+    <system:String x:Key="plugin_pluginsmanager_uninstall_prompt">Do you want to uninstall the following plugin?{0}{1}{2} by {3}</system:String>
+    <system:String x:Key="plugin_pluginsmanager_install_prompt">Do you want to install the following plugin?{0}{1}{2} by {3}</system:String>
+    <system:String x:Key="plugin_pluginsmanager_install_title">Plugin Install</system:String>
+    <system:String x:Key="plugin_pluginsmanager_uninstall_title">Plugin Uninstall</system:String>
+    <system:String x:Key="plugin_pluginsmanager_install_errormetadatafile">Install failed: unable to find the plugin.json metadata file from the new plugin</system:String>
+    <system:String x:Key="plugin_pluginsmanager_install_successandrestart">You have installed plugin {0} successfully.{1}Would you like to restart Flow Launcher to take effect?</system:String>
+    <system:String x:Key="plugin_pluginsmanager_uninstall_successandrestart">You have uninstalled plugin {0} successfully.{1}Would you like to restart Flow Launcher to take effect?</system:String>
     <!--Controls-->
 
     <!--Plugin Infos-->

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

@@ -24,28 +24,26 @@ internal PluginsManager(PluginInitContext context)
         }
         internal void InstallOrUpdate(UserPlugin plugin)
         {
-            if (PluginExists(plugin.ID))
+            if (PluginExists(plugin.ID)) 
             {
-                var updateMessage = $"Do you want to update following plugin?{Environment.NewLine}{Environment.NewLine}" +
-                          $"Name: {plugin.Name}{Environment.NewLine}" +
-                          $"{Environment.NewLine}New Version: {plugin.Version}" +
-                          $"{Environment.NewLine}Author: {plugin.Author}";
-
-                throw new NotImplementedException();
+                Context.API.ShowMsg("Plugin already installed");
+                return;
             }
 
-             var message = $"Do you want to install following plugin?{Environment.NewLine}{Environment.NewLine}" +
-                           $"Name: {plugin.Name}{Environment.NewLine}" +
-                           $"Version: {plugin.Version}{Environment.NewLine}" +
-                           $"Author: {plugin.Author}";
+            var message = string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_prompt"), 
+                                                                        Environment.NewLine, Environment.NewLine, 
+                                                                        plugin.Name, plugin.Author);
 
-            if(MessageBox.Show(message, "Install plugin", MessageBoxButton.YesNo) == MessageBoxResult.No)
+            if(MessageBox.Show(message, Context.API.GetTranslation("plugin_pluginsmanager_install_title"), MessageBoxButton.YesNo) == MessageBoxResult.No)
                 return;
 
             var filePath = Path.Combine(DataLocation.PluginsDirectory, $"{plugin.Name}{plugin.ID}.zip");
 
             try
             {
+                Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"),
+                                    Context.API.GetTranslation("plugin_pluginsmanager_please_wait"));
+
                 Utilities.Download(plugin.UrlDownload, filePath);
 
                 Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"),
@@ -103,8 +101,6 @@ internal List<Result> RequestInstallOrUpdate(string searchName)
                             IcoPath = icoPath,
                             Action = e =>
                             {
-                                Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"),
-                                    Context.API.GetTranslation("plugin_pluginsmanager_please_wait"));
                                 Application.Current.MainWindow.Hide();
                                 InstallOrUpdate(x);
 
@@ -142,17 +138,18 @@ private void Install(UserPlugin plugin, string downloadedFilePath)
 
             if (string.IsNullOrEmpty(metadataJsonFilePath) || string.IsNullOrEmpty(pluginFolderPath))
             {
-                MessageBox.Show("Install failed: unable to find the plugin.json metadata file from the new plugin");
+                MessageBox.Show(Context.API.GetTranslation("plugin_pluginsmanager_install_errormetadatafile"));
                 return;
             }
 
             string newPluginPath = Path.Combine(DataLocation.PluginsDirectory, $"{plugin.Name}{plugin.ID}");
 
             Directory.Move(pluginFolderPath, newPluginPath);
 
-            if (MessageBox.Show($"You have installed plugin {plugin.Name} successfully.{Environment.NewLine}" +
-                                "Restart Flow Launcher to take effect?",
-                                "Install plugin", MessageBoxButton.YesNo, MessageBoxImage.Question) == MessageBoxResult.Yes)
+            if (MessageBox.Show(string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_successandrestart"), 
+                                                                            plugin.Name, Environment.NewLine),
+                                    Context.API.GetTranslation("plugin_pluginsmanager_install_title"), 
+                                                                MessageBoxButton.YesNo, MessageBoxImage.Question) == MessageBoxResult.Yes)
                 Context.API.RestartApp();
         }
 
@@ -181,18 +178,19 @@ internal List<Result> RequestUninstall(string search)
 
         private void Uninstall(PluginMetadata plugin)
         {
-            string message = Context.API.GetTranslation("plugin_pluginsmanager_uninstall_prompt")+
-                                            $"{Environment.NewLine}{Environment.NewLine}" +
-                                            $"{plugin.Name} by {plugin.Author}";
+            string message = string.Format(Context.API.GetTranslation("plugin_pluginsmanager_uninstall_prompt"),
+                                                                        Environment.NewLine, Environment.NewLine,
+                                                                        plugin.Name, plugin.Author);
 
-            if (MessageBox.Show(message, "Flow Launcher", MessageBoxButton.YesNo) == MessageBoxResult.Yes)
+            if (MessageBox.Show(message, Context.API.GetTranslation("plugin_pluginsmanager_uninstall_title"), 
+                                                                        MessageBoxButton.YesNo) == MessageBoxResult.Yes)
             {
                 using var _ = File.CreateText(Path.Combine(plugin.PluginDirectory, "NeedDelete.txt"));
 
-                var result = MessageBox.Show($"You have uninstalled plugin {plugin.Name} successfully.{Environment.NewLine}" +
-                                             "Restart Flow Launcher to take effect?",
-                                             "Install plugin", MessageBoxButton.YesNo, MessageBoxImage.Question);
-                if (result == MessageBoxResult.Yes)
+                if (MessageBox.Show(string.Format(Context.API.GetTranslation("plugin_pluginsmanager_uninstall_successandrestart"),
+                                                                            plugin.Name, Environment.NewLine),
+                                    Context.API.GetTranslation("plugin_pluginsmanager_uninstall_title"),
+                                                                MessageBoxButton.YesNo, MessageBoxImage.Question) == MessageBoxResult.Yes)
                     Context.API.RestartApp();
             }
         }