Skip to content

Commit d106c51

Browse files
committed
Fix IsEnabled logic
1 parent 175571a commit d106c51

File tree

3 files changed

+13
-30
lines changed

3 files changed

+13
-30
lines changed

Plugins/Flow.Launcher.Plugin.Shell/Converters/CloseShellAfterPressEnabledConverter.cs

Lines changed: 0 additions & 22 deletions
This file was deleted.

Plugins/Flow.Launcher.Plugin.Shell/Converters/LeaveShellOpenEnabledConverter.cs renamed to Plugins/Flow.Launcher.Plugin.Shell/Converters/LeaveShellOpenOrCloseShellAfterPressEnabledConverter.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@
44

55
namespace Flow.Launcher.Plugin.Shell.Converters;
66

7-
public class LeaveShellOpenEnabledConverter : IMultiValueConverter
7+
public class LeaveShellOpenOrCloseShellAfterPressEnabledConverter : IMultiValueConverter
88
{
99
public object Convert(object[] values, Type targetType, object parameter, CultureInfo culture)
1010
{
1111
if (
1212
values.Length != 2 ||
13-
values[0] is not bool closeShellAfterPress ||
13+
values[0] is not bool closeShellAfterPressOrLeaveShellOpen ||
1414
values[1] is not Shell shell
1515
)
1616
return Binding.DoNothing;
1717

18-
return (!closeShellAfterPress) && shell != Shell.RunCommand;
18+
return (!closeShellAfterPressOrLeaveShellOpen) && shell != Shell.RunCommand;
1919
}
2020

2121
public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)

Plugins/Flow.Launcher.Plugin.Shell/Views/ShellSetting.xaml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
d:DesignWidth="300"
1212
mc:Ignorable="d">
1313
<UserControl.Resources>
14-
<converters:CloseShellAfterPressEnabledConverter x:Key="CloseShellAfterPressEnabledConverter" />
15-
<converters:LeaveShellOpenEnabledConverter x:Key="LeaveShellOpenEnabledConverter" />
14+
<converters:LeaveShellOpenOrCloseShellAfterPressEnabledConverter x:Key="LeaveShellOpenOrCloseShellAfterPressEnabledConverter" />
1615
</UserControl.Resources>
1716

1817
<Grid Margin="{StaticResource SettingPanelMargin}" VerticalAlignment="Top">
@@ -38,8 +37,14 @@
3837
Margin="{StaticResource SettingPanelItemRightTopBottomMargin}"
3938
HorizontalAlignment="Left"
4039
Content="{DynamicResource flowlauncher_plugin_cmd_close_cmd_after_press}"
41-
IsChecked="{Binding CloseShellAfterPress, Mode=TwoWay}"
42-
IsEnabled="{Binding LeaveShellOpen, Converter={StaticResource CloseShellAfterPressEnabledConverter}, Mode=OneWay}" />
40+
IsChecked="{Binding CloseShellAfterPress, Mode=TwoWay}">
41+
<CheckBox.IsEnabled>
42+
<MultiBinding Converter="{StaticResource LeaveShellOpenOrCloseShellAfterPressEnabledConverter}">
43+
<Binding Mode="OneWay" Path="LeaveShellOpen" />
44+
<Binding Mode="OneWay" Path="SelectedShell" />
45+
</MultiBinding>
46+
</CheckBox.IsEnabled>
47+
</CheckBox>
4348
<CheckBox
4449
x:Name="LeaveShellOpen"
4550
Grid.Row="2"
@@ -48,7 +53,7 @@
4853
Content="{DynamicResource flowlauncher_plugin_cmd_leave_cmd_open}"
4954
IsChecked="{Binding LeaveShellOpen, Mode=TwoWay}">
5055
<CheckBox.IsEnabled>
51-
<MultiBinding Converter="{StaticResource LeaveShellOpenEnabledConverter}">
56+
<MultiBinding Converter="{StaticResource LeaveShellOpenOrCloseShellAfterPressEnabledConverter}">
5257
<Binding Mode="OneWay" Path="CloseShellAfterPress" />
5358
<Binding Mode="OneWay" Path="SelectedShell" />
5459
</MultiBinding>

0 commit comments

Comments
 (0)