Improve constructor injection for updater

Author: Jack251970

Flow.Launcher.Core/Updater.cs

@@ -24,15 +24,11 @@ public class Updater
     {
         private readonly IPublicAPI API;
 
-        public string GitHubRepository { get; set; }
+        public string GitHubRepository { get; init; }
 
-        public Updater(IPublicAPI publicAPI)
+        public Updater(IPublicAPI publicAPI, string gitHubRepository)
         {
             API = publicAPI;
-        }
-
-        public void Initialize(string gitHubRepository)
-        {
             GitHubRepository = gitHubRepository;
         }
 

Flow.Launcher/App.xaml.cs

@@ -45,7 +45,7 @@ public App()
                 .UseContentRoot(AppContext.BaseDirectory)
                 .ConfigureServices(services => services
                     .AddSingleton(_ => _settings)
-                    .AddSingleton(sp => new Updater(sp.GetRequiredService<IPublicAPI>()))
+                    .AddSingleton(sp => new Updater(sp.GetRequiredService<IPublicAPI>(), Launcher.Properties.Settings.Default.GithubRepo))
                     .AddSingleton<Portable>()
                     .AddSingleton<SettingWindowViewModel>()
                     .AddSingleton<IAlphabet, PinyinAlphabet>()
@@ -79,8 +79,6 @@ private async void OnStartupAsync(object sender, StartupEventArgs e)
         {
             await Stopwatch.NormalAsync("|App.OnStartup|Startup cost", async () =>
             {
-                Ioc.Default.GetRequiredService<Updater>().Initialize(Launcher.Properties.Settings.Default.GithubRepo);
-
                 Ioc.Default.GetRequiredService<Portable>().PreStartCleanUpAfterPortabilityUpdate();
 
                 Log.Info("|App.OnStartup|Begin Flow Launcher startup ----------------------------------------------------");