Merge pull request #538 from taooceros/ContextMenuNullCheck

jjw24 · web-flow · commit d6ec4b51d5b6 · 2021-07-01T19:44:01.000+10:00
fix unintended use of direct startInfo.Arguments in context menu
diff --git a/Flow.Launcher.Core/Plugin/PythonPlugin.cs b/Flow.Launcher.Core/Plugin/PythonPlugin.cs
@@ -61,7 +61,7 @@ protected override string ExecuteContextMenu(Result selectedResult)
             {
                 Method = "context_menu", Parameters = new object[] {selectedResult.ContextData},
             };
-            _startInfo.Arguments = $"-B \"{context.CurrentPluginMetadata.ExecuteFilePath}\" \"{request}\"";
+            _startInfo.ArgumentList[2] = request.ToString();
             _startInfo.WorkingDirectory = context.CurrentPluginMetadata.PluginDirectory;
 
             // TODO: Async Action

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ protected override string ExecuteContextMenu(Result selectedResult)`
`61`	`61`	`{`
`62`	`62`	`Method = "context_menu", Parameters = new object[] {selectedResult.ContextData},`
`63`	`63`	`};`
`64`		`- _startInfo.Arguments = $"-B \"{context.CurrentPluginMetadata.ExecuteFilePath}\" \"{request}\"";`
	`64`	`+ _startInfo.ArgumentList[2] = request.ToString();`
`65`	`65`	`_startInfo.WorkingDirectory = context.CurrentPluginMetadata.PluginDirectory;`
`66`	`66`
`67`	`67`	`// TODO: Async Action`