Skip to content

Commit d7d3549

Browse files
committed
Improve code quality
1 parent 071b75b commit d7d3549

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

Flow.Launcher.Infrastructure/TranslationMapping.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@ public class TranslationMapping
1111
// list[i] is the last translated index + 1 of original index i
1212
private readonly List<int> _originalToTranslated = new();
1313

14-
1514
public void AddNewIndex(int translatedIndex, int length)
1615
{
1716
if (_isConstructed)
1817
throw new InvalidOperationException("Mapping shouldn't be changed after construction");
19-
2018
_originalToTranslated.Add(translatedIndex + length);
2119
}
2220

Flow.Launcher.Test/TranslationMappingTest.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
using Flow.Launcher.Infrastructure;
1+
using System.Collections.Generic;
2+
using System.Reflection;
3+
using Flow.Launcher.Infrastructure;
24
using NUnit.Framework;
35
using NUnit.Framework.Legacy;
46

@@ -34,22 +36,21 @@ public void MapToOriginalIndex_ShouldReturnExpectedIndex(int translatedIndex, in
3436
mapping.AddNewIndex(2, 2);
3537
mapping.AddNewIndex(5, 3);
3638

37-
3839
var result = mapping.MapToOriginalIndex(translatedIndex);
3940
ClassicAssert.AreEqual(expectedOriginalIndex, result);
4041
}
4142

42-
private int GetOriginalToTranslatedCount(TranslationMapping mapping)
43+
private static int GetOriginalToTranslatedCount(TranslationMapping mapping)
4344
{
44-
var field = typeof(TranslationMapping).GetField("originalToTranslated", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
45-
var list = (System.Collections.Generic.List<int>)field.GetValue(mapping);
45+
var field = typeof(TranslationMapping).GetField("originalToTranslated", BindingFlags.NonPublic | BindingFlags.Instance);
46+
var list = (List<int>)field.GetValue(mapping);
4647
return list.Count;
4748
}
4849

49-
private int GetOriginalToTranslatedAt(TranslationMapping mapping, int index)
50+
private static int GetOriginalToTranslatedAt(TranslationMapping mapping, int index)
5051
{
51-
var field = typeof(TranslationMapping).GetField("originalToTranslated", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
52-
var list = (System.Collections.Generic.List<int>)field.GetValue(mapping);
52+
var field = typeof(TranslationMapping).GetField("originalToTranslated", BindingFlags.NonPublic | BindingFlags.Instance);
53+
var list = (List<int>)field.GetValue(mapping);
5354
return list[index];
5455
}
5556
}

0 commit comments

Comments
 (0)