Remove unneccessary api, rename storage api, and update comment

Author: taooceros

Flow.Launcher.Plugin/IPublicAPI.cs

@@ -165,30 +165,20 @@ public interface IPublicAPI
         void LogException(string className, string message, Exception e, [CallerMemberName] string methodName = "");
 
         /// <summary>
-        /// Load JsonStorage for current plugin. This is the method used to load settings from json in Flow.
+        /// Load JsonStorage for current plugin's setting. This is the method used to load settings from json in Flow.
         /// When the file is not exist, it will create a new instance for the specific type.
         /// </summary>
         /// <typeparam name="T">Type for deserialization</typeparam>
         /// <returns></returns>
-        T LoadJsonStorage<T>() where T : new();
+        T LoadSettingJsonStorage<T>() where T : new();
 
         /// <summary>
-        /// Save JsonStorage for current plugin. This is the method used to save settings to json in Flow.Launcher
+        /// Save JsonStorage for current plugin's setting. This is the method used to save settings to json in Flow.Launcher
         /// This method will save the original instance loaded with LoadJsonStorage.
+        /// This API call is for manually Save. Flow will automatically save all setting that has registered. 
         /// </summary>
         /// <typeparam name="T">Type for Serialization</typeparam>
         /// <returns></returns>
-        void SaveJsonStorage<T>() where T : new();
-
-        /// <summary>
-        /// Save JsonStorage for current plugin. This is the method used to save settings to json in Flow.Launcher
-        /// This method will override the original class instance loaded from LoadJsonStorage
-        /// This method allows registering a type with provided instance so that it won't create a new one.
-        /// Only use it when you would like to create a new instance of the type instance and overwrite the original one
-        ///     stored before.
-        /// </summary>
-        /// <typeparam name="T">Type for Serialization</typeparam>
-        /// <returns></returns>
-        void SaveJsonStorage<T>(T settings) where T : new();
+        void SaveSettingJsonStorage<T>() where T : new();
     }
 }

Flow.Launcher/PublicAPIInstance.cs

@@ -145,7 +145,7 @@ private void SaveAllJsonStorage()
             }
         }
 
-        public T LoadJsonStorage<T>() where T : new()
+        public T LoadSettingJsonStorage<T>() where T : new()
         {
             var type = typeof(T);
             if (!_pluginJsonStorages.ContainsKey(type))
@@ -154,7 +154,7 @@ private void SaveAllJsonStorage()
             return ((PluginJsonStorage<T>) _pluginJsonStorages[type]).Load();
         }
 
-        public void SaveJsonStorage<T>() where T : new()
+        public void SaveSettingJsonStorage<T>() where T : new()
         {
             var type = typeof(T);
             if (!_pluginJsonStorages.ContainsKey(type))

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs

@@ -24,7 +24,7 @@ public void Init(PluginInitContext context)
         {
             this.context = context;
 
-            _settings = context.API.LoadJsonStorage<Settings>();
+            _settings = context.API.LoadSettingJsonStorage<Settings>();
 
             cachedBookmarks = Bookmarks.LoadAllBookmarks();
         }

Plugins/Flow.Launcher.Plugin.Calculator/Main.cs

@@ -33,7 +33,7 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider
         public void Init(PluginInitContext context)
         {
             Context = context;
-            _settings = context.API.LoadJsonStorage<Settings>();
+            _settings = context.API.LoadSettingJsonStorage<Settings>();
             _viewModel = new SettingsViewModel(_settings);
 
             MagesEngine = new Engine(new Configuration

Plugins/Flow.Launcher.Plugin.Explorer/Main.cs

@@ -32,7 +32,7 @@ public async Task InitAsync(PluginInitContext context)
         {
             Context = context;
 
-            Settings = context.API.LoadJsonStorage<Settings>();
+            Settings = context.API.LoadSettingJsonStorage<Settings>();
 
             viewModel = new SettingsViewModel(context, Settings);
 

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

@@ -22,7 +22,7 @@ public SettingsViewModel(PluginInitContext context, Settings settings)
 
         public void Save()
         {
-            Context.API.SaveJsonStorage<Settings>();
+            Context.API.SaveSettingJsonStorage<Settings>();
         }
 
         internal void RemoveLinkFromQuickAccess(AccessLink selectedRow) => Settings.QuickAccessLinks.Remove(selectedRow);

Plugins/Flow.Launcher.Plugin.PluginsManager/Main.cs

@@ -34,7 +34,7 @@ public Control CreateSettingPanel()
         public Task InitAsync(PluginInitContext context)
         {
             Context = context;
-            Settings = context.API.LoadJsonStorage<Settings>();
+            Settings = context.API.LoadSettingJsonStorage<Settings>();
             viewModel = new SettingsViewModel(context, Settings);
             contextMenu = new ContextMenu(Context);
             pluginManager = new PluginsManager(Context, Settings);

Plugins/Flow.Launcher.Plugin.Program/Main.cs

@@ -69,7 +69,7 @@ public async Task InitAsync(PluginInitContext context)
         {
             _context = context;
 
-            _settings = context.API.LoadJsonStorage<Settings>();
+            _settings = context.API.LoadSettingJsonStorage<Settings>();
 
             await Task.Yield();
 

Plugins/Flow.Launcher.Plugin.Shell/Main.cs

@@ -272,7 +272,7 @@ public void Init(PluginInitContext context)
         {
             this.context = context;
             context.API.GlobalKeyboardEvent += API_GlobalKeyboardEvent;
-            _settings = context.API.LoadJsonStorage<Settings>();
+            _settings = context.API.LoadSettingJsonStorage<Settings>();
         }
 
         bool API_GlobalKeyboardEvent(int keyevent, int vkcode, SpecialKeyState state)

Plugins/Flow.Launcher.Plugin.Url/Main.cs

@@ -118,7 +118,7 @@ public void Init(PluginInitContext context)
         {
             this.context = context;
 
-            _settings = context.API.LoadJsonStorage<Settings>();
+            _settings = context.API.LoadSettingJsonStorage<Settings>();
         }
 
         public string GetTranslatedPluginTitle()