Clean up codes

Author: Jack251970

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -297,6 +297,7 @@ public bool HideNotifyIcon
         [JsonIgnore]
         public bool WMPInstalled { get; set; } = true;
 
+        public bool SelectAllQueryOnReopen { get; set; } = true;
 
         // This needs to be loaded last by staying at the bottom
         public PluginsSettings PluginSettings { get; set; } = new PluginsSettings();

Flow.Launcher/MainWindow.xaml

@@ -20,7 +20,6 @@
     Closing="OnClosing"
     Deactivated="OnDeactivated"
     Icon="Images/app.png"
-    SourceInitialized="OnSourceInitialized"
     Initialized="OnInitialized"
     Left="{Binding Settings.WindowLeft, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
     Loaded="OnLoaded"
@@ -31,6 +30,7 @@
     ResizeMode="CanResize"
     ShowInTaskbar="False"
     SizeToContent="Height"
+    SourceInitialized="OnSourceInitialized"
     Topmost="True"
     Visibility="{Binding MainWindowVisibility, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
     WindowStartupLocation="Manual"
@@ -240,13 +240,13 @@
                             FontSize="{Binding QueryBoxFontSize, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
                             InputMethod.PreferredImeConversionMode="{Binding StartWithEnglishMode, Converter={StaticResource BoolToIMEConversionModeConverter}}"
                             InputMethod.PreferredImeState="{Binding StartWithEnglishMode, Converter={StaticResource BoolToIMEStateConverter}}"
+                            Loaded="SelectAllQueryText"
                             PreviewDragOver="OnPreviewDragOver"
                             PreviewKeyUp="QueryTextBox_KeyUp"
                             Style="{DynamicResource QueryBoxStyle}"
                             Text="{Binding QueryText, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
                             Visibility="Visible"
-                            WindowChrome.IsHitTestVisibleInChrome="True"
-                            Loaded="SelectAllQueryText">
+                            WindowChrome.IsHitTestVisibleInChrome="True">
                             <TextBox.CommandBindings>
                                 <CommandBinding Command="ApplicationCommands.Copy" Executed="OnCopy" />
                             </TextBox.CommandBindings>

Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs

@@ -24,7 +24,6 @@ public SettingsPaneGeneralViewModel(Settings settings, Updater updater, IPortabl
         _updater = updater;
         _portable = portable;
         UpdateEnumDropdownLocalizations();
-        SelectAllQueryOnReopen = settings.SelectAllQueryOnReopen; // Pfa33
     }
 
     public class SearchWindowScreenData : DropdownDataGeneric<SearchWindowScreens> { }
@@ -65,12 +64,6 @@ public bool StartFlowLauncherOnSystemStartup
         }
     }
 
-    public bool SelectAllQueryOnReopen
-    {
-        get => Settings.SelectAllQueryOnReopen;
-        set => Settings.SelectAllQueryOnReopen = value;
-    }
-    
     public bool UseLogonTaskForStartup
     {
         get => Settings.UseLogonTaskForStartup;

Flow.Launcher/SettingWindow.xaml.cs

@@ -47,13 +47,6 @@ private void OnLoaded(object sender, RoutedEventArgs e)
         hwndTarget.RenderMode = RenderMode.SoftwareOnly;  // Must use software only render mode here
 
         InitializePosition();
-
-        // Initialize the new checkbox based on the settings
-        var selectAllQueryOnReopenCheckbox = (System.Windows.Controls.CheckBox)FindName("SelectAllQueryOnReopenCheckbox");
-        if (selectAllQueryOnReopenCheckbox != null)
-        {
-            selectAllQueryOnReopenCheckbox.IsChecked = _settings.SelectAllQueryOnReopen;
-        }
     }
 
     private void OnClosed(object sender, EventArgs e)