Fix ShouldTranslate() logic

VictoriousRaptor · VictoriousRaptor · commit ebcd7d591552 · 2025-07-13T19:01:59.000+08:00
- Check settings or it won't work  as expected
diff --git a/Flow.Launcher.Infrastructure/PinyinAlphabet.cs b/Flow.Launcher.Infrastructure/PinyinAlphabet.cs
@@ -77,7 +77,7 @@ private void LoadDoublePinyinTable()
         public bool ShouldTranslate(string stringToTranslate)
         {
             // If a string has Chinese characters, we don't need to translate it to pinyin.
-            return !WordsHelper.HasChinese(stringToTranslate);
+            return _settings.ShouldUsePinyin && !WordsHelper.HasChinese(stringToTranslate);
         }
 
         public (string translation, TranslationMapping map) Translate(string content)

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ private void LoadDoublePinyinTable()`
`77`	`77`	`public bool ShouldTranslate(string stringToTranslate)`
`78`	`78`	`{`
`79`	`79`	`// If a string has Chinese characters, we don't need to translate it to pinyin.`
`80`		`- return !WordsHelper.HasChinese(stringToTranslate);`
	`80`	`+ return _settings.ShouldUsePinyin && !WordsHelper.HasChinese(stringToTranslate);`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`public (string translation, TranslationMapping map) Translate(string content)`