Initialize App.API earlier & Improve code quality

Author: Jack251970

Flow.Launcher/App.xaml.cs

@@ -70,6 +70,8 @@ await Stopwatch.NormalAsync("|App.OnStartup|Startup cost", async () =>
                     ).Build();
                 Ioc.Default.ConfigureServices(host.Services);
 
+                API = Ioc.Default.GetRequiredService<IPublicAPI>();
+
                 Ioc.Default.GetRequiredService<Updater>().Initialize(Launcher.Properties.Settings.Default.GithubRepo);
 
                 Ioc.Default.GetRequiredService<Portable>().PreStartCleanUpAfterPortabilityUpdate();
@@ -93,9 +95,6 @@ await Stopwatch.NormalAsync("|App.OnStartup|Startup cost", async () =>
 
                 PluginManager.LoadPlugins(_settings.PluginSettings);
 
-                API = Ioc.Default.GetRequiredService<IPublicAPI>();
-                ((PublicAPIInstance)API).Initialize();
-
                 Http.API = API;
                 Http.Proxy = _settings.Proxy;
 

Flow.Launcher/PublicAPIInstance.cs

@@ -35,9 +35,7 @@ public class PublicAPIInstance : IPublicAPI
         private readonly SettingWindowViewModel _settingsVM;
         private readonly MainViewModel _mainVM;
 
-        private Updater _updater;
-
-        #region Constructor & Initialization
+        #region Constructor
 
         public PublicAPIInstance()
         {
@@ -47,13 +45,6 @@ public PublicAPIInstance()
             WebRequest.RegisterPrefix("data", new DataWebRequestFactory());
         }
 
-        public void Initialize()
-        {
-            // We need to initialize Updater not in the constructor because we want to avoid
-            // recrusive dependency injection
-            _updater = Ioc.Default.GetRequiredService<Updater>();
-        }
-
         #endregion
 
         #region Public API
@@ -86,7 +77,7 @@ public void RestartApp()
 
         public event VisibilityChangedEventHandler VisibilityChanged { add => _mainVM.VisibilityChanged += value; remove => _mainVM.VisibilityChanged -= value; }
 
-        public void CheckForNewUpdate() => _ = _updater.UpdateAppAsync(false);
+        public void CheckForNewUpdate() => _ = Ioc.Default.GetRequiredService<Updater>().UpdateAppAsync(false);
 
         public void SaveAppAllSettings()
         {