Refactor plugin zip logic

- Download zip to temp folder
- Unzip to unique folder

Author: VictoriousRaptor

Flow.Launcher.Core/Plugin/PluginManager.cs

@@ -366,18 +366,28 @@ public static bool PluginModified(string uuid)
             return _modifiedPlugins.Contains(uuid);
         }
 
-        public static void UpdatePlugin(PluginMetadata existingVersion, UserPlugin newVersion, string downloadedFilePath)
+
+        /// <summary>
+        /// Update a plugin to new version, from a zip file. Will Delete zip after updating.
+        /// </summary>
+        public static void UpdatePlugin(PluginMetadata existingVersion, UserPlugin newVersion, string zipFilePath)
         {
-            InstallPlugin(newVersion, downloadedFilePath, checkModified:false);
+            InstallPlugin(newVersion, zipFilePath, checkModified:false);
             UninstallPlugin(existingVersion, removeSettings:false, checkModified:false);
             _modifiedPlugins.Add(existingVersion.ID);
         }
 
-        public static void InstallPlugin(UserPlugin plugin, string downloadedFilePath)
+        /// <summary>
+        /// Install a plugin. Will Delete zip after updating.
+        /// </summary>
+        public static void InstallPlugin(UserPlugin plugin, string zipFilePath)
         {
-            InstallPlugin(plugin, downloadedFilePath, true);
+            InstallPlugin(plugin, zipFilePath, true);
         }
 
+        /// <summary>
+        /// Uninstall a plugin.
+        /// </summary>
         public static void UninstallPlugin(PluginMetadata plugin, bool removeSettings = true)
         {
             UninstallPlugin(plugin, removeSettings, true);
@@ -387,29 +397,18 @@ public static void UninstallPlugin(PluginMetadata plugin, bool removeSettings =
 
         #region Internal functions
 
-        internal static void InstallPlugin(UserPlugin plugin, string downloadedFilePath, bool checkModified)
+        internal static void InstallPlugin(UserPlugin plugin, string zipFilePath, bool checkModified)
         {
             if (checkModified && PluginModified(plugin.ID))
             {
                 // Distinguish exception from installing same or less version
                 throw new ArgumentException($"Plugin {plugin.Name} {plugin.ID} has been modified.", nameof(plugin));
             }
 
-            var tempFolderPath = Path.Combine(Path.GetTempPath(), "flowlauncher");
-            var tempFolderPluginPath = Path.Combine(tempFolderPath, "plugin");
-
-            if (Directory.Exists(tempFolderPath))
-                Directory.Delete(tempFolderPath, true);
-
-            Directory.CreateDirectory(tempFolderPath);
-
-            var zipFilePath = Path.Combine(tempFolderPath, Path.GetFileName(downloadedFilePath));
-
-            File.Copy(downloadedFilePath, zipFilePath);
-
-            File.Delete(downloadedFilePath);
-
+            // Unzip plugin files to temp folder
+            var tempFolderPluginPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
             System.IO.Compression.ZipFile.ExtractToDirectory(zipFilePath, tempFolderPluginPath);
+            File.Delete(zipFilePath);
 
             var pluginFolderPath = GetContainingFolderPathAfterUnzip(tempFolderPluginPath);
 
@@ -454,7 +453,7 @@ internal static void InstallPlugin(UserPlugin plugin, string downloadedFilePath,
 
             FilesFolders.CopyAll(pluginFolderPath, newPluginPath);
 
-            Directory.Delete(pluginFolderPath, true);
+            Directory.Delete(tempFolderPluginPath, true);
 
             if (checkModified)
             {

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

@@ -139,7 +139,7 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
                 ? $"{plugin.Name}-{Guid.NewGuid()}.zip"
                 : $"{plugin.Name}-{plugin.Version}.zip";
 
-            var filePath = Path.Combine(DataLocation.PluginsDirectory, downloadFilename);
+            var filePath = Path.Combine(Path.GetTempPath(), downloadFilename);
 
             try
             {
@@ -240,7 +240,7 @@ where existingPlugin.Metadata.Version.CompareTo(pluginFromManifest.Version) <
                                     Context.API.GetTranslation("plugin_pluginsmanager_update_title"),
                                     MessageBoxButton.YesNo) == MessageBoxResult.Yes)
                             {
-                                var downloadToFilePath = Path.Combine(DataLocation.PluginsDirectory,
+                                var downloadToFilePath = Path.Combine(Path.GetTempPath(),
                                     $"{x.Name}-{x.NewVersion}.zip");
 
                                 _ = Task.Run(async delegate
@@ -414,6 +414,7 @@ private void Install(UserPlugin plugin, string downloadedFilePath)
             try
             {
                 PluginManager.InstallPlugin(plugin, downloadedFilePath);
+                File.Delete(downloadedFilePath);
             }
             catch (FileNotFoundException e)
             {