Skip to content

Commit f79a2d2

Browse files
committed
change to issues endpoint
1 parent 489699c commit f79a2d2

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

.github/update_release_pr.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def get_github_prs(token, owner, repo, milestone, label, state):
2424

2525
milestone_id = None
2626
milestone_url = f"https://api.github.com/repos/{owner}/{repo}/milestones"
27-
params = {"state": state}
27+
params = {"state": open}
2828

2929
try:
3030
response = requests.get(milestone_url, headers=headers, params=params)
@@ -37,17 +37,19 @@ def get_github_prs(token, owner, repo, milestone, label, state):
3737

3838
if not milestone_id:
3939
print(f"Milestone '{milestone}' not found in repository '{owner}/{repo}'.")
40-
return []
40+
exit(1)
4141

4242
except requests.exceptions.RequestException as e:
4343
print(f"Error fetching milestones: {e}")
44-
return []
44+
exit(1)
4545

46-
prs_url = f"https://api.github.com/repos/{owner}/{repo}/pulls"
46+
# This endpoint allows filtering by milestone and label. A PR in GH's perspective is a type of issue.
47+
prs_url = f"https://api.github.com/repos/{owner}/{repo}/issues"
4748
params = {
4849
"state": state,
4950
"milestone": milestone_id,
5051
"labels": label,
52+
"per_page": 100,
5153
}
5254

5355
all_prs = []
@@ -61,18 +63,19 @@ def get_github_prs(token, owner, repo, milestone, label, state):
6163

6264
if not prs:
6365
break # No more PRs to fetch
64-
65-
all_prs.extend(prs)
66+
67+
# Check for pr key since we are using issues endpoint instead.
68+
all_prs.extend([item for item in prs if "pull_request" in item])
6669
page += 1
6770

6871
except requests.exceptions.RequestException as e:
6972
print(f"Error fetching pull requests: {e}")
70-
break
73+
exit(1)
7174

7275
return all_prs
7376

7477
if __name__ == "__main__":
75-
github_token = os.environ.get("GITHUB_TOKEN")
78+
github_token = os.environ.get("GITHUB_TOKEN")
7679

7780
if not github_token:
7881
print("Error: GITHUB_TOKEN environment variable not set.")

0 commit comments

Comments
 (0)