Remove need for saving to settings file by getting status dynamically

Author: jjw24

Wox.Infrastructure/UserSettings/Settings.cs

@@ -77,8 +77,6 @@ public string QuerySearchPrecisionString
         public bool DontPromptUpdateMsg { get; set; }
         public bool EnableUpdateLog { get; set; }
 
-        public bool PortableMode { get; set; } = DataLocation.PortableDataLocationInUse();
-
         public bool StartWoxOnSystemStartup { get; set; } = true;
         public bool HideOnStartup { get; set; }
         bool _hideNotifyIcon { get; set; }

Wox/ViewModel/SettingWindowViewModel.cs

@@ -38,7 +38,6 @@ public SettingWindowViewModel(Updater updater, IPortable portable)
                     OnPropertyChanged(nameof(ActivatedTimes));
                 }
             };
-            _portableMode = Settings.PortableMode;
         }
 
         public Settings Settings { get; set; }
@@ -48,26 +47,33 @@ public async void UpdateApp()
             await _updater.UpdateApp(false);
         }
 
-        private bool _portableMode;
+        // This is only required to set at startup. When portable mode enabled/disabled a restart is always required
+        private bool _portableMode = DataLocation.PortableDataLocationInUse();
         public bool PortableMode
         {
             get { return _portableMode; }
             set
             {
                 if (!_portable.CanUpdatePortability())
                     return;
-                
-                _portableMode = value;
 
-                Settings.PortableMode = value;
-                Save();
-                PortabilityUpdate(value);
+                bool switchToPortable;
+                if(DataLocation.PortableDataLocationInUse())
+                {
+                    switchToPortable = false;
+                }
+                else
+                {
+                    switchToPortable = true;
+                }
+                
+                PortabilityUpdate(switchToPortable);
             }
         }
 
-        private void PortabilityUpdate(bool enabled)
+        private void PortabilityUpdate(bool enablePortableMode)
         {
-            if (enabled)
+            if (enablePortableMode)
             {
                 _portable.EnablePortableMode();
             }