Optimize code

Author: taooceros

Flow.Launcher.Infrastructure/StringMatcher.cs

@@ -229,52 +229,35 @@ private bool IsAcronymCount(string stringToCompare, int compareStringIndex)
             if (IsAcronymChar(stringToCompare, compareStringIndex))
                 return true;
 
-            if (char.IsNumber(stringToCompare[compareStringIndex]) || char.IsDigit(stringToCompare[compareStringIndex]))
-            {
-                return compareStringIndex switch
-                {
-                    int i when i == 0 => true,
-                    int i when char.IsWhiteSpace(stringToCompare[i - 1]) => true,
-                    _ => false,
-                };
-            }
-
-            return false;
-        }
+            if (IsAcronymNumber(stringToCompare, compareStringIndex))
+                return compareStringIndex == 0 || char.IsWhiteSpace(stringToCompare[compareStringIndex - 1]);
 
-        private bool IsAcronymChar(string stringToCompare, int compareStringIndex)
-        {
-            if (char.IsUpper(stringToCompare[compareStringIndex]) ||
-                    compareStringIndex == 0 || //0 index means char is the start of the compare string, which is an acronym
-                    compareStringIndex != 0 && char.IsWhiteSpace(stringToCompare[compareStringIndex - 1]))
-                return true;
 
             return false;
         }
 
-        private bool IsAcronymNumber(string stringToCompare, int compareStringIndex)
-        {
-            if (char.IsNumber(stringToCompare[compareStringIndex]) ||
-                char.IsDigit(stringToCompare[compareStringIndex]))
-                return true;
+        private bool IsAcronymChar(string stringToCompare, int compareStringIndex)
+            => char.IsUpper(stringToCompare[compareStringIndex]) ||
+               compareStringIndex == 0 || // 0 index means char is the start of the compare string, which is an acronym
+               char.IsWhiteSpace(stringToCompare[compareStringIndex - 1]);
 
-            return false;
-        }
+        private bool IsAcronymNumber(string stringToCompare, int compareStringIndex) => stringToCompare[compareStringIndex] >= 0 && stringToCompare[compareStringIndex] <= 9;
 
         // To get the index of the closest space which preceeds the first matching index
         private int CalculateClosestSpaceIndex(List<int> spaceIndices, int firstMatchIndex)
         {
-            if (spaceIndices.Count == 0)
-            {
-                return -1;
-            }
-            else
+            var closestSpaceIndex = -1;
+
+            // spaceIndices should be ordered asc
+            foreach (var index in spaceIndices)
             {
-                int? ind = spaceIndices.OrderBy(item => (firstMatchIndex - item))
-                    .FirstOrDefault(item => firstMatchIndex > item);
-                int closestSpaceIndex = ind ?? -1;
-                return closestSpaceIndex;
+                if (index < firstMatchIndex)
+                    closestSpaceIndex = index;
+                else
+                    break;
             }
+
+            return closestSpaceIndex;
         }
 
         private static bool AllPreviousCharsMatched(int startIndexToVerify, int currentQuerySubstringCharacterIndex,