update ActionKeywordSetting view logic

jjw24 · jjw24 · commit ff404c5c5b9b · 2021-06-05T18:44:16.000+10:00
diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -252,6 +252,8 @@ public static List<Result> GetContextMenusForPlugin(Result result)
 
         public static bool ActionKeywordRegistered(string actionKeyword)
         {
+            // this method is only checking for action keywords (defined as not '*') registration
+            // hence the actionKeyword != Query.GlobalPluginWildcardSign logic
             return actionKeyword != Query.GlobalPluginWildcardSign
                    && NonGlobalPlugins.ContainsKey(actionKeyword);
         }
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml b/Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml
@@ -23,6 +23,10 @@
     <system:String x:Key="plugin_explorer_actionkeywordview_path">Path Search:</system:String>
     <system:String x:Key="plugin_explorer_actionkeywordview_filecontentsearch">File Content Search:</system:String>
     <system:String x:Key="plugin_explorer_actionkeywordview_indexonlysearch">Index Search:</system:String>
+    <system:String x:Key="plugin_explorer_actionkeyword_current">Current Action Keyword:</system:String>
+    <system:String x:Key="plugin_explorer_actionkeyword_done">Done</system:String>
+    <system:String x:Key="plugin_explorer_actionkeyword_enabled">Enabled</system:String>
+    <system:String x:Key="plugin_explorer_actionkeyword_enabled_tooltip">When disabled Flow will not execute this search option, and will additionally revert back to '*' to free up the action keyword</system:String>
 
     <!--Plugin Infos-->
     <system:String x:Key="plugin_explorer_plugin_name">Explorer</system:String>
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs
@@ -67,7 +67,7 @@ internal async Task<List<Result>> SearchAsync(Query query, CancellationToken tok
 
         private bool ActionKeywordMatch(Query query, Settings.ActionKeyword allowedActionKeyword)
         {
-            var keyword = query.ActionKeyword.Length == 0 ? "*" : query.ActionKeyword;
+            var keyword = query.ActionKeyword.Length == 0 ? Query.GlobalPluginWildcardSign : query.ActionKeyword;
 
             return allowedActionKeyword switch
             {
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs b/Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs
@@ -62,7 +62,14 @@ internal void UpdateActionKeyword(Settings.ActionKeyword modifiedActionKeyword,
             }
         }
 
-        internal bool IsActionKeywordAlreadyAssigned(string newActionKeyword) => PluginManager.ActionKeywordRegistered(newActionKeyword);
+        internal bool IsActionKeywordAlreadyAssigned(string newActionKeyword, string oldActionKeyword)
+        {
+            // PluginManager.ActionKeywordRegistered does not check global action keyword ('*'), so use this logic instead
+            if (newActionKeyword == Query.GlobalPluginWildcardSign)
+                return newActionKeyword == oldActionKeyword;
+
+            return PluginManager.ActionKeywordRegistered(newActionKeyword);
+        }
 
         internal bool IsNewActionKeywordGlobal(string newActionKeyword) => newActionKeyword == Query.GlobalPluginWildcardSign;
     }
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml b/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml
@@ -20,23 +20,19 @@
             <ColumnDefinition />
         </Grid.ColumnDefinitions>
         <TextBlock Margin="20 10 10 10" FontSize="14" Grid.Row="0" Grid.Column="0" VerticalAlignment="Center"
-                   HorizontalAlignment="Left" Text="Current Action Keyword:" />
+                   HorizontalAlignment="Left" Text="{DynamicResource plugin_explorer_actionkeyword_current}" />
         <TextBox Name="TxtCurrentActionKeyword"
                  Margin="10" Grid.Row="0" Width="105" Grid.Column="1"
                  VerticalAlignment="Center"
                  HorizontalAlignment="Left"
                  Text="{Binding CurrentActionKeyword.Keyword}" />
-        <CheckBox Name="ChkActionKeywordEnabled" Margin="10" Grid.Row="0" Grid.Column="2" Content="Enabled"
+        <CheckBox Name="ChkActionKeywordEnabled" ToolTip="{DynamicResource plugin_explorer_actionkeyword_enabled_tooltip}"
+                  Margin="10" Grid.Row="0" Grid.Column="2" Content="{DynamicResource plugin_explorer_actionkeyword_enabled}"
                   Width="auto"
                   VerticalAlignment="Center" IsChecked="{Binding CurrentActionKeyword.Enabled}"
                   Visibility="{Binding Visible}"/>
-        <StackPanel Orientation="Horizontal" Grid.Column="1" Grid.ColumnSpan="2" Margin="100 92 0 0" Grid.RowSpan="2">
-            <Button Click="OnConfirmButtonClick"
-                    Margin="10 0 10 0" Width="80" Height="35"
-                    Content="OK" />
-            <Button Click="OnCancelButtonClick"
-                    Margin="10 0 10 0" Width="80" Height="35"
-                    Content="Cancel" />
-        </StackPanel>
+        <Button Click="OnDoneButtonClick" Grid.Row="1" Grid.Column="2"
+                Margin="10 0 10 0" Width="80" Height="35"
+                Content="{DynamicResource plugin_explorer_actionkeyword_done}" />
     </Grid>
 </Window>
diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml.cs
@@ -1,4 +1,4 @@
-﻿using Flow.Launcher.Plugin.Explorer.ViewModels;
+using Flow.Launcher.Plugin.Explorer.ViewModels;
 using System.Collections.Generic;
 using System.Linq;
 using System.Windows;
@@ -14,6 +14,8 @@ public partial class ActionKeywordSetting : Window
 
         public ActionKeywordView CurrentActionKeyword { get; set; }
 
+        private string oldActionKeyword;
+
         private List<ActionKeywordView> actionKeywordListView;
 
         private Settings settings;
@@ -30,32 +32,20 @@ public ActionKeywordSetting(SettingsViewModel settingsViewModel,
 
             CurrentActionKeyword = selectedActionKeyword;
 
+            oldActionKeyword = selectedActionKeyword.Keyword;
+
             this.actionKeywordListView = actionKeywordListView;
             
             InitializeComponent();
 
         }
 
-        private void OnConfirmButtonClick(object sender, RoutedEventArgs e)
+        private void OnDoneButtonClick(object sender, RoutedEventArgs e)
         {
-            var newActionKeyword = TxtCurrentActionKeyword.Text;
-
-            if (string.IsNullOrEmpty(newActionKeyword))
+            if (string.IsNullOrEmpty(CurrentActionKeyword.Keyword))
                 return;
 
-            // reset to global so it does not take up an action keyword when disabled
-            if (!CurrentActionKeyword.Enabled is not null && newActionKeyword != Query.GlobalPluginWildcardSign)
-                settingsViewModel.UpdateActionKeyword(CurrentActionKeyword.KeywordProperty,
-                    Query.GlobalPluginWildcardSign, CurrentActionKeyword.Keyword);
-
-            if (newActionKeyword == CurrentActionKeyword.Keyword)
-            {
-                Close();
-
-                return;
-            }
-
-            if (settingsViewModel.IsNewActionKeywordGlobal(newActionKeyword)
+            if (settingsViewModel.IsNewActionKeywordGlobal(CurrentActionKeyword.Keyword)
                 && CurrentActionKeyword.KeywordProperty == Settings.ActionKeyword.FileContentSearchActionKeyword)
             {
                 MessageBox.Show(
@@ -64,13 +54,12 @@ private void OnConfirmButtonClick(object sender, RoutedEventArgs e)
                 return;
             }
 
-            if (!settingsViewModel.IsActionKeywordAlreadyAssigned(newActionKeyword))
+            if (!settingsViewModel.IsActionKeywordAlreadyAssigned(CurrentActionKeyword.Keyword, oldActionKeyword))
             {
-                settingsViewModel.UpdateActionKeyword(CurrentActionKeyword.KeywordProperty, newActionKeyword,
-                    CurrentActionKeyword.Keyword);
+                settingsViewModel.UpdateActionKeyword(CurrentActionKeyword.KeywordProperty, CurrentActionKeyword.Keyword, oldActionKeyword);
 
                 actionKeywordListView.FirstOrDefault(x => x.Description == CurrentActionKeyword.Description).Keyword =
-                    newActionKeyword;
+                    CurrentActionKeyword.Keyword;
 
                 // automatically help users set this to enabled if an action keyword is set and currently disabled
                 if (CurrentActionKeyword.KeywordProperty == Settings.ActionKeyword.IndexSearchActionKeyword
@@ -81,16 +70,19 @@ private void OnConfirmButtonClick(object sender, RoutedEventArgs e)
                     && !settings.EnabledPathSearchKeyword)
                     settings.EnabledPathSearchKeyword = true;
 
+                if (CurrentActionKeyword.KeywordProperty == Settings.ActionKeyword.SearchActionKeyword
+                    && !settings.EnableSearchActionKeyword)
+                    settings.EnableSearchActionKeyword = true;
+
                 Close();
 
                 return;
             }
 
-            MessageBox.Show(settingsViewModel.Context.API.GetTranslation("newActionKeywordsHasBeenAssigned"));
-        }
+            // reset to global so it does not take up an action keyword when disabled
+            if (CurrentActionKeyword.Enabled is not null && CurrentActionKeyword.Enabled == false && CurrentActionKeyword.Keyword != Query.GlobalPluginWildcardSign)
+                settingsViewModel.UpdateActionKeyword(CurrentActionKeyword.KeywordProperty, Query.GlobalPluginWildcardSign, oldActionKeyword);
 
-        private void OnCancelButtonClick(object sender, RoutedEventArgs e)
-        {
             Close();
 
             return;

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,8 @@ public static List<Result> GetContextMenusForPlugin(Result result)`
`252`	`252`
`253`	`253`	`public static bool ActionKeywordRegistered(string actionKeyword)`
`254`	`254`	`{`
	`255`	`+ // this method is only checking for action keywords (defined as not '*') registration`
	`256`	`+ // hence the actionKeyword != Query.GlobalPluginWildcardSign logic`
`255`	`257`	`return actionKeyword != Query.GlobalPluginWildcardSign`
`256`	`258`	`&& NonGlobalPlugins.ContainsKey(actionKeyword);`
`257`	`259`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ internal async Task<List<Result>> SearchAsync(Query query, CancellationToken tok`
`67`	`67`
`68`	`68`	`private bool ActionKeywordMatch(Query query, Settings.ActionKeyword allowedActionKeyword)`
`69`	`69`	`{`
`70`		`- var keyword = query.ActionKeyword.Length == 0 ? "*" : query.ActionKeyword;`
	`70`	`+ var keyword = query.ActionKeyword.Length == 0 ? Query.GlobalPluginWildcardSign : query.ActionKeyword;`
`71`	`71`
`72`	`72`	`return allowedActionKeyword switch`
`73`	`73`	`{`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,14 @@ internal void UpdateActionKeyword(Settings.ActionKeyword modifiedActionKeyword,`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`- internal bool IsActionKeywordAlreadyAssigned(string newActionKeyword) => PluginManager.ActionKeywordRegistered(newActionKeyword);`
	`65`	`+ internal bool IsActionKeywordAlreadyAssigned(string newActionKeyword, string oldActionKeyword)`
	`66`	`+ {`
	`67`	`+ // PluginManager.ActionKeywordRegistered does not check global action keyword ('*'), so use this logic instead`
	`68`	`+ if (newActionKeyword == Query.GlobalPluginWildcardSign)`
	`69`	`+ return newActionKeyword == oldActionKeyword;`
	`70`	`+`
	`71`	`+ return PluginManager.ActionKeywordRegistered(newActionKeyword);`
	`72`	`+ }`
`66`	`73`
`67`	`74`	`internal bool IsNewActionKeywordGlobal(string newActionKeyword) => newActionKeyword == Query.GlobalPluginWildcardSign;`
`68`	`75`	`}`