Addressing initial feedback

Author: nachmore

Flow.Launcher.Core/Plugin/PluginsLoader.cs

@@ -11,7 +11,6 @@
 using Flow.Launcher.Infrastructure.UserSettings;
 using Flow.Launcher.Plugin;
 using Flow.Launcher.Plugin.SharedCommands;
-using System.Diagnostics;
 using Stopwatch = Flow.Launcher.Infrastructure.Stopwatch;
 
 namespace Flow.Launcher.Core.Plugin

Flow.Launcher/HotkeyControl.xaml.cs

@@ -101,7 +101,7 @@ public async Task SetHotkey(HotkeyModel keyModel, bool triggerValidate = true)
             }
         }
 
-        public void SetHotkey(string keyStr, bool triggerValidate = true)
+        public async Task SetHotkey(string keyStr, bool triggerValidate = true)
         {
             _ = SetHotkey(new HotkeyModel(keyStr), triggerValidate);
         }
@@ -116,4 +116,4 @@ private void tbHotkey_LostFocus(object sender, RoutedEventArgs e)
             tbMsg.Foreground = tbMsgForegroundColorOriginal;
         }
     }
-}
+}

Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs

@@ -94,7 +94,7 @@ private bool ActionKeywordMatch(Query query, Settings.ActionKeyword allowedActio
                                                                    keyword == Settings.IndexSearchActionKeyword,
                 Settings.ActionKeyword.QuickAccessActionKeyword => Settings.QuickAccessKeywordEnabled &&
                                                                         keyword == Settings.QuickAccessActionKeyword,
-                _ => false
+                _ => throw new NotImplementedException()
             };
         }
 

Plugins/Flow.Launcher.Plugin.Shell/Main.cs

@@ -376,9 +376,9 @@ public List<Result> LoadContextMenus(Result selectedResult)
                 new Result
                 {
                     Title = context.API.GetTranslation("flowlauncher_plugin_cmd_run_as_different_user"),
-                    Action = c =>
+                    AsyncAction = async c =>
                     {
-                        _ = Task.Run(() => Execute(ShellCommand.RunAsDifferentUser, PrepareProcessStartInfo(selectedResult.Title)));
+                        Execute(ShellCommand.RunAsDifferentUser, PrepareProcessStartInfo(selectedResult.Title));
                         return true;
                     },
                     IcoPath = "Images/user.png"