Skip to content

BUG: SameOrLesserPluginVersionExists does not compare correctly #3804

@OrigamiDev-Pete

Description

@OrigamiDev-Pete

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

  • I am using the prerelease version of Flow Launcher.

Problem Description

The SameOrLesserPluginVersionExists uses a simple string comparison to compare the current and incoming versions which does not account correctly for versions such as 1.0.9 to 1.0.10 as it considers 1.0.9 to be the greater version.
Consider using System.Version to compare versions instead.

To Reproduce

  1. Call UpdatePluginAsync with a version x.x.10 where the previous version was x.x.9

Screenshots

No response

Flow Launcher Version

1.20.1

Windows Build Number

10.0.22631.5472

Error Log

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions