BUG: CPU spikes (up to 100%) while idle in the background and using Firefox (favicon loading issue)

[wolleydev]

Checks

• I have checked that this issue has not already been reported.

• I am using the latest version of Flow Launcher.

• I am using the prerelease version of Flow Launcher.

Problem Description

I am running the latest Flow Launcher version on Windows 10 22H2 (OS Build 19045.6466).

Sometimes, seemingly at random, I will get a massive CPU usage spike from Flow Launcher. It will take up whatever CPU is available. I've seen it come very close to 100%.
This happens when it is idle in the background. I am not using it or doing anything with it. In fact, I have never seen a spike while doing a search, but I might just have been lucky with that.
This usually lasts about 10-30 seconds, then the CPU usage comes back down.
It seems that while this happens, I sometimes get a spike with "System Interrupts" as well. I was not able to catch it happening in real time (as just opening the task manager can take a dozen seconds when the entire system is lagging), so I am not sure in which order this happens.

I have tried using low priority for the process via the Task Manager, to no avail.

After looking at the logs, the latest logged event right after another spike happened was loading the Firefox bookmark favicons. I have close to 300 bookmarks. It seems that opening new Firefox tabs will trigger Flow Launcher to scan for favicons again, causing a spike.
When disabling the favicon option, I do not have any more spikes.

To Reproduce

• Have a lot of Firefox bookmarks (300)
• Enable FL's browser bookmarks plugin and check "load favicons"
• Let FL run in the background
• Open several tabs in Firefox to different URLs
• The CPU spikes

Screenshots

Flow Launcher Version

2.0.2

Windows Build Number

19045.6466

Error Log

04:10:32.2269+01:00 - INFO - FirefoxBookmarkLoaderBase.GetBookmarksFromPath - Load 270 favicons cost <34450ms>
04:11:00.7589+01:00 - INFO - FirefoxBookmarkLoaderBase.GetBookmarksFromPath - Load 270 favicons cost <28496ms>

[Jack251970]

Could you please check if this can help?

https://ci.appveyor.com/project/JohnTheGr8/flow-launcher/builds/52818567/artifacts

[wolleydev]

Hey, sorry I am not sure what I am supposed to do with these files. They show up as nupkg on the page but download as zips. Should I rename them? Then what do I do with them?

[Jack251970]

Hey, sorry I am not sure what I am supposed to do with these files. They show up as nupkg on the page but download as zips. Should I rename them? Then what do I do with them?

Sorry, it looks like something does not work well here.

[Jack251970]

Will notify you if test executable is available