[Dev] Fix application URI logic when opening via WebSearch plugin #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTheGr8
reviewed
Feb 3, 2022
There was a problem hiding this comment.
This seems to have been done in a bit of a rush 😆 Can we refactor to make it look a bit nicer?
I think we can:
- move the
Process.Startcall fromOpenAppUrito the privateOpenUriand have everything in one place, and callOpenUrifromOpenAppUri(similar toOpenUrl) - use an
elsestatement inOpenUriand remove those early returns
Also, as mentioned before, I think it's a good idea to add an overload for OpenAppUri (maybe also for OpenUrl) that accepts a Uri instead of a string. I think plugins that use this method might already have a Uri before calling it, so why create a new one in OpenUri...
|
done, please review @JohnTheGr8 @taooceros |
jjw24
requested review from
Garulf,
JohnTheGr8 and
taooceros
and removed request for
Garulf,
JohnTheGr8 and
taooceros
JohnTheGr8
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect logic added in #968 where application URIs opened from WebSearch plugin are not be triggered